From: "Roger Sayle" <roger@nextmovesoftware.com>
To: "'GCC Patches'" <gcc-patches@gcc.gnu.org>
Cc: "'Tom de Vries'" <tdevries@suse.de>
Subject: [nvptx PATCH] Correct pattern for popcountdi2 insn in nvptx.md.
Date: Mon, 9 Jan 2023 13:29:14 -0000 [thread overview]
Message-ID: <00b601d9242e$5fe32ec0$1fa98c40$@nextmovesoftware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
The result of a POPCOUNT operation in RTL should have the same mode
as its operand. This corrects the specification of popcount in
the nvptx backend, splitting the current generic define_insn into
two, one for popcountsi2 and the other for popcountdi2 (the latter
with an explicit truncate).
This patch has been tested on nvptx-none (hosted on x86_64-pc-linux-gnu)
with make and make -k check with no new failures. This functionality is
already tested by gcc.target/nvptx/popc-[123].c. Ok for mainline?
2023-01-09 Roger Sayle <roger@nextmovesoftware.com>
gcc/ChangeLog
* config/nvptx/nvptx.md (popcount<mode>2): Split into...
(popcountsi2): define_insn handling SImode popcount.
(popcountdi2): define_insn handling DImode popcount, with an
explicit truncate:SI to produce an SImode result.
Thanks in advance,
Roger
--
[-- Attachment #2: patchpc.txt --]
[-- Type: text/plain, Size: 793 bytes --]
diff --git a/gcc/config/nvptx/nvptx.md b/gcc/config/nvptx/nvptx.md
index 740c4de..461540e 100644
--- a/gcc/config/nvptx/nvptx.md
+++ b/gcc/config/nvptx/nvptx.md
@@ -658,11 +658,18 @@
DONE;
})
-(define_insn "popcount<mode>2"
+(define_insn "popcountsi2"
[(set (match_operand:SI 0 "nvptx_register_operand" "=R")
- (popcount:SI (match_operand:SDIM 1 "nvptx_register_operand" "R")))]
+ (popcount:SI (match_operand:SI 1 "nvptx_register_operand" "R")))]
""
- "%.\\tpopc.b%T1\\t%0, %1;")
+ "%.\\tpopc.b32\\t%0, %1;")
+
+(define_insn "popcountdi2"
+ [(set (match_operand:SI 0 "nvptx_register_operand" "=R")
+ (truncate:SI
+ (popcount:DI (match_operand:DI 1 "nvptx_register_operand" "R"))))]
+ ""
+ "%.\\tpopc.b64\\t%0, %1;")
;; Multiplication variants
next reply other threads:[~2023-01-09 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 13:29 Roger Sayle [this message]
2024-04-12 22:16 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00b601d9242e$5fe32ec0$1fa98c40$@nextmovesoftware.com' \
--to=roger@nextmovesoftware.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).