From: Jeff Law <law@redhat.com>
To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com
Subject: Re: Fix vec_cmp comparison mode
Date: Tue, 15 Nov 2016 20:50:00 -0000 [thread overview]
Message-ID: <00d4cc02-e806-c4b6-020a-9fa319ff3023@redhat.com> (raw)
In-Reply-To: <87fums1yem.fsf@e105548-lin.cambridge.arm.com>
On 11/15/2016 09:49 AM, Richard Sandiford wrote:
> vec_cmps assign the result of a vector comparison to a mask.
> The optab was called with the destination having mode mask_mode
> but with the source (the comparison) having mode VOIDmode,
> which led to invalid rtl if the source operand was used directly.
>
> Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install?
>
> Thanks,
> Richard
>
>
> [ This patch is part of the SVE series posted here:
> https://gcc.gnu.org/ml/gcc/2016-11/msg00030.html ]
>
> gcc/
> 2016-11-15 Richard Sandiford <richard.sandiford@arm.com>
> Alan Hayward <alan.hayward@arm.com>
> David Sherwood <david.sherwood@arm.com>
>
> * optabs.c (vector_compare_rtx): Add a cmp_mode parameter
> and use it in the final call to gen_rtx_fmt_ee.
> (expand_vec_cond_expr): Update accordingly.
> (expand_vec_cmp_expr): Likewise.
OK.
jeff
prev parent reply other threads:[~2016-11-15 20:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 16:49 Richard Sandiford
2016-11-15 20:50 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00d4cc02-e806-c4b6-020a-9fa319ff3023@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).