From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66259 invoked by alias); 9 Nov 2018 22:01:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 65684 invoked by uid 89); 9 Nov 2018 22:01:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*UA:16.0, H*x:16.0, H*Ad:U*macro, H*UA:Outlook X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Nov 2018 22:01:47 +0000 Received: by mail-wm1-f65.google.com with SMTP id r63-v6so3332961wma.4 for ; Fri, 09 Nov 2018 14:01:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=LFRabcsLHoB3H7sh9H49pRF3t945iFXE6qLSlhMpeK0=; b=EPnYoL0bs/25OGMz5QFmVzQgAYx1LNxnPoA9dkvH1jOsmhPVUgViiTckeFXvNyMKK1 3KsOfJeCF2sPoTgZgJMbLLNMhy24J91SliBdwTjkP8UEusLQoRaduKJdO11qOrbFLUN2 bS0+a0/wbU9ewUGvUbK+HRDbPGfzKGBNz5lHK3B1FDp9OKsyrrFUx8/T2YI6MPSNI8Jb EjbvLuZMwlqXntXGYRMz2Dg1k/sr1/Bypj4g8Kt4G6ElZiDhgHH7UjAJPN9Y/Lh8gWhT YHBo+JlcWD+CWUy0t5nOeio4D3xAltzXXkMlwjrhRgVbcrr7juL/qlPScPPsxL4O4fMR OvRA== Return-Path: Received: from LEMFORTUNE (host86-167-86-113.range86-167.btcentralplus.com. [86.167.86.113]) by smtp.gmail.com with ESMTPSA id l9-v6sm1744908wme.36.2018.11.09.14.01.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Nov 2018 14:01:44 -0800 (PST) From: To: "'Fredrik Noring'" , Cc: "'Maciej W. Rozycki'" , =?utf-8?Q?'J=C3=BCrgen_Urban'?= References: <7a209bd56cc4bb5d71dcf37cc7f5878ffb05d40f.1539971239.git.noring@nocrew.org> <20181107163249.GA6040@sx9> In-Reply-To: <20181107163249.GA6040@sx9> Subject: RE: [PATCH v2] MIPS: Default to --with-llsc for the R5900 Linux target as well Date: Fri, 09 Nov 2018 22:01:00 -0000 Message-ID: <00e801d47877$ce492b10$6adb8130$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-SW-Source: 2018-11/txt/msg00799.txt.bz2 Hi Fredrik, > Would it be possible to apply the reviewed patch below? Apologies for the total lack of response from me. Thank-you for your efforts to get this noticed! The patch looks OK to me. I didn't see a ChangeLog entry anywhere but something like the following would be appropriate. gcc/ * config.gcc: Update with-llsc defaults for MIPS r5900. I'll do what I can to help you get the various changes done for r5900; I know there have been attempts before but they faded away for one reason or another. As Maciej has said, your contribution is really appreciated, and for this one, it is obvious enough to go in prior to your FSF copyright assignment coming through. Maciej: I'm not able to commit this for Fredrik at the moment, would you mind doing that for him? Thanks, Matthew > > Thank you, > Fredrik > > On Fri, Oct 19, 2018 at 08:33:33PM +0200, Fredrik Noring wrote: > > The Linux kernel requires and emulates LL and SC for the R5900 too. > > The special --without-llsc default for the R5900 is therefore not > > applicable in that case. > > > > Reviewed-by: Maciej W. Rozycki > > --- > > Changes in v2: > > - Double spacing instead of single spacing in commit message > > > > --- > > gcc/config.gcc | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/gcc/config.gcc b/gcc/config.gcc index > > 720e6a7373d..68c34b16123 100644 > > --- a/gcc/config.gcc > > +++ b/gcc/config.gcc > > @@ -3711,14 +3711,14 @@ fi > > # Infer a default setting for --with-llsc. > > if test x$with_llsc = x; then > > case ${target} in > > - mips64r5900-*-* | mips64r5900el-*-* | mipsr5900-*-* | mipsr5900el-*- > *) > > - # The R5900 doesn't support LL(D) and SC(D). > > - with_llsc=no > > - ;; > > mips*-*-linux*) > > # The kernel emulates LL and SC where necessary. > > with_llsc=yes > > ;; > > + mips64r5900-*-* | mips64r5900el-*-* | mipsr5900-*-* | mipsr5900el-*- > *) > > + # The R5900 doesn't support LL(D) and SC(D). > > + with_llsc=no > > + ;; > > esac > > fi > > > > -- > > 2.18.1 > >