From: "Simon Martin" <simon@nasilyan.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [PATCH] Fix PR c++/109958: ICE taking the address of bound static member function brought into derived class by using-declaration
Date: Fri, 31 May 2024 13:58:04 +0000 [thread overview]
Message-ID: <0102018fcef17f2d-4b47cfb7-7a37-4b48-a507-5688e26fb6a4-000000@eu-west-1.amazonses.com> (raw)
In-Reply-To: <20240531135800.79284-1-simon@nasilyan.com>
From: Simon Martin <simon@nasilyan.com>
We currently ICE upon the following because we don't properly handle the
overload created for B::f through the using statement.
=== cut here ===
struct B { static int f(); };
struct D : B { using B::f; };
void f(D d) { &d.f; }
=== cut here ===
This patch makes build_class_member_access_expr and cp_build_addr_expr_1 handle
such overloads, and fixes the PR.
Successfully tested on x86_64-pc-linux-gnu.
PR c++/109958
gcc/cp/ChangeLog:
* typeck.cc (build_class_member_access_expr): Handle single OVERLOADs.
(cp_build_addr_expr_1): Likewise.
gcc/testsuite/ChangeLog:
* g++.dg/overload/using6.C: New test.
---
gcc/cp/typeck.cc | 5 +++++
gcc/testsuite/g++.dg/overload/using6.C | 5 +++++
2 files changed, 10 insertions(+)
create mode 100644 gcc/testsuite/g++.dg/overload/using6.C
diff --git a/gcc/cp/typeck.cc b/gcc/cp/typeck.cc
index 1b7a31d32f3..5970ac3d398 100644
--- a/gcc/cp/typeck.cc
+++ b/gcc/cp/typeck.cc
@@ -3025,6 +3025,8 @@ build_class_member_access_expr (cp_expr object, tree member,
know the type of the expression. Otherwise, we must wait
until overload resolution has been performed. */
functions = BASELINK_FUNCTIONS (member);
+ if (TREE_CODE (functions) == OVERLOAD && OVL_SINGLE_P (functions))
+ functions = OVL_FIRST (functions);
if (TREE_CODE (functions) == FUNCTION_DECL
&& DECL_STATIC_FUNCTION_P (functions))
type = TREE_TYPE (functions);
@@ -7333,6 +7335,9 @@ cp_build_addr_expr_1 (tree arg, bool strict_lvalue, tsubst_flags_t complain)
{
tree fn = BASELINK_FUNCTIONS (TREE_OPERAND (arg, 1));
+ if (TREE_CODE (fn) == OVERLOAD && OVL_SINGLE_P (fn))
+ fn = OVL_FIRST (fn);
+
/* We can only get here with a single static member
function. */
gcc_assert (TREE_CODE (fn) == FUNCTION_DECL
diff --git a/gcc/testsuite/g++.dg/overload/using6.C b/gcc/testsuite/g++.dg/overload/using6.C
new file mode 100644
index 00000000000..4f89f68a30f
--- /dev/null
+++ b/gcc/testsuite/g++.dg/overload/using6.C
@@ -0,0 +1,5 @@
+// PR c++/109958
+
+struct B { static int f(); };
+struct D : B { using B::f; };
+void f(D d) { &d.f; }
--
2.44.0
next parent reply other threads:[~2024-05-31 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240531135800.79284-1-simon@nasilyan.com>
2024-05-31 13:58 ` Simon Martin [this message]
2024-05-31 20:30 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0102018fcef17f2d-4b47cfb7-7a37-4b48-a507-5688e26fb6a4-000000@eu-west-1.amazonses.com \
--to=simon@nasilyan.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).