From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69371 invoked by alias); 27 Apr 2015 10:33:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 69360 invoked by uid 89); 27 Apr 2015 10:33:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Apr 2015 10:33:06 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by uk-mta-10.uk.mimecast.lan; Mon, 27 Apr 2015 11:33:02 +0100 Received: from shawin221 ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 27 Apr 2015 11:32:54 +0100 From: "Hale Wang" To: "Ramana Radhakrishnan" Cc: "Joseph Myers" , "GCC Patches" References: <000601d07346$9fbec910$df3c5b30$@arm.com> <001301d075c0$d1ec2870$75c47950$@arm.com> <003f01d07cd6$dfe05150$9fa0f3f0$@arm.com> In-Reply-To: Subject: RE: [PATCH] [1/2] [ARM] [libgcc] Support RTABI half-precision conversion functions. Date: Mon, 27 Apr 2015 10:33:00 -0000 Message-ID: <011601d080d5$80c72ab0$82558010$@arm.com> MIME-Version: 1.0 X-MC-Unique: TJ3hFcYmRUakXUYUXxYVvg-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg01600.txt.bz2 > -----Original Message----- > From: Ramana Radhakrishnan [mailto:ramana.gcc@googlemail.com] > Sent: Wednesday, April 22, 2015 5:00 PM > To: Hale Wang > Cc: Ramana Radhakrishnan; Joseph Myers; GCC Patches > Subject: Re: [PATCH] [1/2] [ARM] [libgcc] Support RTABI half-precision > conversion functions. >=20 > On Wed, Apr 22, 2015 at 9:32 AM, Hale Wang wrote: > >> -----Original Message----- > >> From: Ramana Radhakrishnan [mailto:ramana.gcc@googlemail.com] > >> Sent: Wednesday, April 22, 2015 3:50 PM > >> To: Joseph Myers > >> Cc: Hale Wang; GCC Patches > >> Subject: Re: [PATCH] [1/2] [ARM] [libgcc] Support RTABI > >> half-precision conversion functions. > >> > >> On Mon, Apr 13, 2015 at 12:25 PM, Joseph Myers > >> wrote: > >> > On Mon, 13 Apr 2015, Hale Wang wrote: > >> > > >> >> Yes, you are right. It's my fault to add the "only" here. Thank > >> >> you to point out this. > >> >> Beside this, is this patch OK for you? > >> > > >> > I don't think it's a good idea for libgcc to include large pieces > >> > of assembly code generated by a compiler. Just compile the code > >> > with whatever options are needed at the time libgcc is built - > >> > possibly with #if conditionals to allow compiling different versions= of the > code. > > > > Indeed, just compile the code with option '-mfloat-abi=3Dsoft' at the t= ime > libgcc is build which can solve this problem. >=20 > Or why not "conditionally" use the ``pcs'' attribute on the ARM port ? > That then means you don't need options magic on top ? OK. I think your suggestion can solve this problem more clearly. I will res= ubmit a patch later. I think we can discard this patch this time. Thanks a lot. Hale >=20 > Ramana