From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117642 invoked by alias); 4 Dec 2015 19:59:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117632 invoked by uid 89); 4 Dec 2015 19:59:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: usmailout2.samsung.com Received: from mailout2.w2.samsung.com (HELO usmailout2.samsung.com) (211.189.100.12) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 04 Dec 2015 19:59:21 +0000 Received: from uscpsbgm2.samsung.com (u115.gpu85.samsung.co.kr [203.254.195.115]) by mailout2.w2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NYU00KCLNIVBY60@mailout2.w2.samsung.com> for gcc-patches@gcc.gnu.org; Fri, 04 Dec 2015 14:59:19 -0500 (EST) Received: from ussync2.samsung.com ( [203.254.195.82]) by uscpsbgm2.samsung.com (USCPMTA) with SMTP id 67.D3.07641.790F1665; Fri, 4 Dec 2015 14:59:19 -0500 (EST) Received: from WSPOP ([105.140.33.249]) by ussync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NYU0051DNIUKY00@ussync2.samsung.com>; Fri, 04 Dec 2015 14:59:19 -0500 (EST) From: Sebastian Paul Pop To: 'Mike Stump' , 'Alan Lawrence' Cc: sebpop@gmail.com, gcc-patches@gcc.gnu.org, hiraditya@msn.com References: <1446759793-2875-1-git-send-email-s.pop@samsung.com> <56619176.50409@arm.com> <7E34663A-E182-415A-BEE7-5891DBD378A5@comcast.net> In-reply-to: <7E34663A-E182-415A-BEE7-5891DBD378A5@comcast.net> Subject: RE: [PATCH] enable loop fusion on isl-15 Date: Fri, 04 Dec 2015 19:59:00 -0000 Message-id: <015101d12ece$4375cf70$ca616e50$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-SW-Source: 2015-12/txt/msg00633.txt.bz2 I would highly recommend updating the required version of ISL to isl-0.15: that would simplify the existing code, removing a lot of code under "#ifdef old ISL", and allow us to fully transition to schedule_trees instead of dealing with the old antiquated union_maps in the scheudler. The result is faster compilation time. Thanks, Sebastian -----Original Message----- From: Mike Stump [mailto:mikestump@comcast.net] Sent: Friday, December 04, 2015 12:03 PM To: Alan Lawrence Cc: Sebastian Pop; sebpop@gmail.com; gcc-patches@gcc.gnu.org; hiraditya@msn.com Subject: Re: [PATCH] enable loop fusion on isl-15 On Dec 4, 2015, at 5:13 AM, Alan Lawrence wrote: > On 05/11/15 21:43, Sebastian Pop wrote: >> * graphite-optimize-isl.c (optimize_isl): Call >> isl_options_set_schedule_maximize_band_depth. >> >> * gcc.dg/graphite/fuse-1.c: New. >> * gcc.dg/graphite/fuse-2.c: New. >> * gcc.dg/graphite/interchange-13.c: Remove bogus check. > > I note that the test > > scan-tree-dump-times forwprop4 "gimple_simplified to[^\\n]*\\^ 12" 1 > > FAILs under isl-0.14, with which GCC can still be built and generally claims to work. > > Is it worth trying to detect this in the testsuite, so we can XFAIL it? By which I mean, is there a reasonable testsuite mechanism by which we could do that? You can permanently ignore it by updating to 0.15? I don't see the advantage of bothering to finesse this too much. I don't know of a way to detect 14 v 15 other than this test case, but, if you do that, you can't use that result to gate this test case. If one wanted to engineer in a way, one would expose the isl version via a preprocessor symbol (built in), and then the test case would use that to gate it. If we had to fix it, I think I'd prefer we just raise the isl version to 15 or later and be done with it.