From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DBA483858D34 for ; Wed, 1 May 2024 20:23:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DBA483858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DBA483858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714594983; cv=none; b=e9+LFX3rKvxvaE6D/2qBqI7egBuQR8pMHqbgrU8m/G85S6SxKi/Md8dC6+Q1ADQLimAvnw7brU/Ax2HqYPCh++x9D1cbCSNqISj1kqYFC974MhlKJNrc6cwcUaTHO+Zk1J42ITIXo2jGohtG7AkAB1miUYAdrujwANLlRR0WPv8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714594983; c=relaxed/simple; bh=cACpxms/MdcCViLbOuh4koVoNl14fCEoeJ3F3ExsOEQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ehWEoFeuEEbXcsz9vBVwBIARzjDUml3FcCmA6kdhQKdBo87WkYRHZxp4JE+3xd6r301zJA2ZiIjjDb/N0TaXvsS4G02GCUwGMufWCNTVPZaJG9lI1vWIbwGZizemMIOV8cQGvBgTM7n63SEK+BwnTOLcKzssG+JyCM31MxzNQjA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714594981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=up79UQO5H6KPshybv0NYaCXEdbj9Q8k2GwNglAt+Ejk=; b=JZjFEjiff8jgzaLysTw0AndwonfxDqPri3nSAPbwwmdgMWsJ7wybSOweysIBnUAcx9eD1n KaXu9wTPzwrTXN0auL75ju8SwlrxjlNGPGq4cVS7NZeQHzMnTRs/iLjSAyNPnNkB4GZOGg i9j0aI9TH0fu1Ih2GraJxRaaqFzBwVo= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-454-inv2VWL9MSqQ9lgzV1zMuA-1; Wed, 01 May 2024 16:23:00 -0400 X-MC-Unique: inv2VWL9MSqQ9lgzV1zMuA-1 Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-6ee26a21aa5so5075913a34.3 for ; Wed, 01 May 2024 13:23:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714594979; x=1715199779; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=up79UQO5H6KPshybv0NYaCXEdbj9Q8k2GwNglAt+Ejk=; b=fyyuQgSwY3hk+yzSGkaX5Vf4RiYtxj1gov4B6tnF7oPmvko2nEjtQ5OfQengmhGBML yAU8eXb+orQBGpTBqLPqqcYnQJOjdO+m4AJpuCZkS13RZjMrbKwhyjJXYIO2Vb5t/+ns jZgP1EY2pG0bNUXLKVAPr7q8WtIxh1RZacdFVS6QjEox0AzUtCV7e4r1Q1IPvTLOLqUQ /XFiLKqr5NLtowGtbX3Br1aVLlLiwYix2VHYoORYYarwVMJ5BkLJkNoIGXD0fla3rjh6 lNVrcqt/5m9ae5KiwUiq9WvB3IE9vdcTBU0+g7ylzFanZyHnYLvhplkGre+j7gL+PRsP lz6Q== X-Gm-Message-State: AOJu0YyPKfSGtw3T2Sx7hTw3iguvG0Bkbt1eMnmPGijXkUv0Bt1AI6iZ UubsMs6UjzpvLY+puePY6HmUOWqMA4mBcnbYNeBIgSkuvUKkeG32qLxA5DPuNBpkLpKeMV2+LAZ cdbx7mOvrMyM96Vrsy1xbTJa7hgicQHIkSWsnPjHpznIotTB7/sktzO8= X-Received: by 2002:a9d:6257:0:b0:6ee:dae:fe2 with SMTP id i23-20020a9d6257000000b006ee0dae0fe2mr3511623otk.25.1714594979437; Wed, 01 May 2024 13:22:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPznWk1TVnLMd0gGQqASUy8auPDIOCisyNYvEMfY4rCuYbuq02L1j0rwnk6TrnXsfdc2L2kw== X-Received: by 2002:a9d:6257:0:b0:6ee:dae:fe2 with SMTP id i23-20020a9d6257000000b006ee0dae0fe2mr3511609otk.25.1714594979159; Wed, 01 May 2024 13:22:59 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id b24-20020a05620a271800b00790fc75f318sm2586332qkp.32.2024.05.01.13.22.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 May 2024 13:22:58 -0700 (PDT) Message-ID: <0182a4aa-cb43-42ec-b8fd-c9a23424d889@redhat.com> Date: Wed, 1 May 2024 16:22:58 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] c++: remove lookup_template_class's entering_scope flag To: Patrick Palka Cc: gcc-patches@gcc.gnu.org References: <20240202194104.317982-1-ppalka@redhat.com> <20240202194104.317982-2-ppalka@redhat.com> <1053294c-b63c-b40b-0ba2-069e2bd615c3@idea> From: Jason Merrill In-Reply-To: <1053294c-b63c-b40b-0ba2-069e2bd615c3@idea> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/1/24 12:41, Patrick Palka wrote: > On Fri, 2 Feb 2024, Patrick Palka wrote: > >> Bootstrapped and regtested on x86_64-pc-linux, does this look like >> an improvement? This is not a bugfix and barely related to the previous >> patch, but the previous patch's new use of entering_scope=true motivated >> me to submit this patch since it seems like a nice simplification. > > Ping, now that stage 1 is open. Thanks for the ping. The earlier message isn't showing up in Thunderbird for some reason, though I see it in the gmail web interface... >> @@ -16771,9 +16722,10 @@ tsubst (tree t, tree args, tsubst_flags_t complain, tree in_decl) >> ctx = TREE_VEC_ELT (ctx, 0); >> } >> else >> - ctx = tsubst_aggr_type (ctx, args, >> - complain | tf_qualifying_scope, >> - in_decl, /*entering_scope=*/1); >> + { >> + ctx = tsubst_scope (ctx, args, complain, in_decl); Why is this one tsubst_scope while the others are all plain tsubst? Do we want a tsubst_entering_scope function? >> + ctx = adjust_type_for_entering_scope (ctx);