From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id B50E93858CDA; Fri, 30 Dec 2022 06:12:55 +0000 (GMT) Received: from loongson.cn (unknown [10.20.4.52]) by gateway (Coremail) with SMTP id _____8AxRPBgga5jqW4JAA--.21121S3; Fri, 30 Dec 2022 14:12:49 +0800 (CST) Received: from [10.20.4.52] (unknown [10.20.4.52]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxsORfga5jgfoPAA--.52548S2; Fri, 30 Dec 2022 14:12:48 +0800 (CST) Subject: Re: [PATCH v4] LoongArch: Fixed a compilation failure with '%c' in inline assembly [PR107731]. To: gcc-patches@gcc.gnu.org, pinskia@gcc.gnu.org, richard.sandiford@arm.com Cc: xry111@xry111.site, i@xen0n.name, xuchenghua@loongson.cn, Yang Yujie References: <20221227064246.2149251-1-chenglulu@loongson.cn> From: Lulu Cheng Message-ID: <01a9ab90-fbb4-c581-a92f-f1e7c23d4580@loongson.cn> Date: Fri, 30 Dec 2022 14:12:47 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20221227064246.2149251-1-chenglulu@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8BxsORfga5jgfoPAA--.52548S2 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBjvJXoW3XFyfXw1DKF4fWrWxtw4xJFb_yoW7uF1Up3 9rCw1Yvr4xCFn3WwnrZay5ZFs8AwsrKrW29as3tr92kwnFq342vF4FyF9FvF4DCw45XrWj qr4Uu3WUWa12vw7anT9S1TB71UUUUUJqnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU bfAYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s 1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVWUCVW8JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwA2z4 x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1l n4kS14v26r1Y6r17M2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6x ACxx1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E 87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0V AS07AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwCFI7km 07C267AKxVWUXVWUAwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r 1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWU JVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r 1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUv cSsGvfC2KfnxnUUI43ZEXa7IU88Ma5UUUUU== X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_SHORT,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Richard:  Could you please help me look at this document? Is there any problem with my modification? Thanks! 在 2022/12/27 下午2:42, Lulu Cheng 写道: > Co-authored-by: Yang Yujie > > gcc/ChangeLog: > > * config/loongarch/loongarch.cc (loongarch_classify_address): > Add precessint for CONST_INT. > (loongarch_print_operand_reloc): Operand modifier 'c' is supported. > (loongarch_print_operand): Increase the processing of '%c'. > * doc/extend.texi: Adds documents for LoongArch operand modifiers. > > gcc/testsuite/ChangeLog: > > * gcc.target/loongarch/tst-asm-const.c: Moved to... > * gcc.target/loongarch/pr107731.c: ...here. > > --- > V2 -> v3: > 1. Correct a clerical error. > 2. Adding document for loongarch operand modifiers. > > v3 -> v4: > Copy the description of "%c" "%n" "%a" "%l" from gccint.pdf to gcc.pdf. > > > --- > gcc/config/loongarch/loongarch.cc | 14 ++++++++ > gcc/doc/extend.texi | 33 +++++++++++++++++++ > .../loongarch/{tst-asm-const.c => pr107731.c} | 6 ++-- > 3 files changed, 50 insertions(+), 3 deletions(-) > rename gcc/testsuite/gcc.target/loongarch/{tst-asm-const.c => pr107731.c} (78%) > > diff --git a/gcc/config/loongarch/loongarch.cc b/gcc/config/loongarch/loongarch.cc > index c6b03fcf2f9..cdf190b985e 100644 > --- a/gcc/config/loongarch/loongarch.cc > +++ b/gcc/config/loongarch/loongarch.cc > @@ -2075,6 +2075,11 @@ loongarch_classify_address (struct loongarch_address_info *info, rtx x, > return (loongarch_valid_base_register_p (info->reg, mode, strict_p) > && loongarch_valid_lo_sum_p (info->symbol_type, mode, > info->offset)); > + case CONST_INT: > + /* Small-integer addresses don't occur very often, but they > + are legitimate if $r0 is a valid base register. */ > + info->type = ADDRESS_CONST_INT; > + return IMM12_OPERAND (INTVAL (x)); > > default: > return false; > @@ -4933,6 +4938,7 @@ loongarch_print_operand_reloc (FILE *file, rtx op, bool hi64_part, > > 'A' Print a _DB suffix if the memory model requires a release. > 'b' Print the address of a memory operand, without offset. > + 'c' Print an integer. > 'C' Print the integer branch condition for comparison OP. > 'd' Print CONST_INT OP in decimal. > 'F' Print the FPU branch condition for comparison OP. > @@ -4979,6 +4985,14 @@ loongarch_print_operand (FILE *file, rtx op, int letter) > fputs ("_db", file); > break; > > + case 'c': > + if (CONST_INT_P (op)) > + fprintf (file, HOST_WIDE_INT_PRINT_DEC, INTVAL (op)); > + else > + output_operand_lossage ("unsupported operand for code '%c'", letter); > + > + break; > + > case 'C': > loongarch_print_int_branch_condition (file, code, letter); > break; > diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi > index adba057c190..1bb960266ed 100644 > --- a/gcc/doc/extend.texi > +++ b/gcc/doc/extend.texi > @@ -10234,6 +10234,24 @@ generates multiple assembler instructions. > Outputs @samp{@{}, @samp{|}, and @samp{@}} characters (respectively) > into the assembler code. When unescaped, these characters have special > meaning to indicate multiple assembler dialects, as described below. > + > +@item %c@var{digit} > +It can be used to substitute an operand that is a constant value without > +the syntax that normally indicates an immediate operand. > + > +@item %n@var{digit} > +It's like @samp{%c@var{digit}} except that the value of the constant is > +negated before printing. > + > +@item %a@var{digit} > +It Can be used to substitute an operand as if it were a memory reference, > +with the actual operand treated as the address. This may be useful when > +outputting a ``load address'' instruction, because often the assembler > +syntax for such an instruction requires you to write the operand as if it > +were a memory reference. > + > +@item %l@var{digit} > +It's used to substitute a @code{label_ref} into a jump instruction. > @end table > > @subsubheading Multiple assembler dialects in @code{asm} templates > @@ -11374,6 +11392,21 @@ constant. Used to select the specified bit position. > @item @code{x} @tab Equivialent to @code{X}, but only for pointers. > @end multitable > > +@anchor{loongarchOperandmodifiers} > +@subsubsection LoongArch Operand Modifiers > + > +The list below describes the supported modifiers and their effects for LoongArch. > + > +@multitable @columnfractions .10 .90 > +@headitem Modifier @tab Description > +@item @code{d} @tab Same as @code{c}. > +@item @code{i} @tab Print the character ''@code{i}'' if the operand is not a register. > +@item @code{m} @tab Same as @code{c}, but the printed value is @code{operand - 1}. > +@item @code{X} @tab Print a constant integer operand in hexadecimal. > +@item @code{z} @tab Print the operand in its unmodified form, followed by a comma. > +@end multitable > + > + > @lowersections > @include md.texi > @raisesections > diff --git a/gcc/testsuite/gcc.target/loongarch/tst-asm-const.c b/gcc/testsuite/gcc.target/loongarch/pr107731.c > similarity index 78% > rename from gcc/testsuite/gcc.target/loongarch/tst-asm-const.c > rename to gcc/testsuite/gcc.target/loongarch/pr107731.c > index 2e04b99e301..80d84c48c6e 100644 > --- a/gcc/testsuite/gcc.target/loongarch/tst-asm-const.c > +++ b/gcc/testsuite/gcc.target/loongarch/pr107731.c > @@ -1,13 +1,13 @@ > -/* Test asm const. */ > /* { dg-do compile } */ > /* { dg-final { scan-assembler-times "foo:.*\\.long 1061109567.*\\.long 52" 1 } } */ > + > int foo () > { > __asm__ volatile ( > "foo:" > "\n\t" > - ".long %a0\n\t" > - ".long %a1\n\t" > + ".long %c0\n\t" > + ".long %c1\n\t" > : > :"i"(0x3f3f3f3f), "i"(52) > :