From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 8CE3F385841B for ; Sat, 22 Jul 2023 06:05:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8CE3F385841B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-x331.google.com with SMTP id 46e09a7af769-6bb14c05d77so1089765a34.2 for ; Fri, 21 Jul 2023 23:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690005938; x=1690610738; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ICCPqEIuUOL+emo6girXvzuS7SnJD9yLopVw4oMtbfw=; b=PcJNgMi3pbQRohOUdXK/rh8H+OXEgemsXXIPEcSI78phyNwdQoBZjPmky7QA9aB3Ke 6cM927Y+4T8LECgD7iDto42hND59uQeaPtOM223XZDUvvW7RvWRSA/Ibl1vhYmRA78Al lRL2+byRmSIEXhnHVl2lhYjsiJKJUshpOgPKaSinWkPOpyzRO23JiJJ0Cd5aXFo/Jblb cyfqkvdiVz0Xd26kfhnM9t/NzJQpCgBwMxLpLi7phPfpjmJsB1D0hh8RuRYCI1RYOArA Jydk9sJoyPJ6h6gdeqdUjiPZAXvUuW1EJPBbvLwkwOTLM0iyayTshS9SfEGn4KeUwOx0 PucQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690005938; x=1690610738; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ICCPqEIuUOL+emo6girXvzuS7SnJD9yLopVw4oMtbfw=; b=OUlceDXQDs0hH+8P/RE2W5DTGfxqvVs49Dh4wFFS+qyjNlPXfnTAMS444pu5dNtNbl i5mYEDkichq4E1ItYCIbiavRaVAom11Yfm/ihp2ekaVZOsiDuedj7VKjrvQGqDjSYeiR Jh3wt7UDMcu/PV2HJS4sSaQz1OvXM4HnRrhWncMvXd/VC3+Q0nb+GjloShQrgfltReks O1nPeVh3UkCDsatCZ74yoAwh7xahgwLrhyYepPthXOweeYiKh2pBHTBgYs+Stwigor5i kozWz878xZy16KVQKiqKuDyTbcOdNcc2AxSektUoVMTR5qWZuybenCo725k8oU+jRKtc AiXg== X-Gm-Message-State: ABy/qLbFRKoiPjqaL1pM9VAOTMaLpCEHXCsL91/J5i7z9bKzJ14crGTY zLw5sKOz18hMAL3Qq5fvmOs= X-Google-Smtp-Source: APBJJlFxEcwZ0zcljXj5bKBNa0MxYkuioQbukar/mj6ymWRYVP/vTk7pEFCPFIj/KpEablZ9Xb/Sug== X-Received: by 2002:a05:6358:5295:b0:132:d3ea:f225 with SMTP id g21-20020a056358529500b00132d3eaf225mr3598253rwa.24.1690005937683; Fri, 21 Jul 2023 23:05:37 -0700 (PDT) Received: from [172.31.1.103] ([172.56.168.196]) by smtp.gmail.com with ESMTPSA id i14-20020a63bf4e000000b0054ff36967f7sm3766680pgo.54.2023.07.21.23.05.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jul 2023 23:05:37 -0700 (PDT) Message-ID: <01b43cf3-cf99-ab10-f86b-0219f119573d@gmail.com> Date: Sat, 22 Jul 2023 00:05:34 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2] RISC-V: optim const DF +0.0 store to mem [PR/110748] Content-Language: en-US To: Vineet Gupta , gcc-patches@gcc.gnu.org, Manolis Tsamis Cc: kito.cheng@gmail.com, Palmer Dabbelt , gnu-toolchain@rivosinc.com, Philipp Tomsich References: <20230721183035.2892020-1-vineetg@rivosinc.com> From: Jeff Law In-Reply-To: <20230721183035.2892020-1-vineetg@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/21/23 12:30, Vineet Gupta wrote: > Fixes: ef85d150b5963 ("RISC-V: Enable TARGET_SUPPORTS_WIDE_INT") > (gcc-13 regression) > > DF +0.0 is bitwise all zeros so int x0 store to mem can be used to optimize it. > > void zd(double *) { *d = 0.0; } > > currently: > > | fmv.d.x fa5,zero > | fsd fa5,0(a0) > | ret > > With patch > > | sd zero,0(a0) > | ret > > This came to light when testing the in-flight f-m-o patch where an ICE > was getting triggered due to lack of this pattern but turns out this > is an independent optimization of its own [1] > > [1] https://gcc.gnu.org/pipermail/gcc-patches/2023-July/624857.html > > Ran thru full multilib testsuite, there was 1 false failure due to > random string "lw" appearing in lto build assembler output, which is > also fixed in the patch. > > gcc/Changelog: > > PR target/110748 > * config/riscv/predicates.md (const_0_operand): Add back > const_double. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/pr110748-1.c: New Test. > * gcc.target/riscv/xtheadfmv-fmv.c: Add '\t' around test > patterns to avoid random string matches. OK jeff