From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tom@honermann.net>
Received: from smtp69.ord1c.emailsrvr.com (smtp69.ord1c.emailsrvr.com
 [108.166.43.69])
 by sourceware.org (Postfix) with ESMTPS id 532DD3858400
 for <gcc-patches@gcc.gnu.org>; Mon,  8 Aug 2022 13:45:51 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 532DD3858400
X-Auth-ID: tom@honermann.net
Received: by smtp17.relay.ord1c.emailsrvr.com (Authenticated sender:
 tom-AT-honermann.net) with ESMTPSA id 92AB9602C7; 
 Mon,  8 Aug 2022 09:45:49 -0400 (EDT)
Message-ID: <01b6ae2b-51b1-f5e9-53b9-b410b1bb7b26@honermann.net>
Date: Mon, 8 Aug 2022 09:45:48 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v4 2/2] preprocessor/106426: Treat u8 character literals
 as unsigned in char8_t modes.
Content-Language: en-US
To: Joseph Myers <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
References: <20220802183602.1575950-1-tom@honermann.net>
 <20220802183602.1575950-3-tom@honermann.net>
 <alpine.DEB.2.22.394.2208022210360.861046@digraph.polyomino.org.uk>
From: Tom Honermann <tom@honermann.net>
In-Reply-To: <alpine.DEB.2.22.394.2208022210360.861046@digraph.polyomino.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Classification-ID: b7795f31-7226-4087-bcb4-005b9cffe317-1-1
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Aug 2022 13:45:52 -0000

On 8/2/22 6:14 PM, Joseph Myers wrote:
> On Tue, 2 Aug 2022, Tom Honermann via Gcc-patches wrote:
>
>> This patch corrects handling of UTF-8 character literals in preprocessing
>> directives so that they are treated as unsigned types in char8_t enabled
>> C++ modes (C++17 with -fchar8_t or C++20 without -fno-char8_t). Previously,
>> UTF-8 character literals were always treated as having the same type as
>> ordinary character literals (signed or unsigned dependent on target or use
>> of the -fsigned-char or -funsigned char options).
> OK in the absence of C++ maintainer objections within 72 hours.  (This is
> the case where, when I added support for such literals for C (commit
> 7c5890cc0a0ecea0e88cc39e9fba6385fb579e61), I raised the question of
> whether they should be unsigned in the preprocessor for C++ as well.)

Joseph, would you be so kind as to commit this patch series for me? I 
don't have commit access. Thank you in advance!

Tom.