From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 7BC6B3858D28 for ; Wed, 26 Apr 2023 02:27:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BC6B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1a92369761cso52086345ad.3 for ; Tue, 25 Apr 2023 19:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682476041; x=1685068041; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kqOali9Ij/jTaNtyXfso+eKAdthsxd1ZIL8OJavgN8Q=; b=LEGMyMM58TOWQPnqnwxBXmWwW8mikt/LRlSFGpOS3Rg+trK00UVjKU6pgcMMh/pad2 4l68SnuO93O58Qb5ZDuzNCyQOQ51tzuLryM9IK/sp0bB2a+Rkmq8FlwYdrovRggZzR51 QV5B0nguZd5Vuo7LHhvEzFnHBIMuIP22btnQw0eoS6l7mUFPajazF0cRBHbFtUrRLttd kSR/g67+k7G3FXbwFmhtQl9aQaxw0Lka5HCbs1ySYAmjMNvPR+vhL7/bsr5fi0zT+wuD KnPnyZNNKrAJRjLoigjCWk/+oMvl9f+nv6Oy5CdUgbcP3n3t7cmD1zDRZKy+fSJYnmkK HmVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682476041; x=1685068041; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kqOali9Ij/jTaNtyXfso+eKAdthsxd1ZIL8OJavgN8Q=; b=dquc2ZJ2ESw9NmeQZr0fytFV1ANkvDPJY45Y2+7W+m9yXtOGLDU+9qKg7/6PFc12Ox IiWj+//XJxZllKFsXE4HPYs/KmAQ9CqSnwN/Z9ckwxcd0ZQedSyP1ne9a2KmfDV4MU40 n52RoIvXZ5+rb5i5Su98nwIM5VQxM7QxAeTmEv+lFAa2bTIimoDWakhWNGitufirPEPT ZQ7pcuq0xhhl6dv0yHSt/xIPPrsnqDOBb1p54lklGMHnlXm75mlHyQjeqOn+zcHDrHrF 8tuMP3j8wp1d97vlNdel8722ccArG2gqH+fE8kbP2iaNwJYfw6tyRHkln2VpA/wfRvx0 6/dQ== X-Gm-Message-State: AAQBX9fXbGnSbqoQB1BY6zBvHionapFH02OB7dFG9akxB1Rd5FtlPLeh bnCMifEOMqqqmtz+TN/7X/W0+J5HezY= X-Google-Smtp-Source: AKy350YgXVraDlKGSaGiE8TNxMyC4teaUJvI1NQcrZbO0BV7V5NNJHBCF487Knss4T2GgLm9+fLrIg== X-Received: by 2002:a17:902:d38c:b0:1a6:9794:a4 with SMTP id e12-20020a170902d38c00b001a6979400a4mr19419027pld.63.1682476041321; Tue, 25 Apr 2023 19:27:21 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id jd21-20020a170903261500b0019b0afc24e8sm8843718plb.250.2023.04.25.19.27.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Apr 2023 19:27:20 -0700 (PDT) Message-ID: <01c38548-7c08-a975-e9fb-a7d2d622168b@gmail.com> Date: Tue, 25 Apr 2023 20:27:19 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v7] RISCV: Inline subword atomic ops Content-Language: en-US To: Patrick O'Neill , gcc-patches@gcc.gnu.org Cc: palmer@rivosinc.com, kito.cheng@gmail.com, david.abd@gmail.com, schwab@linux-m68k.org References: <20230418163913.2429812-1-patrick@rivosinc.com> <20230418214124.2446642-1-patrick@rivosinc.com> <93c82943-0d8d-b98a-cb07-13555fb26cf0@rivosinc.com> From: Jeff Law In-Reply-To: <93c82943-0d8d-b98a-cb07-13555fb26cf0@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/25/23 09:20, Patrick O'Neill wrote: > On 4/24/23 22:52, Jeff Law wrote: > >> >> On 4/18/23 15:41, Patrick O'Neill wrote: >>> RISC-V has no support for subword atomic operations; code currently >>> generates libatomic library calls. >>> >>> This patch changes the default behavior to inline subword atomic calls >>> (using the same logic as the existing library call). >>> Behavior can be specified using the -minline-atomics and >>> -mno-inline-atomics command line flags. >>> >>> gcc/libgcc/config/riscv/atomic.c has the same logic implemented in asm. >>> This will need to stay for backwards compatibility and the >>> -mno-inline-atomics flag. >>> >>> 2023-04-18 Patrick O'Neill >>> >>>     PR target/104338 >>>     * riscv-protos.h: Add helper function stubs. >>>     * riscv.cc: Add helper functions for subword masking. >>>     * riscv.opt: Add command-line flag. >>>     * sync.md: Add masking logic and inline asm for fetch_and_op, >>>     fetch_and_nand, CAS, and exchange ops. >>>     * invoke.texi: Add blurb regarding command-line flag. >>>     * inline-atomics-1.c: New test. >>>     * inline-atomics-2.c: Likewise. >>>     * inline-atomics-3.c: Likewise. >>>     * inline-atomics-4.c: Likewise. >>>     * inline-atomics-5.c: Likewise. >>>     * inline-atomics-6.c: Likewise. >>>     * inline-atomics-7.c: Likewise. >>>     * inline-atomics-8.c: Likewise. >>>     * atomic.c: Add reference to duplicate logic. >> This is OK for the trunk.  I think the only question is whether or not >> you're going to contribute to GCC regularly.  If so, we should go >> ahead and get you write access so you can commit ACK's changes.  If >> you're not going to be making regular contributions, then I can go >> ahead and commit it for you. >> >> Jeff > > I should be contributing regularly, so write access would be great. > > Is this the correct form? > https://sourceware.org/cgi-bin/pdw/ps_form.cgi It is and I've already pushed the ACK button on my side. So we're just waiting for an admin to push the buttons on his side to make the account. jeff