From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from server.nextmovesoftware.com (server.nextmovesoftware.com [162.254.253.69]) by sourceware.org (Postfix) with ESMTPS id 6230D385800D for ; Thu, 11 Jan 2024 15:55:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6230D385800D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nextmovesoftware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nextmovesoftware.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6230D385800D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=162.254.253.69 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704988549; cv=none; b=CKnwFKTD+tWkkDgUa2rO8lBtusqsOvreNnzajkA62qbyD9QpDhUnUWXyJsETjggztMIMnY1z1o9qtKBhZKFW/Is0MUM9DStNveeek0YA2xMBELpc0w5vEFY843c0FffvmLvl3TqWPYe3TCnTy/8nxla1ugcderoQkpVpduNDXTU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704988549; c=relaxed/simple; bh=pPb8sgLlysHjsRt8Sg31b+7CCB/u53wESB+pXisfLds=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=InMfWFPAKz3HRyIMPjiZVrrzQYRCCaFP1IMGu8danM6OVDyJSQC5q+Ww43Id39ipRMGfSh0dOGcJ3Bd0gSIO5OGkcjuKNlQOYy/zr5ssfs2IbPgnejGU1gJQ93iN/ew1XLmD3y1Olr4dFuuGLI2mP6dgTnuasMnYQditsXFxlwE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nextmovesoftware.com; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:In-Reply-To:References:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YZX5WqJY2yQBhpDdiDEmxlS+nZl/LAgUWWh0xbByEcM=; b=Bv8I72L47jhE9LRtVa6TiCJ3i7 oht7L0OMDmC7QokfPPj4ZVuCsLkyXQSrKwtR9NZThYOibJVNyukxp3tnlhKyveDL4lde+G87KEOJH SKpKRU5IH/WIJV151YTM7c5p0hshHSCtruCkFbaAWRzc0FWDsTnLlGd6zpNe91VGH8sXQlbOvq9D5 xTTdEIIWsJoaMTQOC1/95WVO4wduVFA/xHYQYCZzoSEbjC4yx7cwihqBmBNBaMiX+NdmWik+MxdFB Ur1MG04NqpzSYFWxgIdS23/Mh/dN78zhkmfjKa9JOuku0xrtGxIf1uCCq+/yNT+ZmcwS8NKOmW4JS 7CbsLVpw==; Received: from [185.62.158.67] (port=54856 helo=Dell) by server.nextmovesoftware.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rNxPG-00039R-26; Thu, 11 Jan 2024 10:55:46 -0500 From: "Roger Sayle" To: "'Richard Earnshaw'" Cc: References: <00e701da424c$c8bb0b60$5a312220$@nextmovesoftware.com> In-Reply-To: Subject: RE: [libatomic PATCH] Fix testsuite regressions on ARM [raspberry pi]. Date: Thu, 11 Jan 2024 15:55:46 -0000 Message-ID: <01c701da44a6$a4a86450$edf92cf0$@nextmovesoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIdB5xmqloTRoIASJROikOF0nzVpAE3az0ysEV4woA= Content-Language: en-gb X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.nextmovesoftware.com X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - nextmovesoftware.com X-Get-Message-Sender-Via: server.nextmovesoftware.com: authenticated_id: roger@nextmovesoftware.com X-Authenticated-Sender: server.nextmovesoftware.com: roger@nextmovesoftware.com X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Richard, As you've recommended, this issue has now been filed in bugzilla as PR other/113336. As explained in the new PR, libatomic's testsuite used to pass on armv6 (raspberry pi) in previous GCC releases, but the code was incorrect/non-synchronous; this was reported as PR target/107567 and PR target/109166. Now that those issues have been fixed, we now see that there's a missing dependency in libatomic that's required to implement this functionality correctly. I'm more convinced that my fix is correct, but it's perhaps a little disappointing that libatomic doesn't have a (multi-threaded) run-time test to search for race conditions, and confirm its implementations are correctly serializing. Please let me know what you think. Best regards, Roger -- > -----Original Message----- > From: Richard Earnshaw > Sent: 10 January 2024 15:34 > To: Roger Sayle ; gcc-patches@gcc.gnu.org > Subject: Re: [libatomic PATCH] Fix testsuite regressions on ARM = [raspberry pi]. >=20 >=20 >=20 > On 08/01/2024 16:07, Roger Sayle wrote: > > > > Bootstrapping GCC on arm-linux-gnueabihf with --with-arch=3Darmv6 > > currently has a large number of FAILs in libatomic (regressions = since > > last time I attempted this). The failure mode is related to IFUNC > > handling with the file tas_8_2_.o containing an unresolved reference > > to the function libat_test_and_set_1_i2. > > > > Bearing in mind I've no idea what's going on, the following one line > > change, to build tas_1_2_.o when building tas_8_2_.o, resolves the > > problem for me and restores the libatomic testsuite to 44 expected > > passes and 5 unsupported tests [from 22 unexpected failures and 22 = unresolved > testcases]. > > > > If this looks like the correct fix, I'm not confident with = rebuilding > > Makefile.in with correct version of automake, so I'd very much > > appreciate it if someone/the reviewer/mainainer could please check = this in for > me. > > Thanks in advance. > > > > > > 2024-01-08 Roger Sayle > > > > libatomic/ChangeLog > > * Makefile.am: Build tas_1_2_.o on ARCH_ARM_LINUX > > * Makefile.in: Regenerate. > > > > > > Roger > > -- > > >=20 > Hi Roger, >=20 > I don't really understand all this make foo :( so I'm not sure if this = is the right fix > either. If this is, as you say, a regression, have you been able to = track down when > it first started to occur? That might also help me to understand what = changed to > cause this. >=20 > Perhaps we should have a PR for this, to make tracking the fixes = easier. >=20 > R.