From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123254 invoked by alias); 27 Jul 2018 07:31:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117503 invoked by uid 89); 27 Jul 2018 07:30:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=H*i:sk:f1403d7, H*f:sk:f1403d7, HContent-Transfer-Encoding:8bit X-HELO: cc-smtpout2.netcologne.de Received: from cc-smtpout2.netcologne.de (HELO cc-smtpout2.netcologne.de) (89.1.8.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Jul 2018 07:30:05 +0000 Received: from cc-smtpin3.netcologne.de (cc-smtpin3.netcologne.de [89.1.8.203]) by cc-smtpout2.netcologne.de (Postfix) with ESMTP id 5158412B2D; Fri, 27 Jul 2018 09:30:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=netcologne.de; s=nc1116a; t=1532676603; bh=4vQqB+kfSH68qgQSpOYM5sw+JxdzWPQwknKTyuZTEP4=; h=Subject:To:Cc:References:From:Message-ID:Date:In-Reply-To:From; b=ETLgUZbUgqHKcgajMdo9hLbwsLny6yzB0nPWiZUYYpbjPgzXvisNwSL7v6KnqzCKP 216QWs3Au2qQyGtqoRA0XhQySB5jUB9euJCIlcltKsgpuvAcdVZvyjANhC4pxW51vf ZM5DjSnc+z2eBVUYqotW08RVeOK2IWLycnumbIPhdcG606b46IjLAGWGRpunr5bCyb AFiX7a9IgMa1QQmmWIAK2xULUkwyATiFl+hlReAZ6p74Jv5QUgKlkK0b7bjQ8V7gpa PCrSnp2l3GeLdELucqBO50ux862R/DAlLx6zwrmkQ5ErpeqYhTQlLFZj7JI30ypfm5 pYZd02C/Ru/3w== Received: from localhost (localhost [127.0.0.1]) by cc-smtpin3.netcologne.de (Postfix) with ESMTP id 4D04C11EC5; Fri, 27 Jul 2018 09:30:03 +0200 (CEST) Received: from [78.35.138.175] (helo=cc-smtpin3.netcologne.de) by localhost with ESMTP (eXpurgate 4.6.0) (envelope-from ) id 5b5ac9fb-0bea-7f0000012729-7f000001a144-1 for ; Fri, 27 Jul 2018 09:30:03 +0200 Received: from [192.168.178.68] (xdsl-78-35-138-175.netcologne.de [78.35.138.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by cc-smtpin3.netcologne.de (Postfix) with ESMTPSA; Fri, 27 Jul 2018 09:29:57 +0200 (CEST) Subject: Re: Build fail on gthr-simple.h targets (Re: AsyncI/O patch committed) To: Ulrich Weigand , Nicolas Koenig Cc: gfortran , gcc-patches@gcc.gnu.org, dje.gcc@gmail.com References: <20180726133142.DE075D801C7@oc3748833570.ibm.com> From: Thomas Koenig Message-ID: <01cd923e-18c7-f745-a75d-49536d56cdbf@netcologne.de> Date: Fri, 27 Jul 2018 07:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2018-07/txt/msg01697.txt.bz2 Am 26.07.2018 um 22:54 schrieb Thomas Koenig: > Hi Ulrich, > >> The problem is that io/asynch.h unconditionally uses a couple of >> features that are not provided by gthr-simplex, in particular >>    __gthread_cond_t >> and >>    __gthread_equal / __gthread_self >> >> According to the documentation in gthr.h, the former is only available >> if __GTHREAD_HAS_COND is defined, and the latter are only available if >> __GTHREADS_CXX0X is defined.  Neither is true for gthr-simple.h. > > Thanks for the analysis, and the pointer to the macros. > > Because the functionality depends on these features, it is best to > remove them if it is not present. So, here is a patch which does > just that. > > This was reg-tested on Linux, which showed that the functionality is > still there. I tried bootstrapping on AIX on gcc119, but this failed > due to an unrelated issue (problem with compiling the inline > libraries). > OK, this does not work. We have found a method of checking on Linux, and this does not work. We have also found a way of working in the next couple of days, so expect an update in one or two days. If that is too much time, feel free to revert the async patch in the meantime. Regards Thomas