From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 7FD0A3858D28 for ; Tue, 2 Apr 2024 01:09:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7FD0A3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7FD0A3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712020203; cv=none; b=DifPAaH52G4x1om22E2eoxxwG9a6CsUSVaCXyu4eUf++0z2PFufQOLitAmdZoJndP2mXSynGLPSM0ouxhN0yFBh9OaTzEs6iHk4MBfVCbuXoU92KOBbO4yNxDXwwaKrmvXB8zOAPdrWuDp5tVqyg32svR1NOWrbTvlCAMU+ys8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712020203; c=relaxed/simple; bh=9XWmejnsnm5nvodzhs7ow3LmXjsvuS8OhvR2x3UQp2o=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=xxDm0bbQX1YEdPKOfiXUMNjEG/YPcObUNRcm8xUS+EY+FgD4kkxqQDASC3VmLQ8CzlD4YG4sWNJubHW9fqfMGs6xm4ytOQMvozo/wVfW48d0FXFJgO4m/zgSIUU98YPdwVyVJ4+BXku1Wp6221JPvj88A/YOVokpu8YmiFCKHx8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.20.4.107]) by gateway (Coremail) with SMTP id _____8AxuujgWgtmqSYiAA--.58678S3; Tue, 02 Apr 2024 09:09:52 +0800 (CST) Received: from [10.20.4.107] (unknown [10.20.4.107]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxPBPeWgtmxztxAA--.22806S3; Tue, 02 Apr 2024 09:09:50 +0800 (CST) Subject: Re: [PATCH v5] LoongArch: Add support for TLS descriptors To: Xi Ruoyao , mengqinggang , gcc-patches@gcc.gnu.org Cc: xuchenghua@loongson.cn, cailulu@loongson.cn, i.swmail@xen0n.name, maskray@google.com, luweining@loongson.cn, wanglei@loongson.cn, hejinyang@loongson.cn References: <20240319015415.351293-1-mengqinggang@loongson.cn> <84becac336d760701ec31f0f27e64c82efacc9f4.camel@xry111.site> From: chenglulu Message-ID: <01df8521-9bd9-2650-52ff-9b398d4b57b9@loongson.cn> Date: Tue, 2 Apr 2024 09:09:50 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <84becac336d760701ec31f0f27e64c82efacc9f4.camel@xry111.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8DxPBPeWgtmxztxAA--.22806S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoWxAw1DGFyrAF43GF1UGryfuFX_yoWrXFW5pr ZrZwnrKF4rGrZ5Cr1kXa4SvF1vqFZrKr42q3W3t3yfGr47XryFvF1ktasIgF17Ja1kJrWj qF1rZa47XF47JacCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUv0b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Gr0_Gr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1l5I 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AK xVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzV AYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU8czVUUU UUU== X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2024/4/1 下午9:51, Xi Ruoyao 写道: > Is this patch targeting GCC 14 or 15? If 14 I guess we'd commit now... > > Generally we don't add features in stage 4, but if we keep trad as the > default I think it'd be OK. And RISC-V guys plan to push their TLS desc > implementation this week too. I've rebase the code to the latest commit, and if the test is okay I'll bring it up right away. Thanks!:-) > > On Tue, 2024-03-19 at 09:54 +0800, mengqinggang wrote: >> Add support for TLS descriptors on normal code model and extreme code model. >> >> Normal code model instruction sequence: >>   -mno-explicit-relocs: >>     la.tls.desc $r4, s >>     add.d $r12, $r4, $r2 >>   -mexplicit-relocs: >>     pcalau12i $r4,%desc_pc_hi20(s) >>     addi.d $r4,$r4,%desc_pc_lo12(s) >>     ld.d $r1,$r4,%desc_ld(s) >>     jirl $r1,$r1,%desc_call(s) >>     add.d $r12, $r4, $r2 >> >> Extreme code model instruction sequence: >>   -mno-explicit-relocs: >>     la.tls.desc $r4, $r12, s >>     add.d $r12, $r4, $r2 >>   -mexplicit-relocs: >>     pcalau12i $r4,%desc_pc_hi20(s) >>     addi.d $r12,$r0,%desc_pc_lo12(s) >>     lu32i.d $r12,%desc64_pc_lo20(s) >>     lu52i.d $r12,$r12,%desc64_pc_hi12(s) >>     add.d $r4,$r4,$r12 >>     ld.d $r1,$r4,%desc_ld(s) >>     jirl $r1,$r1,%desc_call(s) >>     add.d $r12, $r4, $r2 >> >> The default is still traditional TLS model, but can be configured with >> --with-tls={trad,desc}. The default can change to TLS descriptors once >> libc and LLVM support this. >> >> gcc/ChangeLog: >> >> * config.gcc: Add --with-tls option to change TLS flavor. >> * config/loongarch/genopts/loongarch.opt.in: Add -mtls-dialect to >> configure TLS flavor. >> * config/loongarch/loongarch-def.h (struct loongarch_target): Add >> tls_dialect. >> * config/loongarch/loongarch-driver.cc (la_driver_init): Add tls >> flavor. >> * config/loongarch/loongarch-opts.cc (loongarch_init_target): Add >> tls_dialect. >> (loongarch_config_target): Ditto. >> (loongarch_update_gcc_opt_status): Ditto. >> * config/loongarch/loongarch-opts.h (loongarch_init_target):Ditto. >> (TARGET_TLS_DESC): New define. >> * config/loongarch/loongarch.cc (loongarch_symbol_insns): Add TLS DESC >> instructions sequence length. >> (loongarch_legitimize_tls_address): New TLS DESC instruction sequence. >> (loongarch_option_override_internal): Add la_opt_tls_dialect. >> (loongarch_option_restore): Add la_target.tls_dialect. >> * config/loongarch/loongarch.md (@got_load_tls_desc): Normal >> code model for TLS DESC. >> (got_load_tls_desc_off64): Extreme code model for TLS DESC. >> * config/loongarch/loongarch.opt: Regenerated. >> >> gcc/testsuite/ChangeLog: >> >> * gcc.target/loongarch/cmodel-extreme-1.c: Add -mtls-dialect=trad. >> * gcc.target/loongarch/cmodel-extreme-2.c: Ditto. >> * gcc.target/loongarch/explicit-relocs-auto-tls-ld-gd.c: Ditto. >> * gcc.target/loongarch/explicit-relocs-medium-call36-auto-tls-ld-gd.c: >> Ditto. >> * gcc.target/loongarch/func-call-medium-1.c: Ditto. >> * gcc.target/loongarch/func-call-medium-2.c: Ditto. >> * gcc.target/loongarch/func-call-medium-3.c: Ditto. >> * gcc.target/loongarch/func-call-medium-4.c: Ditto. >> * gcc.target/loongarch/tls-extreme-macro.c: Ditto. >> * gcc.target/loongarch/tls-gd-noplt.c: Ditto. >> * gcc.target/loongarch/explicit-relocs-auto-extreme-tls-desc.c: New test. >> * gcc.target/loongarch/explicit-relocs-auto-tls-desc.c: New test. >> * gcc.target/loongarch/explicit-relocs-extreme-tls-desc.c: New test. >> * gcc.target/loongarch/explicit-relocs-tls-desc.c: New test. >> >> Co-authored-by: Lulu Cheng >> Co-authored-by: Xi Ruoyao