From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) by sourceware.org (Postfix) with ESMTPS id BFE4C3858402 for ; Mon, 13 May 2024 12:36:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BFE4C3858402 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=disroot.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BFE4C3858402 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=178.21.23.139 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715603782; cv=none; b=YYhOaBXROBaGI3GLqJoKTf8VaN1+Mg5wKK+Bd8KqSdjvZee7HyanHByZa+2y9MeRlWzN176LvQO999CAK0qdXpY0HplYybsrhdYzBSiQuDaZ2s3hILhqfTH+J+aiOSc1p3B0+EpqckGYzO7zJRELqwtD7pmIMFu2SBWL9epoBYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715603782; c=relaxed/simple; bh=o5qMl9sNqz1r9ivHHG/18BHd3D2+uFD1gT6KQpvpA6A=; h=Date:DKIM-Signature:From:To:Message-ID:Subject:MIME-Version; b=JQB909x//lRgcC7Hxd4lbgKIjjazj7Mx3X8OoP6BseLMxxcT5YsaWFgHPQZxWve7PHNC75ey5vL3agzUEVxDTBWFyHAxpdiIpY3lCORWJVcH1xd+7yERgg8GyUwWYoffzUblvSnQhbi2lPNEWi6poq+j9XvlN2yx+a09/pzBYtM= ARC-Authentication-Results: i=1; server2.sourceware.org X-Virus-Scanned: SPAM Filter at disroot.org Date: Mon, 13 May 2024 13:36:17 +0100 (GMT+01:00) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1715603778; bh=o5qMl9sNqz1r9ivHHG/18BHd3D2+uFD1gT6KQpvpA6A=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=lndVMWvj9zI/WVcYJRCSehfxxaxleysXmxz3qtLXf6dwy8jAgF6ojYOksNpyiVRM5 oV85Rlid49yNm417sn1gA/YEIl8tmY0x3Zqhd+NrYrHsP7jY/TXEwkHH2ZFDsKKETE mUtXtxDT17U602n0NClFFwvYhq4POQY+xR67sX/N7e95I6Aw8R8753zIWv6ktWaoSH Rhn/D9DD/5X4Ed5lLh6MTaePSyCRupJS5Q28UtO4V6KJFE3xkpLUdl/XdERyFFVplc vYEHkpj5pFGCWIrIf4LKPPqMCt9sVEYDWWrjMQH1IIFmMEpSdZNqAy0crnkNJjHFVI tKBUhd3ctsU3A== From: Peter0x44 To: NightStrike Cc: gcc-patches@gcc.gnu.org, lh_mouse@126.com, pexu@pexu.org Message-ID: <024e9705-4ba0-4f8f-a0f9-d7ce8b55a385@disroot.org> In-Reply-To: References: <20240509170157.8534-1-peter0x44@disroot.org> <20240509170157.8534-2-peter0x44@disroot.org> Subject: Re: [PATCH v2 2/3] diagnostics: Don't hardcode auto_enable_urls to false for mingw hosts MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <024e9705-4ba0-4f8f-a0f9-d7ce8b55a385@disroot.org> X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 13 May 2024 1:30:28 pm NightStrike : > On Thu, May 9, 2024 at 1:03=E2=80=AFPM Peter Damianov =20 > wrote: >> >> Windows terminal and mintty both have support for link escape=20 >> sequences, and so >> auto_enable_urls shouldn't be hardcoded to false. For older versions=20 >> of the >> windows console, mingw_ansi_fputs's console API translation logic does= =20 >> mangle >> these sequences, but there's nothing useful it could do even if this=20 >> weren't >> the case, so check if the ansi escape sequences are supported at all. >> >> conhost.exe doesn't support link escape sequences, but printing them=20 >> does not >> cause any problems. > > Are there any issues when running under the Wine console, such as when > running the testsuite? I did not try this. There shouldn't be problems if wine implements=20 ENABLE_VIRTUAL_TERMINAL_PROCESSING correctly, but I agree it would be=20 good to check. Are there instructions anywhere for running the testsuite=20 with wine? Anything specific I need to do?