From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id E7578385781F; Wed, 16 Mar 2022 13:06:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E7578385781F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.90,186,1643702400"; d="diff'?scan'208";a="73193648" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 16 Mar 2022 05:06:26 -0800 IronPort-SDR: aC/ggcGGOOHtEAi71Q2Mq1VJqvlfnz7EVi1A9WY8TVBzDsD+vDccJD4IRPcHohPDTXT7UxLd5o 8sGang3eixG/RWpct4Uqzsq3cVzmb6lpbGODwizBxs0dPk3MlTUKcLfk5kTgDBL/v6n+Dogn9b n6drf65L+XUTPjRCRDn2fFJ+vXnpuAJWVKa58/xP6vIU7M/xByGIqiktkppbeKDTf4LXGBlinO XmemqUacYZeFYLJ8zukONzvVqAaxhrx6IzM9Vc0dohLSQvwp9L9AiD/qmtZJOT48VDnvDryZCX Q9w= Content-Type: multipart/mixed; boundary="------------UA6t9oYf2Phlc56sILS62dxJ" Message-ID: <02535b12-184f-02ff-ea02-becd75c5a097@codesourcery.com> Date: Wed, 16 Mar 2022 14:06:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] OpenMP, Fortran: Bugfix for omp_set_num_teams. To: Jakub Jelinek , , References: <498625bc-2ca0-8f5e-89df-03453a2c96a8@codesourcery.com> From: Marcel Vollweiler In-Reply-To: X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 13:06:28 -0000 --------------UA6t9oYf2Phlc56sILS62dxJ Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Hi Jakub, > ! { dg-do run } > ! { dg-additional-options "-fdefault-integer-8" } > > program set_num_teams_8 > use omp_lib > omp_set_num_teams (42) > if (omp_get_num_teams () .ne. 42) stop 1 > end program I modified your suggested test case a bit: program set_num_teams_8 use omp_lib use, intrinsic :: iso_fortran_env integer(int64) :: x x =3D 42 call omp_set_num_teams (x) if (omp_get_max_teams () .ne. 42) stop 1 end program I tested it with/without the fix and the test passed/failed as expected. Hope, that's ok? Marcel ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------UA6t9oYf2Phlc56sILS62dxJ Content-Type: text/plain; charset="UTF-8"; name="omp-set-num-teams-bugfix.diff" Content-Disposition: attachment; filename="omp-set-num-teams-bugfix.diff" Content-Transfer-Encoding: base64 T3Blbk1QLCBGb3J0cmFuOiBCdWdmaXggZm9yIG9tcF9zZXRfbnVtX3RlYW1zLgoKVGhpcyBw YXRjaCBmaXhlcyBhIHNtYWxsIGJ1ZyBpbiB0aGUgb21wX3NldF9udW1fdGVhbXMgaW1wbGVt ZW50YXRpb24uCgpsaWJnb21wL0NoYW5nZUxvZzoKCgkqIGZvcnRyYW4uYyAob21wX3NldF9u dW1fdGVhbXNfOF8pOiBGaXggYnVnLgoJKiB0ZXN0c3VpdGUvbGliZ29tcC5mb3J0cmFuL2lj di04LmY5MDogTmV3IHRlc3QuCgpkaWZmIC0tZ2l0IGEvbGliZ29tcC9mb3J0cmFuLmMgYi9s aWJnb21wL2ZvcnRyYW4uYwppbmRleCA4YzFjZmQxLi5kOTg0Y2U1IDEwMDY0NAotLS0gYS9s aWJnb21wL2ZvcnRyYW4uYworKysgYi9saWJnb21wL2ZvcnRyYW4uYwpAQCAtNDkxLDcgKzQ5 MSw3IEBAIG9tcF9zZXRfbnVtX3RlYW1zXyAoY29uc3QgaW50MzJfdCAqbnVtX3RlYW1zKQog dm9pZAogb21wX3NldF9udW1fdGVhbXNfOF8gKGNvbnN0IGludDY0X3QgKm51bV90ZWFtcykK IHsKLSAgb21wX3NldF9tYXhfYWN0aXZlX2xldmVscyAoVE9fSU5UICgqbnVtX3RlYW1zKSk7 CisgIG9tcF9zZXRfbnVtX3RlYW1zIChUT19JTlQgKCpudW1fdGVhbXMpKTsKIH0KIAogaW50 MzJfdApkaWZmIC0tZ2l0IGEvbGliZ29tcC90ZXN0c3VpdGUvbGliZ29tcC5mb3J0cmFuL2lj di04LmY5MCBiL2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdvbXAuZm9ydHJhbi9pY3YtOC5mOTAK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uOTQ3OGMxNQotLS0gL2Rldi9u dWxsCisrKyBiL2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdvbXAuZm9ydHJhbi9pY3YtOC5mOTAK QEAgLTAsMCArMSwxMCBAQAorISBUaGlzIHRlc3RzICdzZXRfbnVtX3RlYW1zXzgnIGZ1bmN0 aW9uLgorCitwcm9ncmFtIHNldF9udW1fdGVhbXNfOAorICB1c2Ugb21wX2xpYgorICB1c2Us IGludHJpbnNpYyA6OiBpc29fZm9ydHJhbl9lbnYKKyAgaW50ZWdlcihpbnQ2NCkgOjogeAor ICB4ID0gNDIKKyAgY2FsbCBvbXBfc2V0X251bV90ZWFtcyAoeCkKKyAgaWYgKG9tcF9nZXRf bWF4X3RlYW1zICgpIC5uZS4gNDIpIHN0b3AgMQorZW5kIHByb2dyYW0K --------------UA6t9oYf2Phlc56sILS62dxJ--