From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by sourceware.org (Postfix) with ESMTPS id 265D4385840B for ; Sat, 29 Oct 2022 03:35:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 265D4385840B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1030.google.com with SMTP id m2so6183770pjr.3 for ; Fri, 28 Oct 2022 20:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=j8jOnLPyZWma8wJ6b/3dxUMmn3jOR8GAcvjqqeeufxE=; b=JjVKoJsNxIm0tLZ1r5zLHVUrGgWld8Tv6IaDmIzPg5WTp/slnE9S9vYxHFPKdsIs97 zq/gGarujLclk3qNwbGJi9vr17VKIhSvDUXbOPInVK9NBPH0Vv8XpmTQy4YUC6dn6XP8 kfhXxKysWdajcC8dQgC9hoILus3Zm8AJ1MDGL/mn9J0IbKUOs8/1gr7/lqwkhik8p7bU KotSo7tN4BrGderrCVc8Kli6furCBpdl2+Xrfi5EvFcT/kIaykDh4rrHTtegW6o5n4hw QIw14X+wCuHydtHP93FPRRAaqi5ckO641+G+sWIXQz2w5I+o+/6xszjiYkr8EMfXNG1o T0kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j8jOnLPyZWma8wJ6b/3dxUMmn3jOR8GAcvjqqeeufxE=; b=4wFfuqbxikqsk9ZShru/ppvAMu/H1lmTkSWuUX/IjufvJN7R9egbojVxPw5p9ljsJm KqJXHBTS9Q/KInNDe9AewjHF5CCYat5uekM2fOIopHQc+xDhvjYuPCjYnZqht89YM6Od N3hi2OAzkuXmsD8u4xU4fS5MvfrpiCq4togw38gWidQjyvJ2ZEPWcW4kquU7htGPGBzK HHE4w+wAKk2gs1GUO1jDTKqPez5esXGqPLJST1HQGm6F0Xt56YBUfzLNIyt2H/1ye3Hp yqVbzxZaZp5AQBHVVGrz+s16ZxnisK690p2FjRAhMxZcERPnvRveOnwk9WF51dT1GSRX 8G5A== X-Gm-Message-State: ACrzQf1B6lTWcR/DJCaOns655dFVpz96LCI4yGLwuMkRgkKOe4gpenMm 4dFgKoy5IHH/L//ojMAL5O4nGJJilYU= X-Google-Smtp-Source: AMsMyM6BWChqjwIo/H4lw0ris4zixgxyTa7gN6Th2a0iq3gDNZ1jKkUeB8ttrrHSld42OGXdcFi/9g== X-Received: by 2002:a17:902:d54c:b0:186:c092:97db with SMTP id z12-20020a170902d54c00b00186c09297dbmr2410041plf.28.1667014550987; Fri, 28 Oct 2022 20:35:50 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id u15-20020a170903124f00b00186c41bd213sm202270plh.177.2022.10.28.20.35.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Oct 2022 20:35:49 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------hBHcmJnyGL5JdRyl1mWl34Te" Message-ID: <025493a0-2924-a05c-7d1f-3bbe8c24b5dc@gmail.com> Date: Fri, 28 Oct 2022 21:35:48 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [committed] More infrastructure to avoid bogus RTL on H8 Content-Language: en-US To: Jan-Benedict Glaw Cc: "gcc-patches@gcc.gnu.org" References: <3aa2cc41-0ad2-e106-56d4-f839ae2c1078@gmail.com> <20221025195906.rk5wx6ttpwohwn4p@lug-owl.de> From: Jeff Law In-Reply-To: <20221025195906.rk5wx6ttpwohwn4p@lug-owl.de> X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------hBHcmJnyGL5JdRyl1mWl34Te Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/25/22 13:59, Jan-Benedict Glaw wrote: > Hi Jeff! > > On Mon, 2022-10-17 17:47:16 -0600, Jeff Law via Gcc-patches wrote: >> --- a/gcc/config/h8300/h8300.cc >> +++ b/gcc/config/h8300/h8300.cc >> @@ -5531,6 +5531,32 @@ h8300_ok_for_sibcall_p (tree fndecl, tree) >> >> return 1; >> } >> + >> +/* Return TRUE if OP is a PRE_INC or PRE_DEC >> + instruction using REG, FALSE otherwise. */ >> + >> +bool >> +pre_incdec_with_reg (rtx op, int reg) >> +{ >> + /* OP must be a MEM. */ >> + if (GET_CODE (op) != MEM) >> + return false; >> + >> + /* The address must be a PRE_INC or PRE_DEC. */ >> + op = XEXP (op, 0); >> + if (GET_CODE (op) != PRE_DEC && GET_CODE (op) != PRE_INC) >> + return false; >> + >> + /* It must be a register that is being incremented >> + or decremented. */ >> + op = XEXP (op, 0); >> + if (!REG_P (op)) >> + return false; >> + >> + /* Finally, check that the register number matches. */ >> + return REGNO (op) == reg; > This results in a new signed-vs-unsigned warning for me: > > [all 2022-10-25 00:41:11] ../../gcc/gcc/config/h8300/h8300.cc: In function 'bool pre_incdec_with_reg(rtx, int)': > [all 2022-10-25 00:41:11] ../../gcc/gcc/config/h8300/h8300.cc:5557:21: error: comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Werror=sign-compare] > [all 2022-10-25 00:41:11] 5557 | return REGNO (op) == reg; Fixed via the attached patch.  Thanks for pointing it out. jeff --------------hBHcmJnyGL5JdRyl1mWl34Te Content-Type: text/plain; charset=UTF-8; name="P" Content-Disposition: attachment; filename="P" Content-Transfer-Encoding: base64 Y29tbWl0IDcyNGQzZjkyNmI5NDY3MmRlOTYwZGJlODhmYjY5OWJiZGQ3ZmRlOTcKQXV0aG9y OiBKZWZmIExhdyA8amVmZnJleWFsYXdAZ21haWwuY29tPgpEYXRlOiAgIEZyaSBPY3QgMjgg MjM6MzM6MDYgMjAyMiAtMDQwMAoKICAgIEZpeCBzaWduZWQgdnMgdW5zaWduZWQgaXNzdWUg aW4gSDggcG9ydAogICAgCiAgICBnY2MvCiAgICAgICAgICAgICogY29uZmlnL2g4MzAwL2g4 MzAwLmNjIChwcmVfaW5jZGVjX3dpdGhfcmVnKTogTWFrZSByZWcgYXJndW1lbnQKICAgICAg ICAgICAgYW4gdW5zaWduZWQgaW50CiAgICAgICAgICAgICogY29uZmlnL2g4MzAwL2g4MzAw LXByb3Rvcy5oIChwcmVfaW5jZGVjX3dpdGhfcmVnKTogQWRqdXN0IHByb3RvdHlwZS4KCmRp ZmYgLS1naXQgYS9nY2MvY29uZmlnL2g4MzAwL2g4MzAwLXByb3Rvcy5oIGIvZ2NjL2NvbmZp Zy9oODMwMC9oODMwMC1wcm90b3MuaAppbmRleCA4Yzk4OTQ5NWMyOS4uNzdhZGZhYmEwN2Ig MTAwNjQ0Ci0tLSBhL2djYy9jb25maWcvaDgzMDAvaDgzMDAtcHJvdG9zLmgKKysrIGIvZ2Nj L2NvbmZpZy9oODMwMC9oODMwMC1wcm90b3MuaApAQCAtMTAwLDcgKzEwMCw3IEBAIGV4dGVy biBpbnQgaDgzMDBfaW5pdGlhbF9lbGltaW5hdGlvbl9vZmZzZXQgKGludCwgaW50KTsKIGV4 dGVybiBpbnQgaDgzMDBfcmVnc19va19mb3Jfc3RtIChpbnQsIHJ0eFtdKTsKIGV4dGVybiBp bnQgaDgzMDBfaGFyZF9yZWdub19yZW5hbWVfb2sgKHVuc2lnbmVkIGludCwgdW5zaWduZWQg aW50KTsKIGV4dGVybiBib29sIGg4MzAwX21vdmVfb2sgKHJ0eCwgcnR4KTsKLWV4dGVybiBi b29sIHByZV9pbmNkZWNfd2l0aF9yZWcgKHJ0eCwgaW50KTsKK2V4dGVybiBib29sIHByZV9p bmNkZWNfd2l0aF9yZWcgKHJ0eCwgdW5zaWduZWQgaW50KTsKIAogc3RydWN0IGNwcF9yZWFk ZXI7CiBleHRlcm4gdm9pZCBoODMwMF9wcl9pbnRlcnJ1cHQgKHN0cnVjdCBjcHBfcmVhZGVy ICopOwpkaWZmIC0tZ2l0IGEvZ2NjL2NvbmZpZy9oODMwMC9oODMwMC5jYyBiL2djYy9jb25m aWcvaDgzMDAvaDgzMDAuY2MKaW5kZXggY2UwNzAyZWRlY2IuLmNkNzk3NWUyZmZmIDEwMDY0 NAotLS0gYS9nY2MvY29uZmlnL2g4MzAwL2g4MzAwLmNjCisrKyBiL2djYy9jb25maWcvaDgz MDAvaDgzMDAuY2MKQEAgLTU1MzYsNyArNTUzNiw3IEBAIGg4MzAwX29rX2Zvcl9zaWJjYWxs X3AgKHRyZWUgZm5kZWNsLCB0cmVlKQogICAgaW5zdHJ1Y3Rpb24gdXNpbmcgUkVHLCBGQUxT RSBvdGhlcndpc2UuICAqLwogCiBib29sCi1wcmVfaW5jZGVjX3dpdGhfcmVnIChydHggb3As IGludCByZWcpCitwcmVfaW5jZGVjX3dpdGhfcmVnIChydHggb3AsIHVuc2lnbmVkIGludCBy ZWcpCiB7CiAgIC8qIE9QIG11c3QgYmUgYSBNRU0uICAqLwogICBpZiAoR0VUX0NPREUgKG9w KSAhPSBNRU0pCg== --------------hBHcmJnyGL5JdRyl1mWl34Te--