From: "Roger Sayle" <roger@nextmovesoftware.com>
To: "'GCC Patches'" <gcc-patches@gcc.gnu.org>
Subject: [xstormy16] Add extendhisi2 and zero_extendhisi2 patterns to stormy16.md
Date: Sat, 22 Apr 2023 21:57:48 +0100 [thread overview]
Message-ID: <026001d9755d$19b30030$4d190090$@nextmovesoftware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1671 bytes --]
This patch adds a pair of define_insn patterns to the xstormy16 machine
description that provide extendhisi2 and zero_extendhisi2, i.e. 16-bit
to 32-bit sign- and zero-extension respectively. This functionality is
already synthesized during RTL expansion, but providing patterns allow
the semantics to be exposed to the RTL optimizers. To simplify things,
this patch introduces a new %h0 output format, for emitting the high_part
register name of a double-word (SImode) register pair. The actual
code generated is identical to before.
Whilst there, I also fixed the instruction lengths and formatting of
the zero_extendqihi2 pattern. Then, mostly for documentation purposes
as the 'T' constraint isn't yet implemented, I've added a "and Rx,#255"
alternative to zero_extendqihi2 that takes advantage of its efficient
instruction encoding.
This patch has been tested by building a cross-compiler to xstormy16-elf
on x86_64-pc-linux-gnu, and confirming that the new test case passes with
"make -k check-gcc". Ok for mainline?
2023-04-22 Roger Sayle <roger@nextmovesoftware.com>
gcc/ChangeLog
* config/stormy16/stormy16.cc (xstormy16_print_operand): Add %h
format specifier to output high_part register name of SImode reg.
* config/stormy16/stormy16.md (extendhisi2): New define_insn.
(zero_extendqihi2): Fix lengths, consistent formatting and add
"and Rx,#255" alternative, for documentation purposes.
(zero_extendhisi2): New define_insn.
gcc/testsuite/ChangeLog
* gcc.target/xstormy16/extendhisi2.c: New test case.
* gcc.target/xstormy16/zextendhisi2.c: Likewise.
Thanks in advance,
Roger
--
[-- Attachment #2: patchxs3.txt --]
[-- Type: text/plain, Size: 2910 bytes --]
diff --git a/gcc/config/stormy16/stormy16.cc b/gcc/config/stormy16/stormy16.cc
index 1ed619a..34118e2 100644
--- a/gcc/config/stormy16/stormy16.cc
+++ b/gcc/config/stormy16/stormy16.cc
@@ -1828,6 +1828,14 @@ xstormy16_print_operand (FILE *file, rtx x, int code)
return;
}
+ case 'h':
+ /* Print the highpart register of an SI mode register pair. */
+ if (REG_P (x) && GET_MODE (x) == SImode)
+ fputs (reg_names [REGNO (x) + 1], file);
+ else
+ output_operand_lossage ("'h' operand is not SImode register");
+ return;
+
case 0:
/* Handled below. */
break;
diff --git a/gcc/config/stormy16/stormy16.md b/gcc/config/stormy16/stormy16.md
index d27c9fb..fd52588 100644
--- a/gcc/config/stormy16/stormy16.md
+++ b/gcc/config/stormy16/stormy16.md
@@ -268,17 +268,34 @@
""
"cbw %0")
+(define_insn "extendhisi2"
+ [(set (match_operand:SI 0 "register_operand" "=r")
+ (sign_extend:SI (match_operand:HI 1 "register_operand" "0")))]
+ ""
+ "mov %h0,%0 | asr %h0,#15"
+ [(set_attr "length" "4")
+ (set_attr "psw_operand" "clobber")])
+
(define_insn "zero_extendqihi2"
- [(set (match_operand:HI 0 "register_operand" "=e,r")
- (zero_extend:HI (match_operand:QI 1 "nonimmediate_operand" "m,0")))]
+ [(set (match_operand:HI 0 "register_operand" "=e,T,r")
+ (zero_extend:HI (match_operand:QI 1 "nonimmediate_operand" "m,0,0")))]
""
"@
- mov.b %0, %1
- shl %0,#8\n\tshr %0,#8"
- [(set_attr "psw_operand" "nop,0")
+ mov.b %0,%1
+ and Rx,#255
+ shl %0,#8 | shr %0,#8"
+ [(set_attr "psw_operand" "nop,nop,0")
(set_attr_alternative "length"
- [(const_int 4)
- (const_int 8)])])
+ [(const_int 2)
+ (const_int 2)
+ (const_int 4)])])
+
+(define_insn "zero_extendhisi2"
+ [(set (match_operand:SI 0 "register_operand" "=r")
+ (zero_extend:SI (match_operand:HI 1 "register_operand" "0")))]
+ ""
+ "mov %h0,#0"
+ [(set_attr "psw_operand" "clobber")])
\f
;; ::::::::::::::::::::
;; ::
diff --git a/gcc/testsuite/gcc.target/xstormy16/extendhisi2.c b/gcc/testsuite/gcc.target/xstormy16/extendhisi2.c
new file mode 100644
index 0000000..bb8a22d
--- /dev/null
+++ b/gcc/testsuite/gcc.target/xstormy16/extendhisi2.c
@@ -0,0 +1,7 @@
+/* { dg-do compile } */
+/* { dg-options "-O2" } */
+long foo(short x)
+{
+ return x;
+}
+/* { dg-final { scan-assembler "asr r3,#15" } } */
diff --git a/gcc/testsuite/gcc.target/xstormy16/zextendhisi2.c b/gcc/testsuite/gcc.target/xstormy16/zextendhisi2.c
new file mode 100644
index 0000000..9aef32a
--- /dev/null
+++ b/gcc/testsuite/gcc.target/xstormy16/zextendhisi2.c
@@ -0,0 +1,7 @@
+/* { dg-do compile } */
+/* { dg-options "-O2" } */
+unsigned long foo(unsigned short x)
+{
+ return x;
+}
+/* { dg-final { scan-assembler "mov r3,#0" } } */
next reply other threads:[~2023-04-22 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-22 20:57 Roger Sayle [this message]
2023-04-22 22:08 ` Jeff Law
2023-04-23 10:38 ` Roger Sayle
2023-04-24 23:53 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='026001d9755d$19b30030$4d190090$@nextmovesoftware.com' \
--to=roger@nextmovesoftware.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).