From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 52BF3385E004 for ; Thu, 26 Mar 2020 09:40:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 52BF3385E004 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mliska@suse.cz X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 19ED1AF55; Thu, 26 Mar 2020 09:40:36 +0000 (UTC) From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Subject: [stage1][PATCH] Provide warning for missing jobserver. To: gcc-patches@gcc.gnu.org Cc: Richard Biener , Jan Hubicka Message-ID: <0281e793-09fd-b472-9392-6d2a7c26fe6c@suse.cz> Date: Thu, 26 Mar 2020 10:40:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------53E3B0A571DCC7ECC7E9392F" Content-Language: en-US X-Spam-Status: No, score=-33.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2020 09:40:38 -0000 This is a multi-part message in MIME format. --------------53E3B0A571DCC7ECC7E9392F Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi. I'm suggesting to provide a warning when one uses -flto=jobserver but we can't detect job server for some reason. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed in next stage1? Thanks, Martin gcc/ChangeLog: 2020-03-26 Martin Liska PR driver/94330 * lto-wrapper.c (run_gcc): When using -flto=jobserver, report warning when the jobserver is not detected. --- gcc/lto-wrapper.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) --------------53E3B0A571DCC7ECC7E9392F Content-Type: text/x-patch; charset=UTF-8; name="0001-Provide-warning-for-missing-jobserver.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Provide-warning-for-missing-jobserver.patch" diff --git a/gcc/lto-wrapper.c b/gcc/lto-wrapper.c index 46a88b233f6..6263c164888 100644 --- a/gcc/lto-wrapper.c +++ b/gcc/lto-wrapper.c @@ -1473,10 +1473,16 @@ run_gcc (unsigned argc, char *argv[]) auto_parallel = 0; parallel = 0; } - else if (!jobserver && jobserver_active_p ()) + else { - parallel = 1; - jobserver = 1; + bool active_jobserver = jobserver_active_p (); + if (jobserver && !active_jobserver) + warning (0, "jobserver is not available."); + else if (!jobserver && active_jobserver) + { + parallel = 1; + jobserver = 1; + } } if (linker_output) --------------53E3B0A571DCC7ECC7E9392F--