public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: Tamar Christina <Tamar.Christina@arm.com>,
	Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
	"gcc@gcc.gnu.org" <gcc@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [IMPORTANT] ChangeLog related changes
Date: Wed, 10 Jun 2020 15:41:04 +0200	[thread overview]
Message-ID: <02830046-7315-8b24-ebe2-c4233180ca21@suse.cz> (raw)
In-Reply-To: <VI1PR08MB5325DBBD99898862D2331C97FF830@VI1PR08MB5325.eurprd08.prod.outlook.com>

On 6/10/20 3:34 PM, Tamar Christina wrote:
> Hi All,
> 

Hello.

> We've been wondering since we no longer list authors in the changelog (at least mklog doesn't generate it),

You are right, it's preferred solution and it's documented here:
https://gcc.gnu.org/codingconventions.html#ChangeLogs

'''
a commit author and committer date stamp can be automatically deduced from a git commit - we recommend to use it
'''

but we miss to document that additional authors are automatically taken from:
Co-Authored-By:

I'll document that.

Martin

> How do we handle multi author patches nowadays?
> 
> Tried searching for it on the website but couldn’t find anything.
> 
> Thanks,
> Tamar
> 
>> -----Original Message-----
>> From: Gcc-patches <gcc-patches-bounces@gcc.gnu.org> On Behalf Of Martin
>> Liška
>> Sent: Wednesday, June 10, 2020 8:38 AM
>> To: Jonathan Wakely <jwakely.gcc@gmail.com>
>> Cc: Jakub Jelinek <jakub@redhat.com>; gcc@gcc.gnu.org; gcc-patches <gcc-
>> patches@gcc.gnu.org>
>> Subject: Re: [IMPORTANT] ChangeLog related changes
>>
>> On 6/9/20 10:29 PM, Jonathan Wakely wrote:
>>> OK, here's a proper patch for the changes you liked, dropping the
>>> changes to the Error exception type.
>>>
>>> pytest contrib/gcc-changelog/test_email.py passes.
>>>
>>> OK for master?
>>
>> I like it and I've just pushed the patch to master.
>>
>> Martin


  parent reply	other threads:[~2020-06-10 13:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25 22:48 Jakub Jelinek
2020-05-26  5:22 ` Hongtao Liu
2020-05-26  6:08   ` Martin Liška
2020-05-26  6:10     ` Hongtao Liu
2020-06-01 17:24 ` Jonathan Wakely
2020-06-02  6:44   ` Martin Liška
2020-06-02 11:06     ` Jonathan Wakely
2020-06-02 10:55   ` Gerald Pfeifer
2020-06-02 11:05     ` Jonathan Wakely
2020-06-02 11:09       ` Jonathan Wakely
2020-06-02 11:22         ` Jonathan Wakely
2020-06-02 11:48           ` Martin Liška
2020-06-02 13:16             ` Martin Liška
2020-06-02 13:56               ` Jonathan Wakely
2020-06-02 14:06                 ` Martin Liška
2020-06-02 14:14                 ` Jonathan Wakely
2020-06-02 14:25                   ` Martin Liška
2020-06-09 20:29                     ` Jonathan Wakely
2020-06-10  7:37                       ` Martin Liška
2020-06-10 13:34                         ` Tamar Christina
2020-06-10 13:39                           ` Marek Polacek
2020-06-10 13:41                           ` Martin Liška [this message]
2020-06-10 14:53                             ` Tamar Christina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02830046-7315-8b24-ebe2-c4233180ca21@suse.cz \
    --to=mliska@suse.cz \
    --cc=Tamar.Christina@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gcc@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=jwakely.gcc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).