Re: [PATCH, GCC, AARCH64, 5/6] Enable BTI : Add new pass for BTI.

[Sudakshina Das <Sudi.Das@arm.com>]

Hi Christophe

On 10/01/19 15:46, Christophe Lyon wrote:
> On Wed, 9 Jan 2019 at 15:42, Sudakshina Das <Sudi.Das@arm.com> wrote:
>>
>> Hi
>>
>> On 20/12/18 16:40, Sudakshina Das wrote:
>>> Hi James
>>>
>>> On 19/12/18 3:40 PM, James Greenhalgh wrote:
>>>> On Fri, Dec 14, 2018 at 10:09:03AM -0600, Sudakshina Das wrote:
>>>>
>>>> <snip>
>>>>
>>>>> I have updated the patch according to our discussions offline.
>>>>> The md pattern is now split into 4 patterns and i have added a new
>>>>> test for the setjmp case along with some comments where missing.
>>>>
>>>> This is OK for trunk.
>>>>
>>>
>>> Thanks for the approvals. With this my series is ready to go in trunk. I
>>> will wait for Sam's options patch to go in trunk before I commit mine.
>>>
>>
>> Series is committed with a rebase without Sam Tebbs's 3rd patch for
>> B-Key addition as r267765 to r267770.
>>
>> Thanks
>> Sudi
>>
> 
> Hi Sudi,
> 
> I think the new bti-1.c test lacks
> /* { dg-require-effective-target lp64 } */
> as I see it failing when using -mabi=ilp32:
> cc1: sorry, unimplemented: return address signing is only supported
> for -mabi=lp64
> 

Ah yes, I actually added code for exempting ilp32 in my configure patch 
but missed it while adding test cases. Testing a patch right now.

Sudi

> Christophe
> 
>>> Thanks
>>> Sudi
>>>
>>>> Thanks,
>>>> James
>>>>
>>>>> *** gcc/ChangeLog ***
>>>>>
>>>>> 2018-xx-xx  Sudakshina Das  <sudi.das@arm.com>
>>>>>          Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
>>>>>
>>>>>      * config.gcc (aarch64*-*-*): Add aarch64-bti-insert.o.
>>>>>      * gcc/config/aarch64/aarch64.h: Update comment for
>>>>>      TRAMPOLINE_SIZE.
>>>>>      * config/aarch64/aarch64.c (aarch64_asm_trampoline_template):
>>>>>      Update if bti is enabled.
>>>>>      * config/aarch64/aarch64-bti-insert.c: New file.
>>>>>      * config/aarch64/aarch64-passes.def (INSERT_PASS_BEFORE): Insert
>>>>>      bti pass.
>>>>>      * config/aarch64/aarch64-protos.h (make_pass_insert_bti):
>>>>>      Declare the new bti pass.
>>>>>      * config/aarch64/aarch64.md (unspecv): Add UNSPECV_BTI_NOARG,
>>>>>      UNSPECV_BTI_C, UNSPECV_BTI_J and UNSPECV_BTI_JC.
>>>>>      (bti_noarg, bti_j, bti_c, bti_jc): New define_insns.
>>>>>      * config/aarch64/t-aarch64: Add rule for aarch64-bti-insert.o.
>>>>>
>>>>> *** gcc/testsuite/ChangeLog ***
>>>>>
>>>>> 2018-xx-xx  Sudakshina Das  <sudi.das@arm.com>
>>>>>
>>>>>      * gcc.target/aarch64/bti-1.c: New test.
>>>>>      * gcc.target/aarch64/bti-2.c: New test.
>>>>>      * gcc.target/aarch64/bti-3.c: New test.
>>>>>      * lib/target-supports.exp
>>>>>      (check_effective_target_aarch64_bti_hw): Add new check for
>>>>>      BTI hw.
>>>>>
>>>>> Thanks
>>>>> Sudi
>>