From: Matt Jacobson <mhjacobson@me.com>
To: Iain Sandoe <iain@sandoe.co.uk>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Objective-C: fix protocol list count type (pertinent to non-LP64)
Date: Sun, 7 Nov 2021 17:50:57 -0500 [thread overview]
Message-ID: <02D4AE39-6E23-4AD4-B94F-59908C45B5CA@me.com> (raw)
In-Reply-To: <E7BEEF0F-CE6A-4944-A98F-C8080CFC490A@sandoe.co.uk>
> On Oct 25, 2021, at 5:43 AM, Iain Sandoe <iain@sandoe.co.uk> wrote:
>
> Did you test objective-c++ on Darwin?
>
> I see a lot of fails of the form:
> Excess errors:
> <built-in>: error: initialization of a flexible array member [-Wpedantic]
Looked into this. It’s happening because obj-c++.dg/dg.exp has:
set DEFAULT_OBJCXXFLAGS " -ansi -pedantic-errors -Wno-long-long"
Specifically, the `-pedantic-errors` argument prohibits initialization of a
flexible array member. Notably, this flag does *not* appear in objc/dg.exp.
Admittedly I didn’t know that initialization of a FAM was prohibited by the
standard. It’s allowed by GCC, though, as documented here:
<https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html>
Is it OK to use a GCC extension this way in the Objective-C frontend?
> For a patch that changes code-gen we should have a test that it produces what’s
> expected (in general, a ‘torture' test would be preferrable so that we can be sure the
> output is as expected for different optimisation levels).
The output is different only for targets where
sizeof (long) != sizeof (void *). Do we have the ability to run “cross”
torture tests? Could such a test verify the emitted assembly (like LLVM’s
FileCheck tests do)? Or would it need to execute something?
Thanks for your help!
Matt
next prev parent reply other threads:[~2021-11-07 22:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 3:45 Matt Jacobson
2021-10-20 3:51 ` Matt Jacobson
2021-10-23 8:46 ` Iain Sandoe
2021-10-25 9:43 ` Iain Sandoe
2021-11-07 22:50 ` Matt Jacobson [this message]
2021-11-08 13:41 ` Iain Sandoe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02D4AE39-6E23-4AD4-B94F-59908C45B5CA@me.com \
--to=mhjacobson@me.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).