From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D2890385802F for ; Mon, 15 May 2023 14:27:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D2890385802F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684160874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tktwC8fkcyswCuCpX5Erx9A/nATYoFQFQsTL859WQXU=; b=b8i2YqKyD/Q+/h37zilCQXOUWDn9dUKtxJFr03oRbhfmsJ9iewHycdotbfJJpyldDb7emW RwNv3HlCcnf64aahH/VrMAjANYSvF73HcUfDjltTlUoandloptS8NSXgryFck21RjaqUsP QDm2JXrJJZBrCMtUF0Tz+1AbhFD0kcY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-QsIwpBwDPcOhC_zrB6BtXw-1; Mon, 15 May 2023 10:27:53 -0400 X-MC-Unique: QsIwpBwDPcOhC_zrB6BtXw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f426ffdbc6so51505605e9.3 for ; Mon, 15 May 2023 07:27:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684160872; x=1686752872; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tktwC8fkcyswCuCpX5Erx9A/nATYoFQFQsTL859WQXU=; b=du82qG0zyhubemRWbtq00kZmiW4E/z6VN32Byspty1e+C2n/jej9xGFSXAfCAISi71 NaZfG7QQuSs8mtz4s9lZLAB2YoNdHsG2NFNsYy06jR4tvOsTfXXbxxIQK85i5HnkcWf3 cKpi0FDAcS91WEYI5+G9dpWL3V853R7aab/Ft5HI+hQZfVEb/89UWAnDcUN5VfPs/syA v6YpnqeTXuh1ejda3vsbmsFjvHtjSyBYZex6AClbYZo4pfV8LMl3aWqPtV4EQ7kVTjDt X/JLOqbU8g8YSCfOv7s9bGdywP4ewm/xTm0sga/tvSjj6qZDZlK97dOG5mlPgoAK58QH 5z/A== X-Gm-Message-State: AC+VfDzPpGKRgbM43UG790zwjNLjiS+xu5WyxQZKfd+WhHCHUxfcq4xk UfyUFVzZCin47Uu0IPLbZ5HYGXwItkr4DmTAD2F0RDP8OzyCptSTVEOgrsjEapVKRylPNUu4mKY ECvmURSLlPxVqQubzIA== X-Received: by 2002:a05:600c:2198:b0:3f4:253b:92a9 with SMTP id e24-20020a05600c219800b003f4253b92a9mr18240483wme.30.1684160871849; Mon, 15 May 2023 07:27:51 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4vHZBmlVwSLd50zlEVBwjx6yB7NV2Y5VtNh4/GNYmudQ2KfF/EsyU/8xdBFiKNza6Np3V4Uw== X-Received: by 2002:a05:600c:2198:b0:3f4:253b:92a9 with SMTP id e24-20020a05600c219800b003f4253b92a9mr18240470wme.30.1684160871530; Mon, 15 May 2023 07:27:51 -0700 (PDT) Received: from [192.168.1.201] ([139.47.42.170]) by smtp.gmail.com with ESMTPSA id 17-20020a05600c229100b003f423a04016sm24962461wmf.18.2023.05.15.07.27.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 May 2023 07:27:51 -0700 (PDT) Message-ID: <02c2333f-31ca-ca58-f167-540e842e4650@redhat.com> Date: Mon, 15 May 2023 16:27:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] Add auto-resizing capability to irange's [PR109695] To: Bernhard Reutner-Fischer , Aldy Hernandez via Gcc-patches Cc: Andrew MacLeod , Richard Biener , Jakub Jelinek , mjambor@suse.cz References: <20230515103523.100412-1-aldyh@redhat.com> <20230515162453.4f2a5e94@nbbrfq.loc> From: Aldy Hernandez In-Reply-To: <20230515162453.4f2a5e94@nbbrfq.loc> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/15/23 16:24, Bernhard Reutner-Fischer wrote: > On Mon, 15 May 2023 12:35:23 +0200 > Aldy Hernandez via Gcc-patches wrote: > >> +// For resizable ranges, resize the range up to HARD_MAX_RANGES if the >> +// NEEDED pairs is greater than the current capacity of the range. >> + >> +inline void >> +irange::maybe_resize (int needed) >> +{ >> + if (!m_resizable || m_max_ranges == HARD_MAX_RANGES) >> + return; >> + >> + if (needed > m_max_ranges) >> + { >> + m_max_ranges = HARD_MAX_RANGES; >> + wide_int *newmem = new wide_int[m_max_ranges * 2]; >> + memcpy (newmem, m_base, sizeof (wide_int) * num_pairs () * 2); >> + m_base = newmem; > > Please excuse my ignorance, but where's the old m_base freed? I think > the assignment above does not call the destructor, or does it? The old m_base is never freed because it points to m_ranges, a static array in int_range: template class GTY((user)) int_range : public irange { ... ... private: wide_int m_ranges[N*2]; }; Aldy