From: Martin Sebor <msebor@gmail.com>
To: Jeff Law <law@redhat.com>,
Damian Rouson <damian@sourceryinstitute.org>,
gcc patches <gcc-patches@gcc.gnu.org>
Cc: Jerry DeLisle <jvdelisle@charter.net>
Subject: Re: port contrib/download_prerequisites script to macOS
Date: Thu, 13 Apr 2017 00:40:00 -0000 [thread overview]
Message-ID: <02ffb527-c86d-d1c7-896a-6e5977cc3a0a@gmail.com> (raw)
In-Reply-To: <c19fbc68-35cb-ddcc-f524-55229b96935a@redhat.com>
On 04/12/2017 04:03 PM, Jeff Law wrote:
> On 04/04/2017 07:10 PM, Damian Rouson wrote:
>> All,
>>
>> The attached patch modifies the contrib/download_prerequisites script
>> to work on macOS.
>> The revised script detects the operating system and adjusts the shasum
>> and md5 commands
>> to their expected name and arguments on macOS. The revised script
>> also uses curl if
>> wget is not present. macOS ships with curl but not wget.
>>
>> Tested on macOS and Lubuntu and Fedora Linux distributions.
>>
>> Ok for trunk?
>>
>> Damian
>>
>>
>> 2017-04-05 Damian Rouson <damian@sourceryinstitute.org>
>>
>> * download_prerequisites (md5_check): New function emulates Linux
>> 'md5 --check' on macOS. Modified script for macOS compatibility.
> I wonder if we should just switch to curl from wget in general rather
> than conditionalizing the code at all.
That was going to be my suggestion as well. It will make updating
the script easier.
Martin
>
> For the sums, rather than doing a check of the OS, just see if
> sha512/md5sum exists. If not, then fallback to the Darwin defaults.
>
> Jeff
next prev parent reply other threads:[~2017-04-13 0:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 1:11 Damian Rouson
2017-04-07 1:04 ` [PATCH, contrib] " Jerry DeLisle
2017-04-10 16:48 ` Mike Stump
[not found] ` <etPan.58ebd61c.3bd0724f.164e@sourceryinstitute.org>
2017-04-11 16:40 ` Jerry DeLisle
2017-04-12 22:03 ` Jeff Law
2017-04-13 0:40 ` Martin Sebor [this message]
2017-04-13 3:19 ` Jerry DeLisle
[not found] ` <etPan.58f001c5.14409c5f.c453@sourceryinstitute.org>
2017-04-13 23:29 ` Damian Rouson
2017-04-17 22:11 ` Martin Sebor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02ffb527-c86d-d1c7-896a-6e5977cc3a0a@gmail.com \
--to=msebor@gmail.com \
--cc=damian@sourceryinstitute.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jvdelisle@charter.net \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).