From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 23AC03858C54 for ; Wed, 7 Jun 2023 10:01:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 23AC03858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686132082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qZ/vTbRI2vrh5jVQOY0LtdkVppEIyykCQrdllI1kwI0=; b=iLcovBbdLbdFxfj1ouaeyj/eY8smcODX/+wkc2BqVznPFk4O3ovPMC3GpCkkjKBjqLd1ad EOlGL2T3NgKir/h8v6Rr8trtP3Xlt7WwDjEkOGoWHMzqgpsBhIBKs3Zol6vtZFm3dfMs/q qeJbPENneCtKGV8j1avUR2ZNjyTvqEU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-CPTVHWsFMh6arzJ4wXimVg-1; Wed, 07 Jun 2023 06:01:21 -0400 X-MC-Unique: CPTVHWsFMh6arzJ4wXimVg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-30c2e9541b9so3919417f8f.0 for ; Wed, 07 Jun 2023 03:01:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686132080; x=1688724080; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qZ/vTbRI2vrh5jVQOY0LtdkVppEIyykCQrdllI1kwI0=; b=mF4G+gPZAoDiR5Juo9YHKBZv+uQC5GtceFfX86qJy/urqyBGs35VgIVLLYGCGxx7dW 8v29hstE4SKjNcG9CNcwFdjekRTKuBXfzn1hE8Vm26FQOogdE2aDwmGNyL3HZ1kjKV/x mq/WCuIE9cMf1D4X4g9/Z9mhycRTeb5xDWXb/Xi+jFAuGifmvA4CEWPJu7jRv/EqBbhV uLj2AvTJ6oWBqIG3jbKXV5EFTD1OV2RwBTbE4fcAbGauIz7I6938KeKL1PiMzwDJty9C BFyA8Q3+Pg1inraiQSafWI+vsNUOJ25o0KAxyNwdtHyRWykUDRnyHutAh/00gP5uzB+h ibPw== X-Gm-Message-State: AC+VfDwlNq0ItKGCQM5GnJkACRYKrr6GHGit5z3JFUgew6QJ4IpsH4LK HTSSQh38jig3y+DL4hZ5T8ZsYNHVRlRy4ucPJxggq0SuV909rkaHM1TeINQipdJG6Xni/mPgGxx BhD9wOtCW/CZHZW51rA== X-Received: by 2002:a5d:61d2:0:b0:306:39e5:f338 with SMTP id q18-20020a5d61d2000000b0030639e5f338mr4223129wrv.62.1686132080305; Wed, 07 Jun 2023 03:01:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ50c1eN6FZXYebsRiiSekTC1l0D4aDAgX8XaWPJrhl3UPCMgBuo4k/TL3/eyLNkQvv3LBDaQg== X-Received: by 2002:a5d:61d2:0:b0:306:39e5:f338 with SMTP id q18-20020a5d61d2000000b0030639e5f338mr4223118wrv.62.1686132080004; Wed, 07 Jun 2023 03:01:20 -0700 (PDT) Received: from [192.168.1.201] ([139.47.42.170]) by smtp.gmail.com with ESMTPSA id l12-20020a5d4bcc000000b0030e5482bd8esm2754173wrt.90.2023.06.07.03.01.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 03:01:19 -0700 (PDT) Message-ID: <030045cc-fa24-0b6f-f5bf-6f626a753376@redhat.com> Date: Wed, 7 Jun 2023 12:01:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] Implement ipa_vr hashing. To: Martin Jambor , GCC patches Cc: Andrew MacLeod References: <20230522185622.537454-1-aldyh@redhat.com> <20230522185622.537454-2-aldyh@redhat.com> From: Aldy Hernandez In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/29/23 16:51, Martin Jambor wrote: > Hi, > > On Mon, May 22 2023, Aldy Hernandez via Gcc-patches wrote: >> Implement hashing for ipa_vr. When all is said and done, all these >> patches incurr a 7.64% slowdown for ipa-cp, with is entirely covered by >> the similar 7% increase in this area last week. So we get type agnostic >> ranges with "infinite" range precision close to free. > > Do you know why/where this slow-down happens? Do we perhaps want to > limit the "infiniteness" a little somehow? It happens in ipcp_vr_lattice::meet_with_1, because we have a lot more sub-ranges to union. The latest numbers are 6.6%, and as I said I've already improved ipa-cp by the an equal amount, so we're good :). The infiniteness is already capped. We start at 3 sub-ranges, and grow up to 255. I suppose if this is a problem, we could write a custom Value_Range temporary for IPA to fit specific needs, but I'd really like to avoid such special casing. > > Also, jump functions live for a long time, have you looked at how memory > hungry they become? I hope that the hashing would be good at preventing > any issues. See my previous mail on memory usage. Aldy