From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id B3D18385741B; Wed, 15 Dec 2021 16:00:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B3D18385741B Received: by mail-pl1-x636.google.com with SMTP id k4so16798121plx.8; Wed, 15 Dec 2021 08:00:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Pmw8K0Ip4qAeZW+f/zj7hiQ9YuR4wwRpIL95x4qNlEs=; b=bwD0e8Sidqu9j50+dLunBK+05mpujT8DlsoI/pvjrOUYtt37fnJvrtB/in4siStetT eq8FX55BMMXi4u7WH+b90ipKur4tzW2yjkJ6xWkng5KLVWc7o6l0cJoilpY5fFh9eW2C uf4/bqrKMvTd7NYxDoUfb1JkHEYMMkJpy22gFi/kGQJknLXpUr3o2Uvbeiqvj/wuhwwQ OscxQazryjhBYBhp48hN0NPXOJdqGV8cqAGaWWMvY2oLuoX2PwXnANxlHf87f3CShiVA 91MV4z5xDN3+JLneH7wo7Sd1Jds1hP2R9vATTedC5SgrqEMUPqi+6C96TTO7vomb20i/ q1JQ== X-Gm-Message-State: AOAM533ir8Afr1Q+VoW4SeP++WiLpM++kmGdsaCcEquTJmIT+yNCrdy8 oQIxtdfuuTqDWfQZlD+jC8w= X-Google-Smtp-Source: ABdhPJxTk+44RdtHhOttsbtooFiOCwcWINDHCZps+y4LiV/B4Fs7PRCr8At+oe0ZWZRQLu/q8+dt4Q== X-Received: by 2002:a17:90b:1e45:: with SMTP id pi5mr485398pjb.130.1639584003707; Wed, 15 Dec 2021 08:00:03 -0800 (PST) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id 38sm2818336pgl.73.2021.12.15.08.00.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Dec 2021 08:00:03 -0800 (PST) Message-ID: <03226f85-0334-1840-94f9-6c618175f974@gmail.com> Date: Wed, 15 Dec 2021 09:00:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PR103302] skip multi-word pre-move clobber during lra Content-Language: en-US To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org, zsojka@seznam.cz, wilson@gcc.gnu.org References: <74d2af86-c1c4-0842-b319-09e76b3bf633@gmail.com> <4bf89538-8c3c-59a7-378b-d02982e6a5ea@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Dec 2021 16:00:06 -0000 On 12/15/2021 1:22 AM, Alexandre Oliva wrote: > On Dec 9, 2021, Jeff Law wrote: > >>> I found a similar pattern of issuing clobbers for multi-word moves, but >>> not when reload_in_progress, in expr.c:emit_move_complex_parts. I don't >>> have a testcase, but I'm tempted to propose '!lra_in_progress &&' for it >>> as well. Can you think of any reason not to? >> The only reason I can think of is we're in stage3 :-)  It'd be a lot >> easier to green light that if we could trigger an issue. > I have not found the cycles to try to construct a testcase to trigger > the issue, but before moving on, I have regstrapped this on > x86_64-linux-gnu, so, at least for now, I propose it for the next > release cycle. Ok to install then? > > > [PR103302] skip multi-part clobber during lra for complex parts too > > From: Alexandre Oliva > > As with the earlier patch, avoid emitting clobbers that we used to > avoid during reload also during LRA, now when moving complex > multi-part values. We don't have a testcase for this one. > > > for gcc/ChangeLog > > PR target/103302 > * expr.c (emit_move_complex_parts): Skip clobbers during lra. OK for the next cycle. jeff