From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 59F273857C62 for ; Fri, 28 Aug 2020 14:44:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 59F273857C62 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Andrew_Stubbs@mentor.com IronPort-SDR: 9Dmn2DGsMXxkrAG0RRLRBe9yMvBETtaxbnQ6Zx9e5u9bhbP4Sk1hcigL48qpsM5GhkIQ00l3z5 RdQfRZc1n2YhSHF50D34h5Fe77V/+V8SB+AaAcDG3ucaUGd//6pe9i00GipL05EVwu4Qhjrm06 VsGibRNBDf471laXlCL2GV2/I82defQ36CckSOiDl3pWgNeWDg2cWLF/N1lZ2GhqnM9BFVsrSh 9dEdrvA2APodB8nK9LxLITn07+JmLeCTfDZW4WIRl2PUhKj8TwgPZnI4f5W40C0YuBILn10s+v fvY= X-IronPort-AV: E=Sophos;i="5.76,364,1592899200"; d="scan'208";a="52486015" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 28 Aug 2020 06:44:22 -0800 IronPort-SDR: +AhJXITm4c+TQyfLraAY2v50VppGxPASSJ5M14kLExcWGcy46x4fRvGgMjxYTDX7TEZ9g/242n kB4FZNeI1H2D/gS8F9TJjJE000auDaPqgO+EMR1LfCqnLcSi8zUnG7ZibtBR/4pjDcqlKmMnWU L13YLufhaUzXgaXsj73BwyYVCxpDtSZzq9JC+AxTPbomN9Mrc/cAWVwhjAICssogKvIjSrA9rk Ix3yhiSyM7vxGQkDaQ0M2emXfvUFcygINs8GhYSfVdxCdzehj5/m4FjJxtZxEKIjsuoZjRzroo WEU= Subject: Re: [PATCH 1/3] vec: add exact argument for various grow functions. To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , Richard Biener CC: GCC Patches , Jan Hubicka References: <8bf8b90a-6d10-90e3-62aa-633f7bbf71be@suse.cz> <34bd3626-39c0-2516-208d-0ebf5a736b1c@suse.cz> <20200727111104.GB84823@kam.mff.cuni.cz> <0011f4a6-7ece-47f6-e864-f837216f71c7@suse.cz> <84b9586d-63da-18bd-9113-05597520d58c@suse.cz> <52cb6f63-8c52-d995-f1f8-25268ce663f7@codesourcery.com> <89cfddce-42df-61af-eb62-a7d42551357d@suse.cz> From: Andrew Stubbs Message-ID: <0329e022-1c0f-17c1-d645-06dc5b8a723e@codesourcery.com> Date: Fri, 28 Aug 2020 15:44:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <89cfddce-42df-61af-eb62-a7d42551357d@suse.cz> Content-Type: multipart/mixed; boundary="------------BE0282277756F9FF7665AC15" Content-Language: en-GB X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 14:44:32 -0000 --------------BE0282277756F9FF7665AC15 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit On 28/08/2020 15:26, Martin Liška wrote: > On 8/28/20 4:24 PM, Andrew Stubbs wrote: >> Should I just add "true" to fix it? That's enough to make it build. > > Yes, please and push it as obvious. I've committed the attached. Andrew --------------BE0282277756F9FF7665AC15 Content-Type: text/x-patch; charset="UTF-8"; name="200828-fix-vec_safe_grow_cleared.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="200828-fix-vec_safe_grow_cleared.patch" amdgcn: Update vec_safe_grow_cleared usage An API change broke the amdgcn build. gcc/ChangeLog: * config/gcn/gcn-tree.c (gcn_goacc_get_worker_red_decl): Add "true" parameter to vec_safe_grow_cleared. diff --git a/gcc/config/gcn/gcn-tree.c b/gcc/config/gcn/gcn-tree.c index 4dcb179ba71..a681426139b 100644 --- a/gcc/config/gcn/gcn-tree.c +++ b/gcc/config/gcn/gcn-tree.c @@ -456,7 +456,7 @@ gcn_goacc_get_worker_red_decl (tree type, unsigned offset) varpool_node::finalize_decl (decl); - vec_safe_grow_cleared (machfun->reduc_decls, offset + 1); + vec_safe_grow_cleared (machfun->reduc_decls, offset + 1, true); (*machfun->reduc_decls)[offset] = decl; return decl; --------------BE0282277756F9FF7665AC15--