From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id EB4B13858D1E for ; Wed, 6 Apr 2022 07:12:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EB4B13858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DAC95210E5; Wed, 6 Apr 2022 07:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1649229137; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M+yESfF5/pVwUgmHfVjaOXTfOr66fpZZmOQkx8lfENs=; b=tkTSxPAj9IAQdiz6GIouFO+1gKZCjBmQYUSEfxJA/JrgQHlZJ785tGxeHawsavcopoLqmE cwDxV+Vnp9QGJ5YQ0IZ14FwI/bEDeGpqWJQwINIQSAHAElcSV9Kk3Uf1FC4iau/Tk6AKFm /g/qpO2FTY2Qlvw3pMDRze5vXKQFW0s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1649229137; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M+yESfF5/pVwUgmHfVjaOXTfOr66fpZZmOQkx8lfENs=; b=ZpLlRI2yG5sBKhVTQetE8qbQVlKgVb3S0ln0alZqysIYTiCREeejKi0zM0d74zfE0b3I69 0iAKxIMn9suL4sAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BDE28139F5; Wed, 6 Apr 2022 07:12:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hepBLVE9TWIdRgAAMHmgww (envelope-from ); Wed, 06 Apr 2022 07:12:17 +0000 Message-ID: <034b3cb9-97b8-633c-d01a-e56c766b673f@suse.cz> Date: Wed, 6 Apr 2022 09:12:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] gcc-changelog: ignore one more revision Content-Language: en-US To: Joseph Myers Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek , Jason Merrill References: From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 07:12:21 -0000 On 4/4/22 22:07, Joseph Myers wrote: > On Mon, 4 Apr 2022, Martin Liška wrote: > >> Ignore: >> >> Checking 86d8e0c0652ef5236a460b75c25e4f7093cc0651: FAILED >> ERR: line should start with a tab: "This reverts commits r12-7804 and >> r12-7929." >> ERR: could not deduce ChangeLog file >> >> It seems Jason pushed the revision to origin/trunk where the checking script >> is not run. > > I thought I'd fixed that (last August) by making the hooks-bin scripts > handle master and trunk the same. Well, I can't prove it, it's just a guess. Maybe Jason can answer the question? Note the server hook should have rejected the revision. Cheers, Martin