From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99371 invoked by alias); 31 Oct 2018 14:39:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 99351 invoked by uid 89); 31 Oct 2018 14:39:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=inclination X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Oct 2018 14:39:21 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 264E9307CDC2; Wed, 31 Oct 2018 14:39:19 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-29.rdu2.redhat.com [10.10.112.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25E085D6AA; Wed, 31 Oct 2018 14:39:15 +0000 (UTC) Subject: Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc To: Stafford Horne , Segher Boessenkool Cc: GCC patches , Openrisc , Richard Henderson , Joseph Myers , Joel Sherrill , Sebastian Huber References: <20181027043702.18414-1-shorne@gmail.com> <20181027043702.18414-4-shorne@gmail.com> <20181028025730.GH5766@gate.crashing.org> <20181028214723.GD1761@lianli.shorne-pla.net> <20181028225447.GK5766@gate.crashing.org> <20181030124918.GC2843@lianli.shorne-pla.net> <20181030154952.GD5994@gate.crashing.org> <20181030223553.GD2843@lianli.shorne-pla.net> From: Jeff Law Openpgp: preference=signencrypt Message-ID: <0354c1e4-3482-1536-e7c0-fc23f94dc4f7@redhat.com> Date: Wed, 31 Oct 2018 15:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181030223553.GD2843@lianli.shorne-pla.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg02042.txt.bz2 On 10/30/18 4:35 PM, Stafford Horne wrote: > On Tue, Oct 30, 2018 at 10:49:53AM -0500, Segher Boessenkool wrote: >> On Tue, Oct 30, 2018 at 09:49:18PM +0900, Stafford Horne wrote: >>> Hello, >>> >>> On Sun, Oct 28, 2018 at 05:54:47PM -0500, Segher Boessenkool wrote: >>>> Yes, like that. It also easily can handle the other combos (those with >>>> STACK_POINTER), and it is easier if you have to switch FRAME_GROWS_DOWNWARD >>>> ("false" is better on some args, but "true" is required for ssp). >>>> >>>> Your code is fine as-is of course. >>> >>> Just to be clear, when you say 'as-is' did you mean the original v3 patch? Or >>> are you referring to followup patch I posted with the some_offset (from) - >>> some_offset (to) logic. >> >> Either. Both. I meant the orig big patch, v3 if that's what it was. > > Alright, thanks, I just didnt want to misunderstand. Also note that it's my understanding the issues I raised during my review have been dealt with as have Joseph's. My inclination would be to accept the port when Stafford & rth think it's ready. Jeff