From: "Luís Ferreira" <contact@lsferreira.net>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libiberty: d-demangle: use distinguishable tuple()
Date: Wed, 13 Oct 2021 17:05:40 +0100 [thread overview]
Message-ID: <0369240cb37136fbb84e161a7bb0974d65a7cf3e.camel@lsferreira.net> (raw)
In-Reply-To: <afbc5dd1131d655ab065182e988747a60ee37468.camel@lsferreira.net>
[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]
On Wed, 2021-10-13 at 16:42 +0100, Luís Ferreira wrote:
> On Wed, 2021-10-13 at 16:34 +0100, Luís Ferreira wrote:
> > Since Tuple!() is templated type from standard library, this can
> > make
> > two
> > demangled names undistinguishable.
> >
> > Signed-off-by: Luís Ferreira <contact@lsferreira.net>
> >
> > libiberty/ChangeLog:
> >
> > * d-demangle.c (dlang_parse_tuple): use tuple() instead of
> > Tuple!()
> > ---
> > libiberty/d-demangle.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libiberty/d-demangle.c b/libiberty/d-demangle.c
> > index 880f2ec85a4..5dbdc36adbe 100644
> > --- a/libiberty/d-demangle.c
> > +++ b/libiberty/d-demangle.c
> > @@ -1711,7 +1711,7 @@ dlang_parse_tuple (string *decl, const char
> > *mangled, struct dlang_info *info)
> > if (mangled == NULL)
> > return NULL;
> >
> > - string_append (decl, "Tuple!(");
> > + string_append (decl, "tuple(");
> >
> > while (elements--)
> > {
>
> I need to update tests
>
Updated on PATCH v2.
--
Sincerely,
Luís Ferreira @ lsferreira.net
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-10-13 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 15:34 Luís Ferreira
2021-10-13 15:42 ` Luís Ferreira
2021-10-13 16:05 ` Luís Ferreira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0369240cb37136fbb84e161a7bb0974d65a7cf3e.camel@lsferreira.net \
--to=contact@lsferreira.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=lsferreira@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).