From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 9930F3858C50 for ; Mon, 6 Feb 2023 17:22:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9930F3858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="95823992" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 06 Feb 2023 09:22:37 -0800 IronPort-SDR: AO+YxFQv2DqNvkueRli6Sh6NbwV813jvwP6Bii2zX8w1JhURgY6Fnu1+FFCAhaS0TGXJSyFJsl nrxU3gmgVu+kDgWJRbnVloIJRv4yfVYxvXsR4jj3wvh0XxfSsXhpgVpkY4wn9dhESxf9Pc1i4t vIEBcP6mYc89v8HRUIct1A2kYcbcYIpdUOVW0iMwno6ko1EhkwU09BA6k2R8zAkZZB1yEtVhVa 8l+eh4GZFNl6+KMPsjpoXFN+SqMKwOt/b8OgU01Gc3ylZll3pyq4l/pNTnL0mVhipzlk66jHyD B8A= Content-Type: multipart/mixed; boundary="------------M90KjxEJkYUSQr2KcgnM6BN1" Message-ID: <03830517-e578-4ee7-b652-e82e6b5a6614@codesourcery.com> Date: Mon, 6 Feb 2023 17:22:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-GB From: Andrew Stubbs Subject: [committed] amdgcn: Pass -mstack-size through to runtime To: "gcc-patches@gcc.gnu.org" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------M90KjxEJkYUSQr2KcgnM6BN1 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit The -mstack-size option has been marked obsolete in favour of setting an environment variable at runtime ("GCN_STACK_SIZE"), but some testcases still need the option set or they have stack overflow. I could change them to use the envvar, but my testing setup uses remote execute which doesn't support that yet, and means I would skip my own tests (not ideal). This patch causes the testcase to automatically set GCN_STACK_SIZE itself, in a hidden constructor (only if it's not already set), and therefore bypasses the problem. I'm leaving the documentation saying -mstack-size is obsolete because this fix only works for offload tests, and it's still not the preferred user solution. Committed to mainline. I'll backport to OG12 shortly. Andrew --------------M90KjxEJkYUSQr2KcgnM6BN1 Content-Type: text/plain; charset="UTF-8"; name="230206-mstack-size-passthrough.patch" Content-Disposition: attachment; filename="230206-mstack-size-passthrough.patch" Content-Transfer-Encoding: base64 YW1kZ2NuOiBQYXNzIC1tc3RhY2stc2l6ZSB0aHJvdWdoIHRvIHJ1bnRpbWUKCkJ1dCBvbmx5 IGZvciB0aGUgb2ZmbG9hZCBjYXNlLgoKZ2NjL0NoYW5nZUxvZzoKCgkqIGNvbmZpZy9nY24v bWtvZmZsb2FkLmNjIChnY25fc3RhY2tfc2l6ZSk6IE5ldyBnbG9iYWwgdmFyaWFibGUuCgko cHJvY2Vzc19hc20pOiBDcmVhdGUgYSBjb25zdHJ1Y3RvciBmb3IgR0NOX1NUQUNLX1NJWkUu CgkobWFpbik6IFBhcnNlIHRoZSAtbXN0YWNrLXNpemUgb3B0aW9uLgoKZGlmZiAtLWdpdCBh L2djYy9jb25maWcvZ2NuL21rb2ZmbG9hZC5jYyBiL2djYy9jb25maWcvZ2NuL21rb2ZmbG9h ZC5jYwppbmRleCA5YzI2MmY5NzRiZS4uOTQ5M2Y4OWZlYzMgMTAwNjQ0Ci0tLSBhL2djYy9j b25maWcvZ2NuL21rb2ZmbG9hZC5jYworKysgYi9nY2MvY29uZmlnL2djbi9ta29mZmxvYWQu Y2MKQEAgLTExNyw2ICsxMTcsOCBAQCB1aW50MzJfdCBlbGZfYXJjaCA9IEVGX0FNREdQVV9N QUNIX0FNREdDTl9HRlg4MDM7ICAvLyBEZWZhdWx0IEdQVSBhcmNoaXRlY3R1cmUuCiB1aW50 MzJfdCBlbGZfZmxhZ3MgPQogICAgIChFRl9BTURHUFVfRkVBVFVSRV9YTkFDS19BTllfVjQg fCBFRl9BTURHUFVfRkVBVFVSRV9TUkFNRUNDX0FOWV9WNCk7CiAKK3N0YXRpYyBpbnQgZ2Nu X3N0YWNrX3NpemUgPSAwOyAgLyogWmVybyBtZWFucyB1c2UgZGVmYXVsdC4gICovCisKIC8q IERlbGV0ZSB0ZW1wZmlsZXMuICAqLwogCiB2b2lkCkBAIC02NjIsNiArNjY0LDE4IEBAIHBy b2Nlc3NfYXNtIChGSUxFICppbiwgRklMRSAqb3V0LCBGSUxFICpjZmlsZSkKICAgICB9CiAg IGZwcmludGYgKGNmaWxlLCAiXG59O1xuXG4iKTsKIAorICAvKiBTZXQgdGhlIHN0YWNrIHNp emUgaWYgdGhlIHVzZXIgY29uZmlndXJlZCBhIHZhbHVlLiAgKi8KKyAgaWYgKGdjbl9zdGFj a19zaXplKQorICAgIGZwcmludGYgKGNmaWxlLAorCSAgICAgInN0YXRpYyBfX2F0dHJpYnV0 ZV9fKChjb25zdHJ1Y3RvcikpXG4iCisJICAgICAidm9pZCBjb25maWd1cmVfc3RhY2tfc2l6 ZSAodm9pZClcbiIKKwkgICAgICJ7XG4iCisJICAgICAiICBjb25zdCBjaGFyICp2YWwgPSBn ZXRlbnYgKFwiR0NOX1NUQUNLX1NJWkVcIik7XG4iCisJICAgICAiICBpZiAoIXZhbCB8fCB2 YWxbMF0gPT0gJ1xcMCcpXG4iCisJICAgICAiICAgIHNldGVudiAoXCJHQ05fU1RBQ0tfU0la RVwiLCBcIiVkXCIsIHRydWUpO1xuIgorCSAgICAgIn1cblxuIiwKKwkgICAgIGdjbl9zdGFj a19zaXplKTsKKwogICBvYnN0YWNrX2ZyZWUgKCZmbnNfb3MsIE5VTEwpOwogICBmb3IgKGkg PSAwOyBpIDwgZGltc19jb3VudDsgaSsrKQogICAgIGZyZWUgKGRpbXNbaV0ubmFtZSk7CkBA IC05MjAsNiArOTM0LDEwIEBAIG1haW4gKGludCBhcmdjLCBjaGFyICoqYXJndikKIAllbGZf YXJjaCA9IEVGX0FNREdQVV9NQUNIX0FNREdDTl9HRlg5MDg7CiAgICAgICBlbHNlIGlmIChz dHJjbXAgKGFyZ3ZbaV0sICItbWFyY2g9Z2Z4OTBhIikgPT0gMCkKIAllbGZfYXJjaCA9IEVG X0FNREdQVV9NQUNIX0FNREdDTl9HRlg5MGE7CisjZGVmaW5lIFNUUiAiLW1zdGFjay1zaXpl PSIKKyAgICAgIGVsc2UgaWYgKHN0YXJ0c3dpdGggKGFyZ3ZbaV0sIFNUUikpCisJZ2NuX3N0 YWNrX3NpemUgPSBhdG9pIChhcmd2W2ldICsgc3RybGVuIChTVFIpKTsKKyN1bmRlZiBTVFIK ICAgICB9CiAKICAgaWYgKCEoZm9wZW5hY2MgXiBmb3Blbm1wKSkK --------------M90KjxEJkYUSQr2KcgnM6BN1--