From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from server.nextmovesoftware.com (server.nextmovesoftware.com [162.254.253.69]) by sourceware.org (Postfix) with ESMTPS id 121113858D38 for ; Tue, 6 Jun 2023 23:28:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 121113858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nextmovesoftware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nextmovesoftware.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nextmovesoftware.com; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:In-Reply-To:References:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2GyuGbhSThBd9WEFck4BwlrJl5EuHGTBBSVrHIkBaYQ=; b=jaANL8ln8NpwI35ymLptaixqby DcoJnCvvIr8NPlyO7m3kz+5a/K5RGazWnI641C4N0NAJjVVBThMh10l6ut960DSDE5MoHlmnDgZoL qRZPOillzrAgft0NuPbZU85xwzLwGt2fuWfD06DfhyHd1fwk/gO28hYpB9+tRCREB3vrMQmkiUrSe X5x19Y43NNa9V8qrOWNWqUFfT4dcnHPjxwfHNNpDYIPQaYRsNZW+6D7XlBRX7BYaOQI3ZhGFc57RX jWlnjfAFYImD4ywtp8YmRyuDBp9+54RTxutsdTQO8Ndp5OedruWldWkDu724tArp0FUtQO4Sf1MJo JCYjFRIQ==; Received: from host86-169-41-81.range86-169.btcentralplus.com ([86.169.41.81]:64047 helo=Dell) by server.nextmovesoftware.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1q6g6A-0007OH-1E; Tue, 06 Jun 2023 19:28:22 -0400 From: "Roger Sayle" To: "'Jakub Jelinek'" Cc: , "'Uros Bizjak'" References: <030901d998c6$ac062250$041266f0$@nextmovesoftware.com> In-Reply-To: Subject: RE: [x86_64 PATCH] PR target/110104: Missing peephole2 for addcarry. Date: Wed, 7 Jun 2023 00:28:20 +0100 Message-ID: <038501d998ce$95a76200$c0f62600$@nextmovesoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJI6mPfyMfWWzUXpiUOjo+LX8ptTgGm1GUUrpKMiLA= Content-Language: en-gb X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.nextmovesoftware.com X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - nextmovesoftware.com X-Get-Message-Sender-Via: server.nextmovesoftware.com: authenticated_id: roger@nextmovesoftware.com X-Authenticated-Sender: server.nextmovesoftware.com: roger@nextmovesoftware.com X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jakub, Jakub Jelinek wrote: > Seems to be pretty much the same as one of the 12 define_peephole2 patterns I've posted in https://gcc.gnu.org/pipermail/gcc-patches/2023-June/620821.html Doh! Impressive work. I need to study how you handle constant carry flags. Fingers-crossed that patches that touch both the middle-end and a backend don't get delayed too long in the review/approval process. > The testcase will be useful though (but I'd go with including the intrin header and using the intrinsic rather than builtin). I find the use of intrin headers a pain when running cc1 under gdb, requiring additional paths to be specified with -I etc. Perhaps there's a trick that I'm missing? __builtins are more free-standing, and therefore work with cross-compilers to targets/development environments that I don't have. I withdraw my patch. Please feel free to assign PR 110104 to yourself in Bugzilla. Cheers (and thanks), Roger