From: Jeff Law <jeffreyalaw@gmail.com>
To: Aldy Hernandez <aldyh@redhat.com>, GCC patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Improve backwards threader debugging dumps.
Date: Fri, 3 Sep 2021 08:59:49 -0600 [thread overview]
Message-ID: <0390cdba-a582-59dd-4e99-f98909c113b0@gmail.com> (raw)
In-Reply-To: <20210903135608.735535-1-aldyh@redhat.com>
On 9/3/2021 7:56 AM, Aldy Hernandez wrote:
> This patch adds debugging helpers to the backwards threader. I have
> also noticed that profitable_path_p() can bail early on paths that
> crosses loops and leave the dump of blocks incomplete. Fixed as
> well.
>
> Unfortunately the new methods cannot be marked const, because we call
> the solver's dump which is not const. I believe this was because the
> ranger dump calls m_cache.block_range(). This could probably use a
> cleanup at a later time.
>
> Tested on x86-64 Linux.
>
> OK?
>
> gcc/ChangeLog:
>
> * tree-ssa-threadbackward.c (back_threader::dump): New.
> (back_threader::debug): New.
> (back_threader_profitability::profitable_path_p): Dump blocks
> even if we are bailing early.
OK
jeff
prev parent reply other threads:[~2021-09-03 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 13:56 Aldy Hernandez
2021-09-03 13:56 ` [PATCH] Abstract PHI and forwarder block checks in jump threader Aldy Hernandez
2021-09-03 15:00 ` Jeff Law
2021-09-03 14:59 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0390cdba-a582-59dd-4e99-f98909c113b0@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).