From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by sourceware.org (Postfix) with ESMTPS id 2DA1F384841D for ; Fri, 3 Sep 2021 14:59:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2DA1F384841D Received: by mail-qk1-x731.google.com with SMTP id ay33so6037312qkb.10 for ; Fri, 03 Sep 2021 07:59:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Vl18eN7MXisrXFiR+lhPTielzT2bT3tnjzMZ0vCQwCQ=; b=ljiauG2qY6gAOO4gGKzy9iCMmkLOku1KwcQk/2pIe0VywRYNqDqRjq5r4wuWg9OJOF aw6CTd2TTKzXOeuUCEDTTdU17fkteHYvi4wrHmtckgxKMvnTcdHGH3GEgh1enpuPwatV jbpiHSqsevbtYdD3gXcTAmRg18BxJ6wMgbFLI8OMJTzFB/KWeI/WsAHx3AWjjFPI6mzV pNNZzrkN1xPwQ1G4qeXxvANNqUbGYqJtpZbevT+OEy6oOxtW3Uo4jNKqnz8uwD26o8rW BUR3Xqheub0xWXHY+/OXJWDKbLh8+ClWzq+8jwKwtiyQCJEjtrr3DHHeCs7NvEIBKOnH xTYA== X-Gm-Message-State: AOAM532/3/MVI/IwoOQf7iEuDQzNNPLh1OAZ3vXPgIx7Ab6rtxHRR+tE UEXEknwiKG304XQwdBmTUsU= X-Google-Smtp-Source: ABdhPJz5ckGTkdwGhdIkPvRK5de6ivHN5d2tTjq1LLJ6QJJs0NyFjKMSvcGzsjTjpr27IDpEy5Rx5A== X-Received: by 2002:a05:620a:21dc:: with SMTP id h28mr3879920qka.198.1630681192797; Fri, 03 Sep 2021 07:59:52 -0700 (PDT) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id a185sm3904983qkg.128.2021.09.03.07.59.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 07:59:52 -0700 (PDT) Subject: Re: [PATCH] Improve backwards threader debugging dumps. To: Aldy Hernandez , GCC patches References: <20210903135608.735535-1-aldyh@redhat.com> From: Jeff Law Message-ID: <0390cdba-a582-59dd-4e99-f98909c113b0@gmail.com> Date: Fri, 3 Sep 2021 08:59:49 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210903135608.735535-1-aldyh@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2021 14:59:54 -0000 On 9/3/2021 7:56 AM, Aldy Hernandez wrote: > This patch adds debugging helpers to the backwards threader. I have > also noticed that profitable_path_p() can bail early on paths that > crosses loops and leave the dump of blocks incomplete. Fixed as > well. > > Unfortunately the new methods cannot be marked const, because we call > the solver's dump which is not const. I believe this was because the > ranger dump calls m_cache.block_range(). This could probably use a > cleanup at a later time. > > Tested on x86-64 Linux. > > OK? > > gcc/ChangeLog: > > * tree-ssa-threadbackward.c (back_threader::dump): New. > (back_threader::debug): New. > (back_threader_profitability::profitable_path_p): Dump blocks > even if we are bailing early. OK jeff