From: Evandro Menezes <e.menezes@samsung.com>
To: 'Ramana Radhakrishnan' <ramana.gcc@googlemail.com>
Cc: 'gcc-patches' <gcc-patches@gcc.gnu.org>,
'James Greenhalgh' <james.greenhalgh@arm.com>,
'Marcus Shawcroft' <Marcus.Shawcroft@arm.com>,
'Philipp Tomsich' <philipp.tomsich@theobroma-systems.com>,
'Andrew Pinski' <pinskia@gmail.com>
Subject: RE: [PATCH][AArch64] Add separate insn sched class for vector LDP & STP
Date: Thu, 01 Oct 2015 15:40:00 -0000 [thread overview]
Message-ID: <039701d0fc5f$833537a0$899fa6e0$@samsung.com> (raw)
In-Reply-To: <CAJA7tRZpCeFDnLJ9BhE6TivRdtarRQhoOHZ6O+VTNWUCOOHghQ@mail.gmail.com>
Hi, Rama.
My patch changed the type of a couple of A64 insns from "neon_load2_2reg_q" and "neon_store2_2reg_q". However, neither ThunderX nor Xgene referred to these types, only A57 and A53 did. So I didn't feel that I'd be the best person to add them to those machines.
Thank you,
--
Evandro Menezes Austin, TX
> -----Original Message-----
> From: gcc-patches-owner@gcc.gnu.org [mailto:gcc-patches-owner@gcc.gnu.org] On
> Behalf Of Ramana Radhakrishnan
> Sent: Tuesday, September 29, 2015 19:47
> To: Evandro Menezes
> Cc: gcc-patches; James Greenhalgh; Marcus Shawcroft; Philipp Tomsich
> Subject: Re: [PATCH][AArch64] Add separate insn sched class for vector LDP &
> STP
>
> On Tue, Sep 29, 2015 at 12:52 AM, Evandro Menezes <e.menezes@samsung.com>
> wrote:
> > In some micro-architectures the insns to load or store pairs of vector
> > registers are implemented rather differently from those affecting
> > lanes in vector registers. Then, it's important that such insns be
> > described likewise differently in the scheduling model.
> >
> > This patch adds the insn types neon_ldp{,_q} and neon_stp{,_q} apart
> > from the current neon_load2_2reg_q and neon_store2_2reg_q types,
> respectively.
>
> In such types.md restructuring, please handle these in *all* affected
> scheduler descriptions, in this case thunder and xgene are 2 scheduler
> descriptions that you have missed - Given Andrew is handling Thunder, please
> update the xgene backend too at the same time. I can't think of anything else
> that is affected right now.
>
> A simple way to do that is to rename the old form to something else in an
> intermediate patch using git to figure out all the micro-architectures
> affected that need to be handled for both arm and
> aarch64 backends and then add the new forms to handle this.
>
> If there need to be follow up patches for xgene with different handling, I'm
> sure Philipp will follow up - added him to CC.
>
> Thanks,
> Ramana
>
> >
> > Thank you,
> >
> > --
> > Evandro Menezes
> >
prev parent reply other threads:[~2015-10-01 15:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 5:39 Evandro Menezes
2015-09-29 6:29 ` Andrew Pinski
2015-09-29 9:01 ` Marcus Shawcroft
2015-09-29 10:00 ` Kyrill Tkachov
2015-09-29 20:55 ` Evandro Menezes
2015-09-30 2:50 ` Ramana Radhakrishnan
2015-10-01 15:40 ` Evandro Menezes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='039701d0fc5f$833537a0$899fa6e0$@samsung.com' \
--to=e.menezes@samsung.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=james.greenhalgh@arm.com \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=pinskia@gmail.com \
--cc=ramana.gcc@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).