From: Jeff Law <law@redhat.com>
To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com
Subject: Re: [03/13] Use function_arg_info for TARGET_ARG_PARTIAL_BYTES
Date: Mon, 19 Aug 2019 20:42:00 -0000 [thread overview]
Message-ID: <039c675a-77e9-173a-f442-cd96bc9a8729@redhat.com> (raw)
In-Reply-To: <mptk1b9chma.fsf@arm.com>
On 8/19/19 9:14 AM, Richard Sandiford wrote:
> This patch adds the function_arg_info class and uses it for
> TARGET_ARG_PARTIAL_BYTES.
>
> The hook is passed the promoted mode instead of the original type mode.
>
> The arguments aren't mentioned in the documentation, which is why the
> target.def change is so small.
>
> The patch changes "true" to "arg.named" in:
>
> gcc_assert (!epiphany_pass_by_reference (cum, mode, type, /* named */ true));
>
> but epiphany_pass_by_reference doesn't care about the named flag.
>
>
> 2019-08-19 Richard Sandiford <richard.sandiford@arm.com>
>
> gcc/
> * target.def (arg_partial_bytes): Take a function_arg_info instead
> of a mode, type and named flag.
> * doc/tm.texi: Regenerate.
> * target.h (function_arg_info): Declare.
> * calls.h (function_arg_info): New class.
> * targhooks.h (hook_int_CUMULATIVE_ARGS_mode_tree_bool_0): Delete.
> (hook_int_CUMULATIVE_ARGS_arg_info_0): Declare.
> * targhooks.c (hook_int_CUMULATIVE_ARGS_mode_tree_bool_0): Delete.
> (hook_int_CUMULATIVE_ARGS_arg_info_0): New function.
> * calls.c (initialize_argument_information): Update call to
> targetm.calls.partial_bytes.
> (emit_library_call_value_1): Likewise.
> * expr.c (block_move_libcall_safe_for_call_parm): Likewise.
> * function.c (assign_parm_find_entry_rtl): Likewise.
> * config/alpha/alpha.c (alpha_arg_partial_bytes): Take a
> function_arg_info instead of a mode, type and named flag.
> * config/arc/arc.c (arc_arg_partial_bytes): Likewise.
> * config/arm/arm.c (arm_arg_partial_bytes): Likewise.
> (cmse_func_args_or_return_in_stack): Update accordingly.
> * config/bfin/bfin.c (bfin_arg_partial_bytes): Take a
> function_arg_info instead of a mode, type and named flag.
> * config/cris/cris.c (cris_arg_partial_bytes): Likewise.
> * config/csky/csky.c (csky_arg_partial_bytes): Likewise.
> * config/epiphany/epiphany.c (epiphany_arg_partial_bytes): Likewise.
> * config/fr30/fr30.c: Include calls.h.
> (fr30_arg_partial_bytes): Take a function_arg_info instead of a mode,
> type and named flag.
> * config/frv/frv.c: Include calls.h.
> (frv_arg_partial_bytes): Take a function_arg_info instead of a mode,
> type and named flag.
> * config/ft32/ft32.c (ft32_arg_partial_bytes): Likewise.
> * config/gcn/gcn.c (gcn_arg_partial_bytes): Likewise.
> * config/ia64/ia64.c (ia64_arg_partial_bytes): Likewise.
> * config/iq2000/iq2000.c (iq2000_arg_partial_bytes): Likewise.
> * config/m32r/m32r.c (m32r_arg_partial_bytes): Likewise.
> * config/mcore/mcore.c (mcore_arg_partial_bytes): Likewise.
> * config/microblaze/microblaze.c (function_arg_partial_bytes):
> Likewise.
> * config/mips/mips.c (mips_arg_partial_bytes): Likewise.
> * config/mn10300/mn10300.c (mn10300_arg_partial_bytes): Likewise.
> * config/moxie/moxie.c (moxie_arg_partial_bytes): Likewise.
> * config/msp430/msp430.c (msp430_arg_partial_bytes): Likewise.
> * config/nds32/nds32.c (nds32_arg_partial_bytes): Likewise.
> * config/nios2/nios2.c (nios2_arg_partial_bytes): Likewise.
> * config/pa/pa.c (pa_arg_partial_bytes): Likewise.
> * config/pru/pru.c (pru_arg_partial_bytes): Likewise.
> * config/riscv/riscv.c (riscv_arg_partial_bytes): Likewise.
> * config/rs6000/rs6000-internal.h (rs6000_arg_partial_bytes): Likewise.
> * config/rs6000/rs6000-call.c (rs6000_arg_partial_bytes): Likewise.
> (rs6000_parm_needs_stack): Update call accordingly.
> * config/sh/sh.c (sh_arg_partial_bytes): Take a
> function_arg_info instead of a mode, type and named flag.
> * config/sparc/sparc.c (sparc_arg_partial_bytes): Likewise.
> * config/v850/v850.c (v850_arg_partial_bytes): Likewise.
OK
jeff
next prev parent reply other threads:[~2019-08-19 20:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 15:15 [00/13] Pass an argument descriptor to target hooks Richard Sandiford
2019-08-19 15:16 ` [01/13] Add pass_va_arg_by_reference Richard Sandiford
2019-08-19 20:04 ` Jeff Law
2019-08-19 15:17 ` [02/13] Add must_pass_va_arg_in_stack Richard Sandiford
2019-08-19 20:05 ` Jeff Law
2019-08-19 15:18 ` [03/13] Use function_arg_info for TARGET_ARG_PARTIAL_BYTES Richard Sandiford
2019-08-19 20:42 ` Jeff Law [this message]
2019-08-19 15:19 ` [04/13] Use function_arg_info for TARGET_PASS_BY_REFERENCE Richard Sandiford
2019-08-19 20:43 ` Jeff Law
2019-08-19 15:20 ` [05/13] Use function_arg_info for TARGET_SETUP_INCOMING_ARGS Richard Sandiford
2019-08-19 20:50 ` Jeff Law
2019-08-19 15:21 ` [06/13] Use function_arg_info for TARGET_FUNCTION_(INCOMING_)ARG Richard Sandiford
2019-08-19 21:07 ` Jeff Law
2019-08-19 15:22 ` [07/13] Use function_arg_info for TARGET_FUNCTION_ARG_ADVANCE Richard Sandiford
2019-08-19 21:11 ` Jeff Law
2019-08-19 15:23 ` [08/13] Use function_arg_info for TARGET_CALLEE_COPIES Richard Sandiford
2019-08-19 21:16 ` Jeff Law
2019-08-19 15:24 ` [09/13] Use function_arg_info for TARGET_MUST_PASS_IN_STACK Richard Sandiford
2019-08-19 22:04 ` Jeff Law
2019-08-19 15:47 ` [10/13] Add a apply_pass_by_reference_rules helper Richard Sandiford
2019-08-19 22:19 ` Jeff Law
2019-08-19 15:51 ` [11/13] Make function.c use function_arg_info internally Richard Sandiford
2019-08-19 22:47 ` Jeff Law
2019-08-19 15:52 ` [12/13] Make calls.c " Richard Sandiford
2019-08-19 22:49 ` Jeff Law
2019-08-19 15:52 ` [13/13] Add a pass_by_reference flag to function_arg_info Richard Sandiford
2019-08-19 22:54 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039c675a-77e9-173a-f442-cd96bc9a8729@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).