From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 943203858D28 for ; Fri, 7 Oct 2022 17:49:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 943203858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 297Hjspb003439; Fri, 7 Oct 2022 17:49:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=zUa1PhK1it4FJmuLe31wn7DmeuO6HzkG6yLT7F78ZZw=; b=dw+RD90elDlxdumYDIZ3tdAMp5CoiqnUFNhilbrpwAp8PfR4rOzVSO/MK/QrNQY7YA9C Dxpk+WbRwJFoGQyLobFjVXlGzjTacMMM2pAIPpmsB/x0OhX888wj0ZIvlMWf2b8G9NHe Wa7kbdwSG30lWyd0Ag8A8zjruxni4oF+xsF9Ai/O97DQdUMnjySuxcy1scwGsODxYr/G eKhYWGSArB70E/7y/Imuma2AyKyT1Su9rBLqA1nbBEzjqbhlVSWUhKVb+/6iYUqkwhUf jYWk+fv1uvXNPUvvsV64bW7SUUpHApMgeSDM6qp/e2g3baFpm+uxGfO7dyqtY8/CiJMK GA== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3k15up75u7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Oct 2022 17:49:51 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 297GwKpG020624; Fri, 7 Oct 2022 17:49:50 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2177.outbound.protection.outlook.com [104.47.57.177]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3jxc07cwn6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Oct 2022 17:49:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mf+DctAPRMCOTfxXJjcRNQymWzJw7ziIMDyqJwZq7u+oDmOnypgdp9Ya6eOxD3Y7tY2Asx+hy5nhuNM7xe1bKl6BDMcgBmahw5zK020WoCYB/iSl+CdLZe4fEZrFbHhlfi78S7P9mBVetQucg9oarkDCUOiOBUlae/H5SlNJ9zhHy/FITRSVPpgiAtHTvEUAJPit82RUNbdnCwwCI3VoEthByLo68nTfdDnBMh97TIPBN8EqtRyULwRLgjT28w7vnNHMRKxl4oz1QrBMp4whgrYvoY4TNRDwVb0W1rr/nPWsODb9s5u+qRBqCIMwf4Eas0G04rvRc9Gmh1VP0YXZNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zUa1PhK1it4FJmuLe31wn7DmeuO6HzkG6yLT7F78ZZw=; b=eFlqhdoCXxGpzDk7Cd0lounIP7ujiNxAj5y5z4vakG/mKjz4Ad/Jhp3QffjDEU+6f0uf7KbG8BBF2KnPqMgHJg12+LEzsmlnXoBstHL9iGhpcXEO2m6kNCGmitKVOeTpXp7Zqxf2gmV6obXSLDNI6ZqZYccYI9Tyxpkj75O4FVYVtXCwrhInTT61GtccPVAx1fXZ4puBtN0I/CziHxw/aHLUfwuDKYQi/SX+1HTndtrhmrlpc7j0jGi+2RElLGsnVqibG3ynkkpBymGZjs0NPnjnwa1PwERYH5PhCMXOunrGfxmCGAj9WTLTx3sdAJRaXoqG4Q96IHqqMGEG4PwCxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zUa1PhK1it4FJmuLe31wn7DmeuO6HzkG6yLT7F78ZZw=; b=0M5iyzP11n0a5BPESsRZKElToBLDV4TUua+7DfI4hURRf/eZlDLZmtRY4lx/Ql7ZEh0bgVU7ELu7VA7VA5cZS5izqfU22H/ca31q4Fwu8Ts+OF+5KwwzvTu+ihcRGafMRkkdW3WBIbgx5XMopEs8bdYRebUu6qdJhOfIggrHZ+w= Received: from CH2PR10MB4344.namprd10.prod.outlook.com (2603:10b6:610:af::19) by MW4PR10MB6300.namprd10.prod.outlook.com (2603:10b6:303:1ee::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Fri, 7 Oct 2022 17:49:48 +0000 Received: from CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::cbf8:6682:721e:835c]) by CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::cbf8:6682:721e:835c%6]) with mapi id 15.20.5676.036; Fri, 7 Oct 2022 17:49:48 +0000 From: Qing Zhao To: "joseph@codesourcery.com" , Richard Biener CC: jakub Jelinek , GCC Patches , martin Sebor , Kees Cook Subject: Re: [GCC13][Patch][V6][PATCH 1/2] Add a new option -fstrict-flex-arrays[=n] and new attribute strict_flex_array Thread-Topic: [GCC13][Patch][V6][PATCH 1/2] Add a new option -fstrict-flex-arrays[=n] and new attribute strict_flex_array Thread-Index: AQHY2O6MDrCFXpkTTkGPTDkDvaVcQ64AP0WAgAETJQCAAeYagA== Date: Fri, 7 Oct 2022 17:49:48 +0000 Message-ID: <03C84452-ABFE-4E06-8423-A57B9B13272C@oracle.com> References: <20221005191320.2087486-1-qing.zhao@oracle.com> <20221005191320.2087486-2-qing.zhao@oracle.com> <5C0AB68D-9014-44A6-A991-111EB91AF33C@oracle.com> In-Reply-To: <5C0AB68D-9014-44A6-A991-111EB91AF33C@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR10MB4344:EE_|MW4PR10MB6300:EE_ x-ms-office365-filtering-correlation-id: 67cf8396-6055-49c0-925d-08daa88c5404 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /zaSd+TwSDxBJcjByafuKEU9VSUiX5PN4NeDydgcKeB4+5XneVPIdFn5UAQyCAq+Ysz3agFfMHTy8G3p5A3X+2kTDGeDv9cNdlWKTEOC3gneZfghV5ELblRoxq3wI2QxFsiTU6wqr9H8GopCV7T0JchTxBHTz2eUAcIFaN82nlG/NrqBy6M3W+weRchOK2A8Qo57Aa+RTsajjyRyanWmvsmTzh/8ZMbel/ea3xCc74c3FWz3KAkGFUAWyAWXgbjv56SDk8T0wIfOqUb2HlHFQ1UB51FqLupl2t/We9bsgozz8Kj9RsUxo+d+jJlFgCjprKk08kmh9MIqbohjEliAb796UySWVcEMy4o10obsK3SPgcZm9Jv0wRXFoaR1Vx42doX/FZT6OYCh06kqJi7g1UUNyalCx0oucFy4NCV3/aWDivhnBYXuidMDqnnmr0tAhaEL3QF+MB6EgwKHJNFXsKCiU/d84P/KrO8ZPEPnWHejP45DHcfnx38te4iH+e56OPUmScB6l8wEf/kPgIfr7jgUCGwz0qze987DJOFPWgCVh7EhdBADwXB9/SWTGubMBFrdzA4PpdoheTemo0qf2n0GPmgXeY3TkBqMpdObqbpiJN4EtUm8ZFpTesOjoTEQWDfGS5LDaI92jlhFkvadNqv4hqEwAuO8fUmgF32XpABRYxn68RKzeq9kOxAEHYeqNLFRJurZNULR1Tn52l9KZi6KWyTTrecDoOm6327uWPE7Y/a4kVZPqnEsxrW+nHY7XuU1XvZ+EvfOyqbz2fZgFzE0mk9cNFccNwtL6Rh8O0n7SVf/xbdHYh67Igww8km/r3vX5/ZJ0+LM1kFVG+KS2S9zeEz1wUhre3uSmjBakF4VVzOKOnPApgInnMF3JZXi x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR10MB4344.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(396003)(136003)(346002)(366004)(451199015)(110136005)(6486002)(966005)(54906003)(316002)(71200400001)(478600001)(186003)(38100700002)(41300700001)(66476007)(4326008)(91956017)(8676002)(36756003)(76116006)(66946007)(66446008)(64756008)(44832011)(6506007)(38070700005)(5660300002)(6512007)(33656002)(8936002)(66556008)(53546011)(122000001)(2906002)(2616005)(86362001)(83380400001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vdV/G1VsYV6LS9UL/QGVV3pyr5XpuSCGzz4iv8EsbVeqwLWEWAuUSO0IGCoh?= =?us-ascii?Q?EQQ1u3sIdTZ9pfSD/Z32oqQAa50lLSXGDyIeT53zrK/5osIiG2BSRU4kTvUH?= =?us-ascii?Q?XCtXxqqeLID/nSzoKmbSwKwjWnkHlNLYX0ukE/Kg/YX+gDkvAf3UUZ9YH8rz?= =?us-ascii?Q?8irOWoc9Zhrqd6XYQ7X1/XWAc7cds7sRO8WHDwgEYMP0AhG+UPYRq3/mkLUy?= =?us-ascii?Q?587uCs1peUrzIzHb8YUkQbLSRgHit3OSTwRjkS9wRdKuOCpOesQ0ZEFg6CdH?= =?us-ascii?Q?fKhpByaNI7vQsViGxEkBNpKYb+FqqOVK29pgAobvs5paIGxE6JT8QUscfcd5?= =?us-ascii?Q?58COSEEOUMoVKw7eWLPEtn9VbxuPGQc7OqI71hHhHszVnLdG1pD1rqpBYPlP?= =?us-ascii?Q?MdydQlSO6COJt8OnmyYfzxoWQz4ebrFopunegbbOuq7I1VXwcxY38ISLbvCV?= =?us-ascii?Q?t6gF8ugxR1KODG/rcNBRCxU1Rrhvs2xwF1me1Us3+2rZbvq/ihUzrsyQdXIV?= =?us-ascii?Q?6h9cK0SFh1aePITMCpVlb3bze8mmitHf3XnaBqcQw6BAC+EjEkyIMKlvOOFL?= =?us-ascii?Q?IFnywnH92gafkw/veYV4nHncPqg0lVELSYaB3eCWh3A52e1fafaAUtJutwYf?= =?us-ascii?Q?f6kKhzMRm2cbCz8fKura8MuwpGObj+UtSQRwg9E9y3bMISVM0wAb6KWcCjVd?= =?us-ascii?Q?Xa5HKhjD0lqpcHm8qFOJ0tWR0KUG+SnKeKipey8XzX6iYSxVM5o0zEWiK0Tj?= =?us-ascii?Q?BIGAt4x+csk0kh44x96sRZgbkY9ku5wuC5BwTIoefcKwBihjXmtpONW+Tiwc?= =?us-ascii?Q?uUfWv7xqTFTy8SMwo/t57Ok+RqmPjaxlKGklK4vhZQvjo5XSkbIj3xN7HbWT?= =?us-ascii?Q?BbTWFVPjNEDHj7h1YgZA8iNX1b+2BItLE7MA3N67nq3PSIsGwsT1E26q4iPV?= =?us-ascii?Q?PbaW7FVSKiqJGwRHS10YECJAAzEqynmuJNJrvDRTO51HYn+8cJXCiC0HLCGs?= =?us-ascii?Q?SjNkD1sS388x1LfQiAEoS8SaYhSnLaAbdIExcaD3cTOvp38mAD0Z33H/EWCE?= =?us-ascii?Q?0BEDt3v62Uo25RSQ9uzJCizDk3Nevnqjjeg+ODWarUcG4FD5hnNuuPcD9ptk?= =?us-ascii?Q?naP6ZW3py0XOTXqx0UBDWfqFszy8nS5LgWLKnY71L77YTsmPNiUDAeVDRNqy?= =?us-ascii?Q?gnO62VdwJ2tV2a43lT3aXLxWKP2TtwdXsHNEcVUop4cVGsMqyyiEG7wl8s05?= =?us-ascii?Q?8qwGT9hZvmAEzWR6rZ0KV/qVOt92qTFuzO3vir24Wdkb48KouF2e6CqRmVLw?= =?us-ascii?Q?eauDW9wyzjte8KD4X7m17cKEuyWc02afL3e9NnMX9xxopQVOsQxClsBm8mYB?= =?us-ascii?Q?18T0JPjz5midFmRupQL9RwMPQtEX6TJ55fDczuf4flnkBdJkcIQ46FTpn6W+?= =?us-ascii?Q?NQ1UUn+0KnBv1X1Td7Uinhkkt7q+Sn/4FoqOugvC6txMRrSJNgyc8WsmTY+v?= =?us-ascii?Q?bcCt+JnLLyqQUZVmy9O8CLkLfZJL72ZhftkWyVjy816FyA5hNDE3V+o/tHry?= =?us-ascii?Q?kiyQv+OO3uRpHPYWkFtSfzzzIaYsbbq9qHhy5IMGyNLJ+84GZxwe2e2zNs5T?= =?us-ascii?Q?CSEL1srqF0A/Ud/sw7/PoOA=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <74B9CFBE2C8D7B4B83954B2C16E69E7B@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4344.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67cf8396-6055-49c0-925d-08daa88c5404 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2022 17:49:48.4663 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wpid5pnxLA+3DVX020R+eM4TibK5QtlYJDxVMnRMzVNILohxp2UHqVzHsyd673VhCfAnoAsLNs5aFPohPB40+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6300 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-10-07_04,2022-10-07_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210070105 X-Proofpoint-GUID: RgMAi2MIfw1_wCGQ0pQHy-vbLta7lTX3 X-Proofpoint-ORIG-GUID: RgMAi2MIfw1_wCGQ0pQHy-vbLta7lTX3 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: FYI. I just committed the patches to gcc13: https://gcc.gnu.org/pipermail/gcc-cvs/2022-October/372114.html https://gcc.gnu.org/pipermail/gcc-cvs/2022-October/372115.html thanks. Qing > On Oct 6, 2022, at 8:49 AM, Qing Zhao via Gcc-patches wrote: >=20 >=20 >=20 >> On Oct 5, 2022, at 4:25 PM, Joseph Myers wrote= : >>=20 >> On Wed, 5 Oct 2022, Qing Zhao via Gcc-patches wrote: >>=20 >>> + /* if not the last field, return false. */ >>=20 >> Comments should start with an uppercase letter. >>=20 >>> + /* if not an array field, return false. */ >>=20 >>> + /* if there is a strict_flex_array attribute attached to the field, >>> + override the flag_strict_flex_arrays. */ >>=20 >>> + /* get the value of the level first from the attribute. */ >>=20 >>> + /* the attribute has higher priority than flag_struct_flex_array= . */ >>=20 >>> + /* default, all trailing arrays are flexiable array members. */ >>=20 >> Likewise, and "flexible" not "flexiable". >>=20 >>> + /* whether this field is the last field of the structure or unio= n. >>> + for UNION, any field is the last field of it. */ >>=20 >> Likewise. >>=20 >>> +field of a structure as a flexible array member for the purposesof acc= essing >>=20 >> Missing space, should be "purposes of". >=20 > Will fix all the above.=20 >=20 >=20 >>=20 >> The C front-end and docs changes are OK with the fixes above. >=20 > Thanks a lot. >=20 > So this patch is considered approved, I will commit it after the above fi= x and one more round of testing. >=20 > Let me know if you have more comment. >=20 > Qing >=20 >>=20 >> --=20 >> Joseph S. Myers >> joseph@codesourcery.com