From: Mike Stump <mikestump@comcast.net>
To: Marc Poulhies <poulhies@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] testsuite: add missing dg-require-effective-target fpic
Date: Wed, 18 May 2022 15:00:06 -0700 [thread overview]
Message-ID: <03F539D0-FD09-4E0E-8C85-F1BD4ACEE0B7@comcast.net> (raw)
In-Reply-To: <87czgstj7q.fsf@adacore.com>
Ok.
On May 5, 2022, at 2:35 AM, Marc Poulhies via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
>
> Marc Poulhiès <poulhies@adacore.com> writes:
>
>> Require effective target fpic for newly added test.
>>
>> gcc/testsuite/
>> * g++.dg/ext/visibility/visibility-local-extern1.C: Add missing
>> dg-require-effective-target fpic.
>>
>> Tested on x86_64-linux. Ok for master?
>>
>> ---
>> gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C b/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C
>> index 40c20199d0c..6fb1cc7f381 100644
>> --- a/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C
>> +++ b/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C
>> @@ -1,6 +1,7 @@
>> // PR c++/103291
>> // { dg-additional-options -fpic }
>> // { dg-final { scan-assembler-not "@GOTPCREL" } }
>> +// { dg-require-effective-target fpic }
>>
>> #pragma GCC visibility push(hidden)
>
> ping ?
prev parent reply other threads:[~2022-05-18 22:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 14:28 Marc Poulhiès
2022-05-05 9:35 ` Marc Poulhies
2022-05-18 22:00 ` Mike Stump [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03F539D0-FD09-4E0E-8C85-F1BD4ACEE0B7@comcast.net \
--to=mikestump@comcast.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=poulhies@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).