From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mikestump@comcast.net>
Received: from resqmta-h1p-028590.sys.comcast.net
 (resqmta-h1p-028590.sys.comcast.net [IPv6:2001:558:fd02:2446::8])
 by sourceware.org (Postfix) with ESMTPS id 81B433857836
 for <gcc-patches@gcc.gnu.org>; Wed, 18 May 2022 22:00:10 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 81B433857836
Received: from resomta-h1p-027911.sys.comcast.net ([96.102.179.202])
 by resqmta-h1p-028590.sys.comcast.net with ESMTP
 id rKannWrIbSAIfrRiDnq7Y7; Wed, 18 May 2022 22:00:09 +0000
Received: from smtpclient.apple ([IPv6:2601:640:4100:880:64bf:d13a:17c2:a0cf])
 by resomta-h1p-027911.sys.comcast.net with ESMTPSA
 id rRiAnG3edrg1prRiCn15Fr; Wed, 18 May 2022 22:00:08 +0000
X-Xfinity-VMeta: sc=-100.00;st=legit
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\))
Subject: Re: [PATCH] testsuite: add missing dg-require-effective-target fpic
From: Mike Stump <mikestump@comcast.net>
In-Reply-To: <87czgstj7q.fsf@adacore.com>
Date: Wed, 18 May 2022 15:00:06 -0700
Cc: gcc-patches@gcc.gnu.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <03F539D0-FD09-4E0E-8C85-F1BD4ACEE0B7@comcast.net>
References: <20220331142835.1187460-1-poulhies@adacore.com>
 <87czgstj7q.fsf@adacore.com>
To: Marc Poulhies <poulhies@adacore.com>
X-Mailer: Apple Mail (2.3696.100.31)
X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0,
 JMQ_SPF_NEUTRAL, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 18 May 2022 22:00:12 -0000

Ok.

On May 5, 2022, at 2:35 AM, Marc Poulhies via Gcc-patches =
<gcc-patches@gcc.gnu.org> wrote:
>=20
> Marc Poulhi=C3=A8s <poulhies@adacore.com> writes:
>=20
>> Require effective target fpic for newly added test.
>>=20
>> gcc/testsuite/
>> 	* g++.dg/ext/visibility/visibility-local-extern1.C: Add missing
>> 	dg-require-effective-target fpic.
>>=20
>> Tested on x86_64-linux. Ok for master?
>>=20
>> ---
>> gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C | 1 +
>> 1 file changed, 1 insertion(+)
>>=20
>> diff --git =
a/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C =
b/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C
>> index 40c20199d0c..6fb1cc7f381 100644
>> --- a/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C
>> +++ b/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C
>> @@ -1,6 +1,7 @@
>> // PR c++/103291
>> // { dg-additional-options -fpic }
>> // { dg-final { scan-assembler-not "@GOTPCREL" } }
>> +// { dg-require-effective-target fpic }
>>=20
>> #pragma GCC visibility push(hidden)
>=20
> ping ?