* [PATCH] optabs.c: Update inline documentation
@ 2016-09-12 14:40 Maciej W. Rozycki
2016-09-12 15:55 ` Jeff Law
0 siblings, 1 reply; 3+ messages in thread
From: Maciej W. Rozycki @ 2016-09-12 14:40 UTC (permalink / raw)
To: gcc-patches; +Cc: Paolo Bonzini
Hi,
I've noticed commit 147425 ("cond-optab merge target-independent bits"),
<https://gcc.gnu.org/ml/gcc-patches/2009-04/msg01030.html>, changed the
semantics of `prepare_cmp_insn' function arguments, however did not fully
accordingly update its documentation comment. Here's the missing update.
gcc/
* optabs.c (prepare_cmp_insn): Update documentation comment.
OK to apply?
Maciej
gcc-optabs-prepare-cmp-insn-doc.diff
Index: gcc/gcc/optabs.c
===================================================================
--- gcc.orig/gcc/optabs.c 2016-08-15 17:24:21.124480231 +0100
+++ gcc/gcc/optabs.c 2016-08-15 17:42:29.370598925 +0100
@@ -3716,13 +3716,17 @@ can_compare_p (enum rtx_code code, machi
}
/* This function is called when we are going to emit a compare instruction that
- compares the values found in *PX and *PY, using the rtl operator COMPARISON.
+ compares the values found in X and Y, using the rtl operator COMPARISON.
- *PMODE is the mode of the inputs (in case they are const_int).
- *PUNSIGNEDP nonzero says that the operands are unsigned;
+ If they have mode BLKmode, then SIZE specifies the size of both operands.
+
+ UNSIGNEDP nonzero says that the operands are unsigned;
this matters if they need to be widened (as given by METHODS).
- If they have mode BLKmode, then SIZE specifies the size of both operands.
+ *PTEST is where the resulting comparison RTX is returned or NULL_RTX
+ if we failed to produce one.
+
+ *PMODE is the mode of the inputs (in case they are const_int).
This function performs all the setup necessary so that the caller only has
to emit a single comparison insn. This setup can involve doing a BLKmode
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] optabs.c: Update inline documentation
2016-09-12 14:40 [PATCH] optabs.c: Update inline documentation Maciej W. Rozycki
@ 2016-09-12 15:55 ` Jeff Law
2016-09-13 10:26 ` Maciej W. Rozycki
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Law @ 2016-09-12 15:55 UTC (permalink / raw)
To: Maciej W. Rozycki, gcc-patches; +Cc: Paolo Bonzini
On 09/12/2016 08:37 AM, Maciej W. Rozycki wrote:
> Hi,
>
> I've noticed commit 147425 ("cond-optab merge target-independent bits"),
> <https://gcc.gnu.org/ml/gcc-patches/2009-04/msg01030.html>, changed the
> semantics of `prepare_cmp_insn' function arguments, however did not fully
> accordingly update its documentation comment. Here's the missing update.
>
> gcc/
> * optabs.c (prepare_cmp_insn): Update documentation comment.
>
> OK to apply?
OK.
jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] optabs.c: Update inline documentation
2016-09-12 15:55 ` Jeff Law
@ 2016-09-13 10:26 ` Maciej W. Rozycki
0 siblings, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2016-09-13 10:26 UTC (permalink / raw)
To: Jeff Law; +Cc: gcc-patches, Paolo Bonzini
On Mon, 12 Sep 2016, Jeff Law wrote:
> > gcc/
> > * optabs.c (prepare_cmp_insn): Update documentation comment.
> >
> > OK to apply?
> OK.
> jeff
Committed, thanks.
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-13 9:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-12 14:40 [PATCH] optabs.c: Update inline documentation Maciej W. Rozycki
2016-09-12 15:55 ` Jeff Law
2016-09-13 10:26 ` Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).