From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from server.nextmovesoftware.com (server.nextmovesoftware.com [162.254.253.69]) by sourceware.org (Postfix) with ESMTPS id 8335B3858C78 for ; Sat, 29 Apr 2023 13:37:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8335B3858C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nextmovesoftware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nextmovesoftware.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nextmovesoftware.com; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=e/qUZQOV7VftGadfPGQJsEpN1AkQ2b/esM2Z5rYnO+E=; b=VoxdQE+CaL3nouq8kohRdfwS04 j9A/vpXOzqmLMW9r09TdrRt7LEn6UFAvxbJ5ACYxAv5fktpHj5dyK+Bl/MEkbmrIaTwhZyuseUu6T 5oX+zT2I2RzBiUkLPfP8yNLBXPn4tK8HFWjZmJe3OqIsN1RIH6M7NSU6oHAbSzHDCKUYfQoHzZdi7 yeAQdxMBI8arq0HUXDzHm1q6KzuTZigXuCPhqK4cOe+MfPvmVtwdTITftj1lOHK1zlsAyvJysn6IW gOzKVIiGbuXKV1ANieYxCI78Ezr/crzXcARClCioi2WO7CVhpz9cwNA8z7R3WhC/dgM78eKYJJzKG QBrTGbdA==; Received: from host86-169-41-81.range86-169.btcentralplus.com ([86.169.41.81]:60214 helo=Dell) by server.nextmovesoftware.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1pskl5-0005UW-2H; Sat, 29 Apr 2023 09:37:03 -0400 From: "Roger Sayle" To: "'GCC Patches'" Cc: "'Segher Boessenkool'" , "'Tom de Vries'" Subject: Re: [PATCH] Turn on LRA on all targets Date: Sat, 29 Apr 2023 14:37:03 +0100 Message-ID: <03ac01d97a9f$b0262960$10727c20$@nextmovesoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: Adl6npzmP6HzUA6RQuODphVtpB8fUA== Content-Language: en-gb X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.nextmovesoftware.com X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - nextmovesoftware.com X-Get-Message-Sender-Via: server.nextmovesoftware.com: authenticated_id: roger@nextmovesoftware.com X-Authenticated-Sender: server.nextmovesoftware.com: roger@nextmovesoftware.com X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Segher Boessenkool wrote: > I send this patch now so that people can start testing. > > diff --git a/gcc/config/nvptx/nvptx.cc b/gcc/config/nvptx/nvptx.cc > index 89349dae9e62..e32f17377525 100644 > --- a/gcc/config/nvptx/nvptx.cc > +++ b/gcc/config/nvptx/nvptx.cc > @@ -7601,9 +7601,6 @@ nvptx_asm_output_def_from_decls (FILE *stream, tree name, tree value) > #undef TARGET_ATTRIBUTE_TABLE > #define TARGET_ATTRIBUTE_TABLE nvptx_attribute_table > >-#undef TARGET_LRA_P >-#define TARGET_LRA_P hook_bool_void_false >- > #undef TARGET_LEGITIMATE_ADDRESS_P > #define TARGET_LEGITIMATE_ADDRESS_P nvptx_legitimate_address_p I've tested Segher's patch on nvptx-none with make and make -k check and can confirm there are no new regressions. Nvptx is unique in that it doesn't use register allocation, i.e. GCC's only TARGET_NO_REGISTER_ALLOCATION target, so it's a little odd that it specifies which register allocator it doesn't use. I hope this helps, Roger --