From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28717 invoked by alias); 3 Nov 2016 12:01:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28558 invoked by uid 89); 3 Nov 2016 12:01:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=gate X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Nov 2016 12:01:35 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6FC038EB4A; Thu, 3 Nov 2016 12:01:34 +0000 (UTC) Received: from localhost.localdomain (vpn1-5-133.ams2.redhat.com [10.36.5.133]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA3C1W0t027183; Thu, 3 Nov 2016 08:01:33 -0400 Subject: Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag. To: Andrew Burgess , gcc-patches@gcc.gnu.org References: <512a967c-39c4-44f5-6f24-d75ef543979d@redhat.com> <20160629192130.GF8823@embecosm.com> <20160914130048.GC31794@embecosm.com> Cc: Jeff Law , Jakub Jelinek From: Bernd Schmidt Message-ID: <03bef940-2b86-af7d-d2d2-b96b8283596f@redhat.com> Date: Thu, 03 Nov 2016 12:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160914130048.GC31794@embecosm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00277.txt.bz2 On 09/14/2016 03:00 PM, Andrew Burgess wrote: > In an attempt to get this patch merged (as I still think that its > correct) I've investigated, and documented a little more about how I > think things currently work. I'm sure most people reading this will > already know this, but hopefully, if my understanding is wrong someone > can point it out. > gcc/ChangeLog: > > * gcc/bb-reorder.c: Remove 'toplev.h' include. > (pass_partition_blocks::gate): No longer check > user_defined_section_attribute, instead check the function decl > for a section attribute. > * gcc/c-family/c-common.c (handle_section_attribute): No longer > set user_defined_section_attribute. > * gcc/final.c (rest_of_handle_final): Likewise. > * gcc/toplev.c: Remove definition of user_defined_section_attribute. > * gcc/toplev.h: Remove declaration of > user_defined_section_attribute. > > gcc/testsuiteChangeLog: > > * gcc.dg/tree-prof/section-attr-1.c: New file. > * gcc.dg/tree-prof/section-attr-2.c: New file. > * gcc.dg/tree-prof/section-attr-3.c: New file. I think the explanation is perfectly reasonable and the patch looks good, except: > +__attribute__((noinline)) Add noclone to all of these as well. Bernd