From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103371 invoked by alias); 20 Nov 2017 18:29:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 103352 invoked by uid 89); 20 Nov 2017 18:29:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.2 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_LOW,SPAM_BODY,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=20.11.2017, Hx-languages-length:1411, accounts X-Spam-User: qpsmtpd, 2 recipients X-HELO: cc-smtpout2.netcologne.de Received: from cc-smtpout2.netcologne.de (HELO cc-smtpout2.netcologne.de) (89.1.8.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Nov 2017 18:29:35 +0000 Received: from cc-smtpin2.netcologne.de (cc-smtpin2.netcologne.de [89.1.8.202]) by cc-smtpout2.netcologne.de (Postfix) with ESMTP id E99D412766; Mon, 20 Nov 2017 19:29:31 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by cc-smtpin2.netcologne.de (Postfix) with ESMTP id E68FF11E1D; Mon, 20 Nov 2017 19:29:31 +0100 (CET) Received: from [78.35.131.92] (helo=cc-smtpin2.netcologne.de) by localhost with ESMTP (eXpurgate 4.1.9) (envelope-from ) id 5a131f0b-02b8-7f0000012729-7f000001b06f-1 for ; Mon, 20 Nov 2017 19:29:31 +0100 Received: from [192.168.178.20] (xdsl-78-35-131-92.netcologne.de [78.35.131.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by cc-smtpin2.netcologne.de (Postfix) with ESMTPSA; Mon, 20 Nov 2017 19:29:29 +0100 (CET) Subject: Re: [patch, fortran] Implement maxloc and minloc for character To: Janne Blomqvist Cc: "fortran@gcc.gnu.org" , gcc-patches References: <44c7b39b-d849-e31a-7175-80bf1a348908@netcologne.de> From: Thomas Koenig Message-ID: <03e85917-b506-0d8b-78b0-263c371cba6a@netcologne.de> Date: Mon, 20 Nov 2017 18:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg01798.txt.bz2 Am 20.11.2017 um 09:30 schrieb Janne Blomqvist: > On Sun, Nov 19, 2017 at 11:11 PM, Thomas Koenig wrote: >> There is one question regarding the ABI. Apparently, the string length >> is passed as an int even on a 64-bit system. I verified that this >> is indeed the case by doing the actual work on a >> powerpc64-unknown-linux-gnu box (gcc110 on the gcc compile farm), >> which is big-endian. If we were actually passing an eight-byte >> quantity, and only getting the upper bytes, we would crash & burn. >> >> Now, I _thought_ we were passing string lengths as size_t now (Janne?), >> but maybe something was missing in that change. > > Unfortunately I had to revert the charlen->size_t patch since it > caused regressions on aix/power (presumably due to endianness issues). Ah, that explains it. I had forgotten the reversion part. > There's apparently some other process for getting compile farm > accounts nowadays, and we have broken the ABI again for gcc 8, so > maybe I should dust off the patch and try again. Or what do you think? You can apply at https://cfarm.tetaneutral.net/ . These machines are indeed quite nice to work on, especially because of the different architectures (and because there are some very powerful machines there). So, any other comments about my patch? OK for trunk? Regards Thomas