From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 265633858290 for ; Mon, 17 Oct 2022 13:25:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 265633858290 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666013128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=sDtpjd4dcd1zZG0OPqyoYw/QwsovlrKHTXcdbgD/36I=; b=d5WHP/EaE57n1i893QfPJwOhTYEzPMF8JuYI85GPJrOvaH8/E3S1fTL0gOddvR7mU4E6Hv zhakjR5fB50GueLjNnHOuKO5/6q7sYWiYl7HCM0FRS/xi+JWCuOC9BiL2mFdri/LG64aML UIOIhSS1pey1JBAGIt9SMFXSPz92oYs= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-632-eP7r7hyiOSSldSlGpUrk1A-1; Mon, 17 Oct 2022 09:25:27 -0400 X-MC-Unique: eP7r7hyiOSSldSlGpUrk1A-1 Received: by mail-il1-f199.google.com with SMTP id i8-20020a056e0212c800b002f9a4c75658so9017540ilm.3 for ; Mon, 17 Oct 2022 06:25:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8BlhAy575jK7WeioEf0uR+yrwLCtDj2zZOdbn55QFME=; b=7CWXdryzqXy6wWUrD/MviKjLuEU1koew5JS8SfaCF8//vfrN/PqCjbry6L5/EgrcCH Ooj1kR5BEamCINKGorT03dXDSFR2u0BL/LTqgLjeXPdy227xR+GExXbsNcazvjkC5Ky8 SdH6w0k7hdGPWJHOv4IFEXAx7FDeHMWk7dHqmHj5W3TkCSQ2gKwPNNErJdGcnnfSoC/B c8QU0a3UwCQAhdb5UDvTD8P+Qxt05YWQPAEnzrYXFDIhTy6QUR08JqXSPDqCHZS69+xS CIOzMwTZesraWNZpL1qkx9HiBJWZ1zgNlGmhwdWmzqsssbRs9V7RRAdRIvC5nBDwuuIV DrRQ== X-Gm-Message-State: ACrzQf0b/ZtQbCcB3h6wjeTjrUcRLWl9VZ6t6no5tfpO1LAUiatirPAI okwp0Z66N5yR7cTrJp3j3d4u/ZteQnt0VBhqr6mNcqsxVIWJIQra/+p47EKha3br0xD3kfEYl/G 5Ka2D7u+raICsXwM73O0WCdRUvKR+Y4DGqgJYpQC4gJCmZIC5IvVXauy9Q1GwhP6fNVii2g== X-Received: by 2002:a05:6e02:5a1:b0:2f9:456:139f with SMTP id k1-20020a056e0205a100b002f90456139fmr4660627ils.299.1666013126508; Mon, 17 Oct 2022 06:25:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7TV9H/QVH4I3ZBAw6wlZEAxe8FxTJYPuVW3KT23sUNQY/z69I4ekmpBymAFNSbSrv+9Feg+A== X-Received: by 2002:a05:6e02:5a1:b0:2f9:456:139f with SMTP id k1-20020a056e0205a100b002f90456139fmr4660616ils.299.1666013126233; Mon, 17 Oct 2022 06:25:26 -0700 (PDT) Received: from ?IPV6:2607:fea8:a263:f600::50d4? ([2607:fea8:a263:f600::50d4]) by smtp.gmail.com with ESMTPSA id g14-20020a05660226ce00b006a129b10229sm4221431ioo.31.2022.10.17.06.25.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Oct 2022 06:25:25 -0700 (PDT) Message-ID: <03ebe7bc-13bf-a37f-7f8d-d2146e2df918@redhat.com> Date: Mon, 17 Oct 2022 09:25:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 To: gcc-patches Cc: "hernandez, aldy" From: Andrew MacLeod Subject: [COMMITTED] Fix nan updating in range-ops. X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------QRmM0huQqHU7824rzyCIRDXy" Content-Language: en-US X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------QRmM0huQqHU7824rzyCIRDXy Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit There is a path in which clear_nan() is called on an UNDEFINED range, which is not allowed.  This patch simply makes sure VARYING is set before calling clear_nan(). In operator_not_equal, we should check if op1 == op1 AFTER the check for a singleton. operator_ordered was also cealring the NAN on the false side, and should be setting it. None of these paths were being executed to this point as GORI was not passing in the relation between op1 and op2, but the next patch changes that and would trigger these issues. Bootstrapped on x86_64-pc-linux-gnu with no regressions.  Pushed. Andrew --------------QRmM0huQqHU7824rzyCIRDXy Content-Type: text/x-patch; charset=UTF-8; name="0002-Fix-nan-updating-in-range-ops.patch" Content-Disposition: attachment; filename="0002-Fix-nan-updating-in-range-ops.patch" Content-Transfer-Encoding: base64 RnJvbSAwNDg3NGZlZGFlODA3NGIyNTJhYmJkNzBmZWE2OGJmM2RkMGE2MDViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXcgTWFjTGVvZCA8YW1hY2xlb2RAcmVkaGF0LmNvbT4K RGF0ZTogRnJpLCAxNCBPY3QgMjAyMiAwOToyOToyMyAtMDQwMApTdWJqZWN0OiBbUEFUQ0ggMi80 XSBGaXggbmFuIHVwZGF0aW5nIGluIHJhbmdlLW9wcy4KCkNhbGxpbmcgY2xlYW5fbmFuIG9uIGFu IHVuZGVmaW5lZCB0eXBlIHRyYXBzLCBzZXRfdmFyeWluZyBmaXJzdC4gT3RoZXIKdHdlYWtzIGZv ciBjb3JyZWN0bmVzcy4KCgkqIHJhbmdlLW9wLWZsb2F0LmNjIChmb3BlcmF0b3Jfbm90X2VxdWFs OjpvcDFfcmFuZ2UpOiBDaGVjayBmb3IKCVZSRUxfRVEgYWZ0ZXIgc2luZ2xldG9uLgoJKGZvcGVy YXRvcl91bm9yZGVyZWQ6Om9wMV9yYW5nZSk6IFNldCBWQVJZSU5HIGJlZm9yZSBjYWxsaW5nCglj bGVhcl9uYW4oKS4KCShmb3BlcmF0b3Jfb3JkZXJlZDo6b3AxX3JhbmdlKTogU2V0IHJhdGhlciB0 aGFuIGNsZWFyIE5BTiBpZiBib3RoCglvcGVyYW5kcyBhcmUgdGhlIHNhbWUuCi0tLQogZ2NjL3Jh bmdlLW9wLWZsb2F0LmNjIHwgMjMgKysrKysrKysrKy0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFu Z2VkLCAxMCBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nY2Mv cmFuZ2Utb3AtZmxvYXQuY2MgYi9nY2MvcmFuZ2Utb3AtZmxvYXQuY2MKaW5kZXggMjNlMGY1ZWY0 ZTIuLjZjZjIxODBjZTU5IDEwMDY0NAotLS0gYS9nY2MvcmFuZ2Utb3AtZmxvYXQuY2MKKysrIGIv Z2NjL3JhbmdlLW9wLWZsb2F0LmNjCkBAIC01MTAsMTIgKzUxMCw5IEBAIGZvcGVyYXRvcl9ub3Rf ZXF1YWw6Om9wMV9yYW5nZSAoZnJhbmdlICZyLCB0cmVlIHR5cGUsCiAgIHN3aXRjaCAoZ2V0X2Jv b2xfc3RhdGUgKHIsIGxocywgdHlwZSkpCiAgICAgewogICAgIGNhc2UgQlJTX1RSVUU6Ci0gICAg ICAvLyBUaGUgVFJVRSBzaWRlIG9mIG9wMSAhPSBvcDEgaW1wbGllcyBvcDEgaXMgTkFOLgotICAg ICAgaWYgKHJlbCA9PSBWUkVMX0VRKQotCXIuc2V0X25hbiAodHlwZSk7CiAgICAgICAvLyBJZiB0 aGUgcmVzdWx0IGlzIHRydWUsIHRoZSBvbmx5IHRpbWUgd2Uga25vdyBhbnl0aGluZyBpcyBpZgog ICAgICAgLy8gT1AyIGlzIGEgY29uc3RhbnQuCi0gICAgICBlbHNlIGlmIChvcDIuc2luZ2xldG9u X3AgKCkpCisgICAgICBpZiAob3AyLnNpbmdsZXRvbl9wICgpKQogCXsKIAkgIC8vIFRoaXMgaXMg Y29ycmVjdCBldmVuIGlmIG9wMSBpcyBOQU4sIGJlY2F1c2UgdGhlIGZvbGxvd2luZwogCSAgLy8g cmFuZ2Ugd291bGQgYmUgflt0bXAsIHRtcF0gd2l0aCB0aGUgTkFOIHByb3BlcnR5IHNldCB0bwpA QCAtNTIzLDYgKzUyMCw5IEBAIGZvcGVyYXRvcl9ub3RfZXF1YWw6Om9wMV9yYW5nZSAoZnJhbmdl ICZyLCB0cmVlIHR5cGUsCiAJICBSRUFMX1ZBTFVFX1RZUEUgdG1wID0gb3AyLmxvd2VyX2JvdW5k ICgpOwogCSAgci5zZXQgKHR5cGUsIHRtcCwgdG1wLCBWUl9BTlRJX1JBTkdFKTsKIAl9CisgICAg ICAvLyBUaGUgVFJVRSBzaWRlIG9mIG9wMSAhPSBvcDEgaW1wbGllcyBvcDEgaXMgTkFOLgorICAg ICAgZWxzZSBpZiAocmVsID09IFZSRUxfRVEpCisJci5zZXRfbmFuICh0eXBlKTsKICAgICAgIGVs c2UKIAlyLnNldF92YXJ5aW5nICh0eXBlKTsKICAgICAgIGJyZWFrOwpAQCAtMTA0NSwyMiArMTA0 NSwxOCBAQCBmb3BlcmF0b3JfdW5vcmRlcmVkOjpvcDFfcmFuZ2UgKGZyYW5nZSAmciwgdHJlZSB0 eXBlLAogICBzd2l0Y2ggKGdldF9ib29sX3N0YXRlIChyLCBsaHMsIHR5cGUpKQogICAgIHsKICAg ICBjYXNlIEJSU19UUlVFOgotICAgICAgaWYgKHJlbCA9PSBWUkVMX0VRKQotCXIuc2V0X25hbiAo dHlwZSk7CiAgICAgICAvLyBTaW5jZSBhdCBsZWFzdCBvbmUgb3BlcmFuZCBtdXN0IGJlIE5BTiwg aWYgb25lIG9mIHRoZW0gaXMKICAgICAgIC8vIG5vdCwgdGhlIG90aGVyIG11c3QgYmUuCi0gICAg ICBlbHNlIGlmICghb3AyLm1heWJlX2lzbmFuICgpKQorICAgICAgaWYgKHJlbCA9PSBWUkVMX0VR IHx8ICFvcDIubWF5YmVfaXNuYW4gKCkpCiAJci5zZXRfbmFuICh0eXBlKTsKICAgICAgIGVsc2UK IAlyLnNldF92YXJ5aW5nICh0eXBlKTsKICAgICAgIGJyZWFrOwogCiAgICAgY2FzZSBCUlNfRkFM U0U6Ci0gICAgICBpZiAocmVsID09IFZSRUxfRVEpCi0Jci5jbGVhcl9uYW4gKCk7CiAgICAgICAv LyBBIGZhbHNlIFVOT1JERVJFRCBtZWFucyBib3RoIG9wZXJhbmRzIGFyZSAhTkFOLCBzbyBpdCdz CiAgICAgICAvLyBpbXBvc3NpYmxlIGZvciBvcDIgdG8gYmUgYSBOQU4uCi0gICAgICBlbHNlIGlm IChvcDIua25vd25faXNuYW4gKCkpCisgICAgICBpZiAob3AyLmtub3duX2lzbmFuICgpKQogCXIu c2V0X3VuZGVmaW5lZCAoKTsKICAgICAgIGVsc2UKIAl7CkBAIC0xMTMyLDEwICsxMTI4LDExIEBA IGZvcGVyYXRvcl9vcmRlcmVkOjpvcDFfcmFuZ2UgKGZyYW5nZSAmciwgdHJlZSB0eXBlLAogICAg ICAgYnJlYWs7CiAKICAgICBjYXNlIEJSU19GQUxTRToKLSAgICAgIHIuc2V0X3ZhcnlpbmcgKHR5 cGUpOwotICAgICAgLy8gVGhlIEZBTFNFIHNpZGUgb2Ygb3AxIE9SREVSRUQgb3AxIGltcGxpZXMg b3AxIGlzICFOQU4uCisgICAgICAvLyBUaGUgRkFMU0Ugc2lkZSBvZiBvcDEgT1JERVJFRCBvcDEg aW1wbGllcyBvcDEgaXMgTkFOLgogICAgICAgaWYgKHJlbCA9PSBWUkVMX0VRKQotCXIuY2xlYXJf bmFuICgpOworCXIuc2V0X25hbiAodHlwZSk7CisgICAgICBlbHNlCisJci5zZXRfdmFyeWluZyAo dHlwZSk7CiAgICAgICBicmVhazsKIAogICAgIGRlZmF1bHQ6Ci0tIAoyLjM3LjMKCg== --------------QRmM0huQqHU7824rzyCIRDXy--