From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2040.outbound.protection.outlook.com [40.107.22.40]) by sourceware.org (Postfix) with ESMTPS id 87D59386183D for ; Thu, 15 Feb 2024 09:53:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 87D59386183D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 87D59386183D Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.40 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1707990815; cv=pass; b=mrTjho3GcupxHLiuXMkB+ax/4gXdiCXaMwr2JUkHLPFkifPqCwG0YGWeiKpdSHLpepcVbRNTED0/izVR6ru99sRAKxF3+G5w972BUqut+6VIVXhEhvuml6VT0DYaY2qmtAYtfI/I2ygNI3oDUS1GI6zFF6DxrrBMZz7xaOu24jY= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1707990815; c=relaxed/simple; bh=KAlbASngZ2TumdZvx0nlZRzzEs/n3JB0tDsb4W9dOpU=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=nK9NhJZw680JWFQRHBJ9yXirpxtNYdc3pTKcETEjECghJ3O0NZ0m0UN7NA7ULjM2LtkrtXO2SB8RZx7Hf7CkL8QaTamrk6hJn5QHDKLtmSrDCY/cAg508cFWdwR25btveW0F405BeymVrlJ5sV/SzRA0UjtFbYz4JnChDiKt6yk= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Haj1223EfE4OA173BlAm1zkxWBqVYb5fLJkiXZ61uHvRWPE0dO71bc1Zka35zuN2Yu/k0DZcZ7l2vQSP2NOIMYB1/cBMEq0kCBPNYntNrVuAVNvDUUaP9HFB1Z4W0xHxfFWEHdTjXJs2knvfZrhomJaGiZXJTYazSzOVW88LnX208GJd6fpfovdzwlQ/XHfRx6FfLMrOegi0Wq1oL0YciINwrEOaY10DqxbFsNwIQa0ZjReL9Ev5WsFIhcictlMmFaCx6g3gh1Tmw+wQytnpLkw5n/EemeumVNcnj+InyB4L+XQidcEcgYM5TmA/cEKMzzdlni2LUa0qYdAUcywX7Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MHu9U0I1eWaZf7c7IudvQW5Zrj8Gl4k8rkJc7iS8NTI=; b=mjwxeEkBqHexCq3XEB5jdKp2/31m06saCu2GfEK2V6bER6ls0ZVcONNifLpsj1mmHOAd8bZzhkl/I/L9slizFbxv9C8Ou6VSw5KODutWYcxiQrNTzahMk/wqPxnhGiC5aKop5EyAYBIEon9YaMqRZv4tzlzyGYSMoOHKMsKrTBnhsoY1+DjZAVsWv/NKbepo3AMhOWo0fwFxmteM1Oeh9ao4w1r9wfym5Ye/j8b6wppJ/sbZ1hcbQ/8+veUEuOeMRhRLZKee7rg8UWPYjd4vPpWjbNy3Mv59llGAWBJcT2NT0py79/sChs3MB0nphrSsOsvaxs26UaHxqsePNc1U3w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MHu9U0I1eWaZf7c7IudvQW5Zrj8Gl4k8rkJc7iS8NTI=; b=aNdBX5a4RnPAY0J4arips42oL8Og826fx46k6cfkzp33j9cyRAbnLVZYF5+ejSyycu0Ev8DDl1gyqLc0jLduIWTE17dOzEptSRBnkrKBI9Sz1OeECZ72qwuClEPxfa3bae/6YBAydAtAzOMKhFhZ5/CVDXxVTwFZu+hYb1nD0L4= Received: from AS9PR04CA0085.eurprd04.prod.outlook.com (2603:10a6:20b:50e::10) by GV2PR08MB9421.eurprd08.prod.outlook.com (2603:10a6:150:dd::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.26; Thu, 15 Feb 2024 09:53:27 +0000 Received: from AMS0EPF000001AC.eurprd05.prod.outlook.com (2603:10a6:20b:50e:cafe::b6) by AS9PR04CA0085.outlook.office365.com (2603:10a6:20b:50e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.26 via Frontend Transport; Thu, 15 Feb 2024 09:53:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF000001AC.mail.protection.outlook.com (10.167.16.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Thu, 15 Feb 2024 09:53:26 +0000 Received: ("Tessian outbound c21fe6ca13cc:v228"); Thu, 15 Feb 2024 09:53:26 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5a4c0972d2f78297 X-CR-MTA-TID: 64aa7808 Received: from 995e8ca43e38.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 88C73C75-D3B8-4D51-8FE7-692384F5006D.1; Thu, 15 Feb 2024 09:53:15 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 995e8ca43e38.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 15 Feb 2024 09:53:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YgLsNkgLWLOSzXJy7QP0XzIwu/bTnxuCM1F9cwMBUCMllcsH6abxFJjF1vZeWO3qKjfm729OUWzmzWrl+UH1zsnwHHqfxsm14xfkWFgEp8hdyPY4/CAb04WePyUNdPc3VL5JHZnkpRbT1AJdfOww9L9Z23x9nLQlc6zs1c4LLO2mZRyKeCFwqgONnScJLgjwEES7p8WhQ/f9WwnIEoRXYxs3CPGDdikplk4lvC3GQEtBXxc5O0D2wqm7V23VOPlP7KUAW6c/otvZxDZhYSWJ9JP/VeoDQGhd7GWXbli/MJkkPSQrNOCJs95u64cGc0+rNkDU5Zw3bJcEByq5EtA4xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MHu9U0I1eWaZf7c7IudvQW5Zrj8Gl4k8rkJc7iS8NTI=; b=QuTcgufQxFiSUV9JxYBXguI/W8JeZ9WF9sT6lLwJw8E+zGU46AXxuiuJ2hqtv2JPh6WZUmL3naU9CgnqjQXDrrGAlkxFRy5qUWlIZoYM4fgHZV/Jpl0SS9AiHkQAk/Lrr4x/Y60tKi/XaiZYGJFCyMDm7gn2qEt2mpdZg87SvUCXx9CeON0V3O4gfSS4etuJ5/tUlEVP0rW7al+VXBT8B7hDr2bLibfip6UTeMtVedC3mdv2ZG/jzQ2GwzheA0SXfLMAgcZquSLpJyo2exC8SnqyV4dw0/jSCncCdvRUbbErnELK8UOopfDdmNi6pSKN2xF4/i6IECE5DHWNJwBihA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MHu9U0I1eWaZf7c7IudvQW5Zrj8Gl4k8rkJc7iS8NTI=; b=aNdBX5a4RnPAY0J4arips42oL8Og826fx46k6cfkzp33j9cyRAbnLVZYF5+ejSyycu0Ev8DDl1gyqLc0jLduIWTE17dOzEptSRBnkrKBI9Sz1OeECZ72qwuClEPxfa3bae/6YBAydAtAzOMKhFhZ5/CVDXxVTwFZu+hYb1nD0L4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB7079.eurprd08.prod.outlook.com (2603:10a6:20b:400::12) by DB9PR08MB6426.eurprd08.prod.outlook.com (2603:10a6:10:255::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.26; Thu, 15 Feb 2024 09:53:13 +0000 Received: from AS8PR08MB7079.eurprd08.prod.outlook.com ([fe80::c463:f1a5:61fe:6490]) by AS8PR08MB7079.eurprd08.prod.outlook.com ([fe80::c463:f1a5:61fe:6490%5]) with mapi id 15.20.7292.029; Thu, 15 Feb 2024 09:53:13 +0000 Content-Type: multipart/mixed; boundary="------------mbHsEMqoWOQ1j2FCi4AhH7hH" Message-ID: <0420a460-aedf-486f-ae04-07095f2ff506@arm.com> Date: Thu, 15 Feb 2024 15:23:08 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Arm: Fix incorrect tailcall-generation for indirect calls [PR113780] Content-Language: en-US To: "Richard Earnshaw (lists)" , gcc-patches@gcc.gnu.org Cc: rearnsha@arm.com References: <20240207075921.2151371-1-tejas.belagod@arm.com> <91ae00db-b7a6-44c1-87db-385ccafb3a53@arm.com> <7d52db28-0d85-4008-91a5-977d19551290@arm.com> From: Tejas Belagod In-Reply-To: <7d52db28-0d85-4008-91a5-977d19551290@arm.com> X-ClientProxiedBy: KL1PR02CA0028.apcprd02.prod.outlook.com (2603:1096:820:d::15) To AS8PR08MB7079.eurprd08.prod.outlook.com (2603:10a6:20b:400::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB7079:EE_|DB9PR08MB6426:EE_|AMS0EPF000001AC:EE_|GV2PR08MB9421:EE_ X-MS-Office365-Filtering-Correlation-Id: fad33caf-4b54-4271-9a57-08dc2e0bf4d4 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 37XlbrhZCee9p0nozfbu/ypDQjQsYZkQ7taaJDwL8pbBvDFzfpUqfN8Oiza5272A9rRnp3QyCCpqqMqiBPuTiimVzSupjEFIP3eKD0m4BuZlrTwPp7+mHJK+pvSgTygazARwZ5ocozZPwDJZcim58n3He/4pu4seR+hHxgrqgeLBz7uTwBU2Eqa8RO4ymbPQhZVybWq8revEexpitv7tfot7MVIK38xTWmuJHtVUuLBnQ8TINQPrM7k9kpiFVyOlsmWJU0dtWqBu7ylIIPBxrLk94AO/r8NTRvr+O9hpPBuacNnTosRWR4ReO80qTNFdwh6+zm/5NATA2vCM6Jndct3In7MHiAiA7ZVOyyE2c3kyyj5YsZxwTW9JG+IM8FzxjQvSNzK2+chyHatCXY7fKgOScsiXFvPXhakZ4ILwOynsODFPNSR+yvUTafvKmu5d3Kx56l+3XbRAyVQ6W33pTSxG8rdNJA5x0Ioh7ln+awcp0lggzEqIS5rtBpndkHAW71qT7oHfAefLhjQye/56VzJojK0wYW8Yq/3Y/ODKuQE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7079.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(376002)(136003)(396003)(346002)(366004)(230922051799003)(64100799003)(1800799012)(451199024)(186009)(31686004)(86362001)(84970400001)(83380400001)(38100700002)(36756003)(31696002)(2906002)(235185007)(5660300002)(21480400003)(44832011)(66946007)(66556008)(66476007)(8936002)(41300700001)(4326008)(8676002)(316002)(6666004)(26005)(6506007)(6486002)(33964004)(6512007)(53546011)(478600001)(966005)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6426 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF000001AC.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cd822843-c7b3-4bdd-dcb8-08dc2e0bec88 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VlUg0VdfyGGWezr1rAbWgqhO3CSL1wayJWgH656ViibWnItUMacFrtvxS5jAPUy0o7qJChGP7683K84d5JXWdkFlNt+7okdduTvvFFSNX8pafU7+63wzN4pe+1jmSXx+fcpffTjYX9tqxkR4VWzZgMNhEn7H8zEoOLRvumY6tTrf/eq4K3SheGm1cWhpGTfNG9y11RflCGPArLuzr66u0zio9RpstHnXIutTindGinlr45Bg7S5jVETwubRE4g5IvRujpcNGFuO734Q5RHtSmo3AYEsOI5cCXPtVTwqY0/zfh6Wrd9Q5h62jEb6lyOa+q+4q2YQIEjJBmL38UgdLlGRNqbDG0T2amEA1PxVlJpolR5plqEdNtafY8iyKWCT8M142otlR9aPsn325Zd9uD90It5G1cyN3+Wp1qsBdheLX1hVLti69OlmwtACp482JH5PFRtXzcYVJXPoZ/QiQ9GvpPQf2veMxTTS5ZOzEEo6tUUxnPtTbSFOAbCncCtZZ/XP/rYbRAB6LJDTTeKBhastcfj0j2l3ZuZH/kKD6v4xCMDIFnGz5doVYEsAjiunlUDcq4znFxUC2jLnrs3yqw7BH269q9bXD4PriymV+adFW3e1Cc+BWPu8TRc4U4PU8qWQ3AnWvDxaLNdl/z4/oRg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(39860400002)(396003)(376002)(136003)(346002)(230922051799003)(64100799003)(1800799012)(186009)(82310400011)(451199024)(36860700004)(46966006)(40470700004)(86362001)(31696002)(31686004)(84970400001)(8936002)(5660300002)(235185007)(70206006)(8676002)(4326008)(966005)(6512007)(33964004)(6486002)(6506007)(478600001)(2906002)(44832011)(356005)(83380400001)(82740400003)(81166007)(2616005)(41300700001)(21480400003)(26005)(336012)(70586007)(36756003)(316002)(6666004)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 09:53:26.6078 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fad33caf-4b54-4271-9a57-08dc2e0bf4d4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001AC.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9421 X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,KAM_LOTSOFHASH,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------mbHsEMqoWOQ1j2FCi4AhH7hH Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/14/24 3:55 PM, Richard Earnshaw (lists) wrote: > On 14/02/2024 09:20, Tejas Belagod wrote: >> On 2/7/24 11:41 PM, Richard Earnshaw (lists) wrote: >>> On 07/02/2024 07:59, Tejas Belagod wrote: >>>> This patch fixes a bug that causes indirect calls in PAC-enabled functions >>>> to be tailcalled incorrectly when all argument registers R0-R3 are used. >>>> >>>> Tested on arm-none-eabi for armv8.1-m.main. OK for trunk? >>>> >>>> 2024-02-07  Tejas Belagod  >>>> >>>>     PR target/113780 >>>>     * gcc/config/arm.cc (arm_function_ok_for_sibcall): Don't allow tailcalls >>>>       for indirect calls with 4 or more arguments in pac-enabled functions. >>>> >>>>     * gcc.target/arm/pac-sibcall.c: New. >>>> --- >>>>   gcc/config/arm/arm.cc                      | 12 ++++++++---- >>>>   gcc/testsuite/gcc.target/arm/pac-sibcall.c | 11 +++++++++++ >>>>   2 files changed, 19 insertions(+), 4 deletions(-) >>>>   create mode 100644 gcc/testsuite/gcc.target/arm/pac-sibcall.c >>>> >>>> diff --git a/gcc/config/arm/arm.cc b/gcc/config/arm/arm.cc >>>> index c44047c377a..c1f8286a4d4 100644 >>>> --- a/gcc/config/arm/arm.cc >>>> +++ b/gcc/config/arm/arm.cc >>>> @@ -7980,10 +7980,14 @@ arm_function_ok_for_sibcall (tree decl, tree exp) >>>>         && DECL_WEAK (decl)) >>>>       return false; >>>>   -  /* We cannot do a tailcall for an indirect call by descriptor if all the >>>> -     argument registers are used because the only register left to load the >>>> -     address is IP and it will already contain the static chain.  */ >>>> -  if (!decl && CALL_EXPR_BY_DESCRIPTOR (exp) && !flag_trampolines) >>>> +  /* We cannot do a tailcall for an indirect call by descriptor or for an >>>> +     indirect call in a pac-enabled function if all the argument registers >>>> +     are used because the only register left to load the address is IP and >>>> +     it will already contain the static chain or the PAC signature in the >>>> +     case of PAC-enabled functions.  */ >>> >>> This comment is becoming a bit unwieldy.  I suggest restructuring it as: >>> >>> We cannot tailcall an indirect call by descriptor if all the call-clobbered >>> general registers are live (r0-r3 and ip).  This can happen when: >>>    - IP contains the static chain, or >>>    - IP is needed for validating the PAC signature. >>> >>> >>>> +  if (!decl >>>> +      && ((CALL_EXPR_BY_DESCRIPTOR (exp) && !flag_trampolines) >>>> +      || arm_current_function_pac_enabled_p())) >>>>       { >>>>         tree fntype = TREE_TYPE (TREE_TYPE (CALL_EXPR_FN (exp))); >>>>         CUMULATIVE_ARGS cum; >>>> diff --git a/gcc/testsuite/gcc.target/arm/pac-sibcall.c b/gcc/testsuite/gcc.target/arm/pac-sibcall.c >>>> new file mode 100644 >>>> index 00000000000..c57bf7a952c >>>> --- /dev/null >>>> +++ b/gcc/testsuite/gcc.target/arm/pac-sibcall.c >>>> @@ -0,0 +1,11 @@ >>>> +/* Testing return address signing.  */ >>>> +/* { dg-do compile } */ >>>> +/* { dg-require-effective-target mbranch_protection_ok } */ >>>> +/* { dg-options " -mcpu=cortex-m85 -mbranch-protection=pac-ret+leaf -O2" } */ >>> >>> No, you can't just add options like this, you need to first check that they won't result in conflicts with other options on the command line.  See https://gcc.gnu.org/pipermail/gcc-patches/2024-January/644077.html for an example of how to handle this. >>> >> Thanks for the review, Richard. Respin attached. >> >> Thanks, >> Tejas. >> >>>> + >>>> +void fail(void (*f)(int, int, int, int)) >>>> +{ >>>> +  f(1, 2, 3, 4); >>>> +} >>>> + >>>> +/* { dg-final { scan-assembler-not "bx\tip\t@ indirect register sibling call" } } */ >>> >>> R. >>> > +++ b/gcc/testsuite/gcc.target/arm/pac-sibcall.c > @@ -0,0 +1,14 @@ > +/* If all call-clobbered general registers are live (r0-r3, ip), disable > + indirect tail-call for a PAC-enabled function. */ > + > +/* { dg-do compile } */ > +/* { dg-require-effective-target mbranch_protection_ok } */ > This only checks if -mbranch-protection can work with the existing architecture/cpu; not with the flags you're about to add below. You should check for arm_arch_v8_1m_main_pacbti_ok instead; then you can assume that -mbranch-protection can be added. > Indeed! Thanks for catching that. > +/* { dg-add-options arm_arch_v8_1m_main_pacbti } */ > +/* { dg-additional-options "-mbranch-protection=pac-ret+leaf -O2" } */ > > Otherwise this is OK if you fix the above. > Thanks Richard. Respin attached. Will apply. Thanks, Tejas. > R. --------------mbHsEMqoWOQ1j2FCi4AhH7hH Content-Type: text/plain; charset=UTF-8; name="tail-call-m-1.txt" Content-Disposition: attachment; filename="tail-call-m-1.txt" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2djYy9jb25maWcvYXJtL2FybS5jYyBiL2djYy9jb25maWcvYXJtL2FybS5j YwppbmRleCBjNDQwNDdjMzc3YTgwMmQwYzFkYzE0MDZkZjFiODhhNmIwNzk2MDdiLi4xY2Q2OTI2 OGVlOTg2YTA5NTNjYzg1YWIyNTkzNTVkMjE5MTI1MGFjIDEwMDY0NAotLS0gYS9nY2MvY29uZmln L2FybS9hcm0uY2MKKysrIGIvZ2NjL2NvbmZpZy9hcm0vYXJtLmNjCkBAIC03OTgwLDEwICs3OTgw LDEzIEBAIGFybV9mdW5jdGlvbl9va19mb3Jfc2liY2FsbCAodHJlZSBkZWNsLCB0cmVlIGV4cCkK ICAgICAgICYmIERFQ0xfV0VBSyAoZGVjbCkpCiAgICAgcmV0dXJuIGZhbHNlOwogCi0gIC8qIFdl IGNhbm5vdCBkbyBhIHRhaWxjYWxsIGZvciBhbiBpbmRpcmVjdCBjYWxsIGJ5IGRlc2NyaXB0b3Ig aWYgYWxsIHRoZQotICAgICBhcmd1bWVudCByZWdpc3RlcnMgYXJlIHVzZWQgYmVjYXVzZSB0aGUg b25seSByZWdpc3RlciBsZWZ0IHRvIGxvYWQgdGhlCi0gICAgIGFkZHJlc3MgaXMgSVAgYW5kIGl0 IHdpbGwgYWxyZWFkeSBjb250YWluIHRoZSBzdGF0aWMgY2hhaW4uICAqLwotICBpZiAoIWRlY2wg JiYgQ0FMTF9FWFBSX0JZX0RFU0NSSVBUT1IgKGV4cCkgJiYgIWZsYWdfdHJhbXBvbGluZXMpCisg IC8qIFdlIGNhbm5vdCB0YWlsY2FsbCBhbiBpbmRpcmVjdCBjYWxsIGJ5IGRlc2NyaXB0b3IgaWYg YWxsIHRoZSBjYWxsLWNsb2JiZXJlZAorICAgICBnZW5lcmFsIHJlZ2lzdGVycyBhcmUgbGl2ZSAo cjAtcjMgYW5kIGlwKS4gIFRoaXMgY2FuIGhhcHBlbiB3aGVuOgorICAgICAgLSBJUCBjb250YWlu cyB0aGUgc3RhdGljIGNoYWluLCBvcgorICAgICAgLSBJUCBpcyBuZWVkZWQgZm9yIHZhbGlkYXRp bmcgdGhlIFBBQyBzaWduYXR1cmUuICAqLworICBpZiAoIWRlY2wKKyAgICAgICYmICgoQ0FMTF9F WFBSX0JZX0RFU0NSSVBUT1IgKGV4cCkgJiYgIWZsYWdfdHJhbXBvbGluZXMpCisJICB8fCBhcm1f Y3VycmVudF9mdW5jdGlvbl9wYWNfZW5hYmxlZF9wKCkpKQogICAgIHsKICAgICAgIHRyZWUgZm50 eXBlID0gVFJFRV9UWVBFIChUUkVFX1RZUEUgKENBTExfRVhQUl9GTiAoZXhwKSkpOwogICAgICAg Q1VNVUxBVElWRV9BUkdTIGN1bTsKZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZ2NjLnRhcmdl dC9hcm0vcGFjLXNpYmNhbGwuYyBiL2djYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9hcm0vcGFjLXNp YmNhbGwuYwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi5lMTViZDJmNDc4ZDFjOWFhZTU4NzBkZDU3MmU1ZmUwNDNmZDRk ZjFmCi0tLSAvZGV2L251bGwKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2FybS9wYWMt c2liY2FsbC5jCkBAIC0wLDAgKzEsMTQgQEAKKy8qIElmIGFsbCBjYWxsLWNsb2JiZXJlZCBnZW5l cmFsIHJlZ2lzdGVycyBhcmUgbGl2ZSAocjAtcjMsIGlwKSwgZGlzYWJsZQorICAgaW5kaXJlY3Qg dGFpbC1jYWxsIGZvciBhIFBBQy1lbmFibGVkIGZ1bmN0aW9uLiAgKi8KKworLyogeyBkZy1kbyBj b21waWxlIH0gKi8KKy8qIHsgZGctcmVxdWlyZS1lZmZlY3RpdmUtdGFyZ2V0IGFybV9hcmNoX3Y4 XzFtX21haW5fcGFjYnRpX29rIH0gKi8KKy8qIHsgZGctYWRkLW9wdGlvbnMgYXJtX2FyY2hfdjhf MW1fbWFpbl9wYWNidGkgfSAqLworLyogeyBkZy1hZGRpdGlvbmFsLW9wdGlvbnMgIi1tYnJhbmNo LXByb3RlY3Rpb249cGFjLXJldCtsZWFmIC1PMiIgfSAqLworCit2b2lkIGZhaWwodm9pZCAoKmYp KGludCwgaW50LCBpbnQsIGludCkpCit7CisgIGYoMSwgMiwgMywgNCk7Cit9CisKKy8qIHsgZGct ZmluYWwgeyBzY2FuLWFzc2VtYmxlci1ub3QgImJ4XHRpcFx0QCBpbmRpcmVjdCByZWdpc3RlciBz aWJsaW5nIGNhbGwiIH0gfSAqLwpkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9saWIvdGFyZ2V0 LXN1cHBvcnRzLmV4cCBiL2djYy90ZXN0c3VpdGUvbGliL3RhcmdldC1zdXBwb3J0cy5leHAKaW5k ZXggYjFmYWFmNGFhOTU1ZWZkYjc4Y2RjMTNhMTM5YTBhMTFiMjQwMTJhNy4uMGFmMmQzZWE4MGZi MWZkODk2NmYyODA2ZmU4N2UxZjg5ZGEyNjFmMyAxMDA2NDQKLS0tIGEvZ2NjL3Rlc3RzdWl0ZS9s aWIvdGFyZ2V0LXN1cHBvcnRzLmV4cAorKysgYi9nY2MvdGVzdHN1aXRlL2xpYi90YXJnZXQtc3Vw cG9ydHMuZXhwCkBAIC01NTM0LDcgKzU1MzQsNyBAQCBmb3JlYWNoIHsgYXJtZnVuYyBhcm1mbGFn IGFybWRlZnMgfSB7CiAJdjhtX21haW4gIi1tYXJjaD1hcm12OC1tLm1haW4rZnAgLW10aHVtYiIg X19BUk1fQVJDSF84TV9NQUlOX18KIAl2OF8xbV9tYWluICItbWFyY2g9YXJtdjguMS1tLm1haW4r ZnAgLW10aHVtYiIgX19BUk1fQVJDSF84TV9NQUlOX18KIAl2OF8xbV9tYWluX3BhY2J0aSAiLW1h cmNoPWFybXY4LjEtbS5tYWluK3BhY2J0aStmcCAtbXRodW1iIgotCQkiX19BUk1fQVJDSF84TV9N QUlOX18gJiYgX19BUk1fRkVBVFVSRV9CVEkiCisJCSJfX0FSTV9BUkNIXzhNX01BSU5fXyAmJiBf X0FSTV9GRUFUVVJFX0JUSSAmJiBfX0FSTV9GRUFUVVJFX1BBVVRIIgogCXY5YSAiLW1hcmNoPWFy bXY5LWErc2ltZCIgX19BUk1fQVJDSF85QV9fIH0gewogICAgIGV2YWwgW3N0cmluZyBtYXAgW2xp c3QgRlVOQyAkYXJtZnVuYyBGTEFHICRhcm1mbGFnIERFRlMgJGFybWRlZnMgXSB7CiAJcHJvYyBj aGVja19lZmZlY3RpdmVfdGFyZ2V0X2FybV9hcmNoX0ZVTkNfb2sgeyB9IHsK --------------mbHsEMqoWOQ1j2FCi4AhH7hH--