From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from server.nextmovesoftware.com (server.nextmovesoftware.com [162.254.253.69]) by sourceware.org (Postfix) with ESMTPS id 7FB043858D1E for ; Thu, 13 Jul 2023 17:10:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7FB043858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nextmovesoftware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nextmovesoftware.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nextmovesoftware.com; s=default; h=Content-Type:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WoXtpE23j3lgSs7y/5u/4FgxIm4JfjHClgjZRLAzr5A=; b=KCLhmK4D7alj+sQG8LU5MX/nRc dO81fgeswEDsYQ9fW2i3myWTmDYYz6JRHOmJAI/M+Q8LK2f6Il4584Nvc8jjHvtBPz76zqyWNBhhr rBJGnzm+KM5nLUqEI3pKRFrKZIfTm7QOLQwMxJi9vjrc3AldMWPrGLVH/Q2gkwVzcs6rUKZnKHBis VI+fZhPL/w47rXZPYkcuJw4/XKaWiQYF0NO05J9eFY7PK6kDQAv3ZNCK/RbMqRiM2IWnCpFpJfY14 qowzsGV55YqFSb2zscYdZ5Ho/yS+zPOgv8cx3S50F9kQ8xC8t6ZThsgr3kkhjkYr9ErPXxhzRk5Js haePwICw==; Received: from [185.62.158.67] (port=61250 helo=Dell) by server.nextmovesoftware.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qJzq6-0005e8-14; Thu, 13 Jul 2023 13:10:50 -0400 From: "Roger Sayle" To: Cc: "'Uros Bizjak'" Subject: [x86 PATCH] PR target/110588: Add *bt_setncqi_2 to generate btl Date: Thu, 13 Jul 2023 18:10:47 +0100 Message-ID: <042301d9b5ac$f84e3e60$e8eabb20$@nextmovesoftware.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0424_01D9B5B5.5A12A660" X-Mailer: Microsoft Outlook 16.0 Thread-Index: Adm1rKx60fRtYDRmRxufYQVIzNp5tA== Content-Language: en-gb X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.nextmovesoftware.com X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - nextmovesoftware.com X-Get-Message-Sender-Via: server.nextmovesoftware.com: authenticated_id: roger@nextmovesoftware.com X-Authenticated-Sender: server.nextmovesoftware.com: roger@nextmovesoftware.com X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multipart message in MIME format. ------=_NextPart_000_0424_01D9B5B5.5A12A660 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit This patch resolves PR target/110588 to catch another case in combine where the i386 backend should be generating a btl instruction. This adds another define_insn_and_split to recognize the RTL representation for this case. I also noticed that two related define_insn_and_split weren't using the preferred string style for single statement preparation-statements, so I've reformatted these to be consistent in style with the new one. This patch has been tested on x86_64-pc-linux-gnu with make bootstrap and make -k check, both with and without --target_board=unix{-m32} with no new failures. Ok for mainline? 2023-07-13 Roger Sayle gcc/ChangeLog PR target/110588 * config/i386/i386.md (*bt_setcqi): Prefer string form preparation statement over braces for a single statement. (*bt_setncqi): Likewise. (*bt_setncqi_2): New define_insn_and_split. gcc/testsuite/ChangeLog PR target/110588 * gcc.target/i386/pr110588.c: New test case. Thanks again, Roger -- ------=_NextPart_000_0424_01D9B5B5.5A12A660 Content-Type: text/plain; name="patchbt.txt" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="patchbt.txt" diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md=0A= index e47ced1..04eca049 100644=0A= --- a/gcc/config/i386/i386.md=0A= +++ b/gcc/config/i386/i386.md=0A= @@ -16170,9 +16170,7 @@=0A= (const_int 0)))=0A= (set (match_dup 0)=0A= (eq:QI (reg:CCC FLAGS_REG) (const_int 0)))]=0A= -{=0A= - operands[2] =3D lowpart_subreg (SImode, operands[2], QImode);=0A= -})=0A= + "operands[2] =3D lowpart_subreg (SImode, operands[2], QImode);")=0A= =0A= ;; Help combine recognize bt followed by setnc=0A= (define_insn_and_split "*bt_setncqi"=0A= @@ -16193,9 +16191,7 @@=0A= (const_int 0)))=0A= (set (match_dup 0)=0A= (ne:QI (reg:CCC FLAGS_REG) (const_int 0)))]=0A= -{=0A= - operands[2] =3D lowpart_subreg (SImode, operands[2], QImode);=0A= -})=0A= + "operands[2] =3D lowpart_subreg (SImode, operands[2], QImode);")=0A= =0A= (define_insn_and_split "*bt_setnc"=0A= [(set (match_operand:SWI48 0 "register_operand")=0A= @@ -16219,6 +16215,27 @@=0A= operands[2] =3D lowpart_subreg (SImode, operands[2], QImode);=0A= operands[3] =3D gen_reg_rtx (QImode);=0A= })=0A= +=0A= +;; Help combine recognize bt followed by setnc (PR target/110588)=0A= +(define_insn_and_split "*bt_setncqi_2"=0A= + [(set (match_operand:QI 0 "register_operand")=0A= + (eq:QI=0A= + (zero_extract:SWI48=0A= + (match_operand:SWI48 1 "register_operand")=0A= + (const_int 1)=0A= + (zero_extend:SI (match_operand:QI 2 "register_operand")))=0A= + (const_int 0)))=0A= + (clobber (reg:CC FLAGS_REG))]=0A= + "TARGET_USE_BT && ix86_pre_reload_split ()"=0A= + "#"=0A= + "&& 1"=0A= + [(set (reg:CCC FLAGS_REG)=0A= + (compare:CCC=0A= + (zero_extract:SWI48 (match_dup 1) (const_int 1) (match_dup 2))=0A= + (const_int 0)))=0A= + (set (match_dup 0)=0A= + (ne:QI (reg:CCC FLAGS_REG) (const_int 0)))]=0A= + "operands[2] =3D lowpart_subreg (SImode, operands[2], QImode);")=0A= =0C=0A= ;; Store-flag instructions.=0A= =0A= diff --git a/gcc/testsuite/gcc.target/i386/pr110588.c = b/gcc/testsuite/gcc.target/i386/pr110588.c=0A= new file mode 100644=0A= index 0000000..4505c87=0A= --- /dev/null=0A= +++ b/gcc/testsuite/gcc.target/i386/pr110588.c=0A= @@ -0,0 +1,18 @@=0A= +/* { dg-do compile } */=0A= +/* { dg-options "-O2 -mtune=3Dcore2" } */=0A= +=0A= +unsigned char foo (unsigned char x, int y)=0A= +{=0A= + int _1 =3D (int) x;=0A= + int _2 =3D _1 >> y;=0A= + int _3 =3D _2 & 1;=0A= + unsigned char _8 =3D (unsigned char) _3;=0A= + unsigned char _6 =3D _8 ^ 1;=0A= + return _6;=0A= +}=0A= +=0A= +/* { dg-final { scan-assembler "btl" } } */=0A= +/* { dg-final { scan-assembler "setnc" } } */=0A= +/* { dg-final { scan-assembler-not "sarl" } } */=0A= +/* { dg-final { scan-assembler-not "andl" } } */=0A= +/* { dg-final { scan-assembler-not "xorl" } } */=0A= ------=_NextPart_000_0424_01D9B5B5.5A12A660--