From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 635 invoked by alias); 12 Oct 2014 20:09:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 618 invoked by uid 89); 12 Oct 2014 20:09:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pa0-f42.google.com Received: from mail-pa0-f42.google.com (HELO mail-pa0-f42.google.com) (209.85.220.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 12 Oct 2014 20:09:57 +0000 Received: by mail-pa0-f42.google.com with SMTP id bj1so4777304pad.1 for ; Sun, 12 Oct 2014 13:09:55 -0700 (PDT) X-Received: by 10.70.130.136 with SMTP id oe8mr19243001pdb.18.1413144595477; Sun, 12 Oct 2014 13:09:55 -0700 (PDT) Received: from [192.168.1.35] (76-253-1-90.lightspeed.sntcca.sbcglobal.net. [76.253.1.90]) by mx.google.com with ESMTPSA id ty8sm9325618pab.26.2014.10.12.13.09.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 12 Oct 2014 13:09:53 -0700 (PDT) References: Mime-Version: 1.0 (1.0) In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: <044D8CC4-A3A3-4B5A-9D9A-FB01FB845131@gmail.com> Cc: "gcc-patches@gcc.gnu.org" , "manu@gcc.gnu.org" , "joseph@codesourcery.com" From: pinskia@gmail.com Subject: Re: [PATCH] cleanup in c-parser Date: Sun, 12 Oct 2014 20:36:00 -0000 To: Anthony Brandon X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg01081.txt.bz2 > On Oct 12, 2014, at 12:37 PM, Anthony Brandon = wrote: >=20 > Hi, >=20 > I'm a new contributor and I don't yet have a copyright assignment or > commit access. Thanks for you contribution. Your new function is missing a comment before= it saying what it does. Yes it might be obvious what the function does but= the coding style requires it.=20 Thanks, Andrew >=20 > This is a cleanup of code duplication in c-parser. > I bootstrapped and tested on x86_64-linux. >=20 >=20 > gcc/c/ChangeLog: >=20 > 2014-10-12 Anthony Brandon >=20 > * c-parser.c (c_parser_all_labels): New function to replace > the duplicate code. > (c_parser_statement): Call the new function. >