From: Jeff Law <jeffreyalaw@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>, Ian Lance Taylor <ian@airs.com>,
"Joseph S. Myers" <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Patch ping: Re: [PATCH] libgcc, i386, optabs, v2: Add __float{, un}tibf to libgcc and expand BF -> integral through SF intermediate [PR107703]
Date: Sat, 11 Mar 2023 08:03:22 -0700 [thread overview]
Message-ID: <045b148f-092f-c2dd-e096-0c882cd1553e@gmail.com> (raw)
In-Reply-To: <Y/9F63WhvL6uz4Z2@tucnak>
On 3/1/23 05:32, Jakub Jelinek via Gcc-patches wrote:
> Hi!
>
> On Wed, Nov 16, 2022 at 12:51:14PM +0100, Jakub Jelinek via Gcc-patches wrote:
>> On Wed, Nov 16, 2022 at 10:06:17AM +0100, Jakub Jelinek via Gcc-patches wrote:
>>> Thoughts on this? I guess my preference would be the BF -> SF -> TI
>>> path because we won't need to waste
>>> 32: 0000000000015e10 321 FUNC GLOBAL DEFAULT 13 __fixbfti@@GCC_13.0.0
>>> 89: 0000000000015f60 299 FUNC GLOBAL DEFAULT 13 __fixunsbfti@@GCC_13.0.0
>>> If so, I'd need to cut the fix parts of the patch below and
>>> do something in the middle-end.
>>
>> Here is adjusted patch that does that.
>>
>> 2022-11-16 Jakub Jelinek <jakub@redhat.com>
>>
>> PR target/107703
>> * optabs.cc (expand_fix): For conversions from BFmode to integral,
>> use shifts to convert it to SFmode first and then convert SFmode
>> to integral.
>>
>> * soft-fp/floattibf.c: New file.
>> * soft-fp/floatuntibf.c: New file.
>> * config/i386/libgcc-glibc.ver: Export __float{,un}tibf @ GCC_13.0.0.
>> * config/i386/64/t-softfp (softfp_extras): Add floattibf and
>> floatuntibf.
>> (CFLAGS-floattibf.c, CFLAGS-floatunstibf.c): Add -msse2.
>
> I'd like to ping the libgcc non-i386 part of this patch, Uros said the i386
> part is ok but that one depends on the generic libgcc changes.
> I'll ping the optabs.cc change separately.
>
> https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606398.html
> with more info in
> https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606382.html
The optab changes are OK too.
jeff
prev parent reply other threads:[~2023-03-11 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 9:06 [PATCH] libgcc, i386: Add __fix{,uns}bfti and __float{,un}tibf [PR107703] Jakub Jelinek
2022-11-16 11:51 ` [PATCH] libgcc, i386, optabs, v2: Add __float{,un}tibf to libgcc and expand BF -> integral through SF intermediate [PR107703] Jakub Jelinek
2023-03-01 12:32 ` Patch ping: Re: [PATCH] libgcc, i386, optabs, v2: Add __float{, un}tibf " Jakub Jelinek
2023-03-10 9:00 ` Jakub Jelinek
2023-03-10 18:10 ` Ian Lance Taylor
2023-03-11 9:17 ` Uros Bizjak
2023-03-11 15:03 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=045b148f-092f-c2dd-e096-0c882cd1553e@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ian@airs.com \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).