From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 2D56D3858D1E for ; Sat, 11 Mar 2023 15:03:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D56D3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x632.google.com with SMTP id i5so8566362pla.2 for ; Sat, 11 Mar 2023 07:03:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678547004; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kbKCmQ07whdnxSxWSFRci6mnEAR6Kt0zf9DzXZTvmrQ=; b=ShbLTdgf7WoxL05+8ZAgRcHFgWfEcKZbRhPRAfpiNtU4lOFYV90pC6DrXh8GyujUNZ hoUdk1u6n1avietYwm0oLeFHOmJsBNlTIq9GlL0YUZXR6KCjZ2kxXcHf7CSataHhkWtx YljmTHV+hpyh4trrJCWBOS+dcnRAgICUfk6zXdZ21pDqKdEEOaWX1GswSMx4whKC3yQo yv7Snefg9VTmn3hPsTaYYmQKljGxFFo050foxpoj6j+qsqXkxCQQjbIx5Qpfbzfugr+K B3aDh8WMzvqT3RxHvV8uN2DOmqr/3GQ6u2KdwGbVNdLID1NEZ32pth9OryMb1q5eZUIA x0SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678547004; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kbKCmQ07whdnxSxWSFRci6mnEAR6Kt0zf9DzXZTvmrQ=; b=f3Y5CINqctIigbKtWP46qVKOXAhJpP1VzviHvxtAZ7+HYQEWUr2Z2qSyU6nB0yh8j2 WNpqr0H3iNWVrugm87k8CKb0FH1j0bC+qBjl3pUznVJ5gvT7jJlVxfnNoG/S5H0f6ucY xger0G26naXPdrE4gV5Rw99u707Fd/WJD2dAIqSir1G2o3xwRlguWpcW/YIgdHlXjbKA scNHhcT2pikODepKJc6CswpedChX+ujiC4SAt8Y5TtYhokd0bGdx5/yemQ4uZrTGTEYN wDHpd7XQd3Xt1uWMbbbw01YHprRs3Kf5rDQ7jpB9KN49Y4AjW119rnOHIBWQIh3u6Uf1 CLtQ== X-Gm-Message-State: AO0yUKUxVxwziHasQZ1FvjhRmveO/LPNy3NSLfk5C3NCj9Gwav72XeYz 78SrNNcPem5oJKvEtm2ngSU= X-Google-Smtp-Source: AK7set8UTZIRM2Ke/CdHwNIl+mEXxhOivm2PBST4/2s3quBNdLZ85ypzcwueN/FA8IRT8/5okCJsEQ== X-Received: by 2002:a17:90a:1d46:b0:230:7a31:b9ac with SMTP id u6-20020a17090a1d4600b002307a31b9acmr29037886pju.48.1678547003839; Sat, 11 Mar 2023 07:03:23 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id a15-20020a17090a740f00b0022be36be19asm1604736pjg.53.2023.03.11.07.03.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Mar 2023 07:03:23 -0800 (PST) Message-ID: <045b148f-092f-c2dd-e096-0c882cd1553e@gmail.com> Date: Sat, 11 Mar 2023 08:03:22 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Patch ping: Re: [PATCH] libgcc, i386, optabs, v2: Add __float{, un}tibf to libgcc and expand BF -> integral through SF intermediate [PR107703] Content-Language: en-US To: Jakub Jelinek , Ian Lance Taylor , "Joseph S. Myers" Cc: gcc-patches@gcc.gnu.org References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/1/23 05:32, Jakub Jelinek via Gcc-patches wrote: > Hi! > > On Wed, Nov 16, 2022 at 12:51:14PM +0100, Jakub Jelinek via Gcc-patches wrote: >> On Wed, Nov 16, 2022 at 10:06:17AM +0100, Jakub Jelinek via Gcc-patches wrote: >>> Thoughts on this? I guess my preference would be the BF -> SF -> TI >>> path because we won't need to waste >>> 32: 0000000000015e10 321 FUNC GLOBAL DEFAULT 13 __fixbfti@@GCC_13.0.0 >>> 89: 0000000000015f60 299 FUNC GLOBAL DEFAULT 13 __fixunsbfti@@GCC_13.0.0 >>> If so, I'd need to cut the fix parts of the patch below and >>> do something in the middle-end. >> >> Here is adjusted patch that does that. >> >> 2022-11-16 Jakub Jelinek >> >> PR target/107703 >> * optabs.cc (expand_fix): For conversions from BFmode to integral, >> use shifts to convert it to SFmode first and then convert SFmode >> to integral. >> >> * soft-fp/floattibf.c: New file. >> * soft-fp/floatuntibf.c: New file. >> * config/i386/libgcc-glibc.ver: Export __float{,un}tibf @ GCC_13.0.0. >> * config/i386/64/t-softfp (softfp_extras): Add floattibf and >> floatuntibf. >> (CFLAGS-floattibf.c, CFLAGS-floatunstibf.c): Add -msse2. > > I'd like to ping the libgcc non-i386 part of this patch, Uros said the i386 > part is ok but that one depends on the generic libgcc changes. > I'll ping the optabs.cc change separately. > > https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606398.html > with more info in > https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606382.html The optab changes are OK too. jeff