From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: gcc-patches@gcc.gnu.org
Cc: jakub@redhat.com
Subject: Re: [PATCH 0/8] __builtin_dynamic_object_size and more
Date: Fri, 8 Oct 2021 10:20:57 +0530 [thread overview]
Message-ID: <045ced0d-b7f6-411c-adf5-78d6cab2d69c@gotplt.org> (raw)
In-Reply-To: <20211007221432.1029249-1-siddhesh@gotplt.org>
On 10/8/21 03:44, Siddhesh Poyarekar wrote:
> (from about 4% to 70% in bash), but that could well be due to the _chk
I should also clarify that this is for memcpy. For all fortifiable
functions, the coverage percentage went from 30.81% to 84.5% for bash.
Below is the full table. Please note that this is only based on symbols
emitted in the end as I didn't want to rebuild the _FORTIFIED_SOURCE=2
binaries, so it does not take into account the fact that _chk could get
folded to regular calls if we know at compile time that it's safe to do so.
No more posting patches at 4am; it only leads to more clarification
follow-ups :/
Func F(2) U(2) Cov(2) F(3) U(3) Cov(3)
----------------------------------------------------------------
asprintf 1 0 100.00% 1 0 100.00%
*confstr 0 2 0.00% 1 1 50.00%
fdelt 10 0 100.00% 10 0 100.00%
*fgets 0 1 0.00% 1 0 100.00%
fprintf 82 0 100.00% 82 0 100.00%
getcwd 0 3 0.00% 0 3 0.00%
*getgroups 0 1 0.00% 1 0 100.00%
gethostname 0 1 0.00% 0 1 0.00%
longjmp 23 0 100.00% 23 0 100.00%
mbsnrtowcs 0 2 0.00% 0 2 0.00%
*mbsrtowcs 0 1 0.00% 1 0 100.00%
*mbstowcs 0 10 0.00% 5 5 50.00%
*memcpy 7 170 3.95% 116 40 74.36%
*memmove 4 21 16.00% 12 17 41.38%
*memset 0 24 0.00% 3 21 12.50%
printf 150 0 100.00% 150 0 100.00%
*read 0 19 0.00% 8 11 42.11%
*readlink 0 3 0.00% 0 3 0.00%
snprintf 11 0 100.00% 11 0 100.00%
sprintf 28 0 100.00% 28 0 100.00%
*strcat 0 5 0.00% 8 0 100.00%
*strcpy 6 440 1.35% 413 36 91.98%
*strncpy 2 52 3.70% 33 19 63.46%
vfprintf 14 0 100.00% 14 0 100.00%
vsnprintf 4 0 100.00% 4 0 100.00%
wcrtomb 0 7 0.00% 0 7 0.00%
*wcsrtombs 0 3 0.00% 2 1 66.67%
wctomb 0 3 0.00% 0 3 0.00%
-----------------------------------------------------------------
Total 342 768 30.81% 927 170 84.50%
next prev parent reply other threads:[~2021-10-08 4:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 22:14 Siddhesh Poyarekar
2021-10-07 22:14 ` [PATCH 1/8] __builtin_dynamic_object_size: Recognize builtin name Siddhesh Poyarekar
2021-10-12 13:42 ` Jakub Jelinek
2021-10-12 14:22 ` Siddhesh Poyarekar
2021-10-07 22:14 ` [PATCH 2/8] tree-dynamic-object-size: New pass Siddhesh Poyarekar
2021-10-08 4:05 ` Siddhesh Poyarekar
2021-10-12 13:58 ` Jakub Jelinek
2021-10-12 14:28 ` Siddhesh Poyarekar
2021-10-07 22:14 ` [PATCH 3/8] tree-dynamic-object-size: Handle GIMPLE_PHI Siddhesh Poyarekar
2021-10-07 22:14 ` [PATCH 4/8] tree-dynamic-object-size: Support ADDR_EXPR Siddhesh Poyarekar
2021-10-07 22:14 ` [PATCH 5/8] tree-dynamic-object-size: Handle GIMPLE_ASSIGN Siddhesh Poyarekar
2021-10-07 22:14 ` [PATCH 6/8] tree-dynamic-object-size: Handle function parameters Siddhesh Poyarekar
2021-10-20 16:56 ` Martin Sebor
2021-10-20 16:59 ` Siddhesh Poyarekar
2021-10-07 22:14 ` [PATCH 7/8] tree-dynamic-object-size: Get subobject sizes Siddhesh Poyarekar
2021-10-07 22:14 ` [PATCH 8/8] tree-dynamic-object-size: Add test wrappers to extend testing Siddhesh Poyarekar
2021-10-08 4:50 ` Siddhesh Poyarekar [this message]
2021-10-17 19:57 ` [PATCH 0/8] __builtin_dynamic_object_size and more Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=045ced0d-b7f6-411c-adf5-78d6cab2d69c@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).